Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Editor: Group nodes to create node graph #2018

Open
lfl-eholthouser opened this issue Sep 16, 2024 · 3 comments
Open

Graph Editor: Group nodes to create node graph #2018

lfl-eholthouser opened this issue Sep 16, 2024 · 3 comments

Comments

@lfl-eholthouser
Copy link
Contributor

In order to create a node graph with the MaterialX Graph Editor the user needs to create a node graph node, double click on it to dive into that node and then add nodes inside that node graph node. Nodes that already exist can only be added to a node graph node by copying or cutting and pasting. I think it would be better for the user experience if there was a hot key that would create a node graph node and add all the selected nodes to it.

@jstone-lucasfilm jstone-lucasfilm changed the title Group nodes to create node graph in the Graph Editor Graph Editor: Group nodes to create node graph Sep 19, 2024
@WaffleBoyTom
Copy link

Hey, this is Thomas, I will be trying to tackle this issue during Dev Days :)

@kwokcb
Copy link
Contributor

kwokcb commented Sep 21, 2024

Two notes on this:

  1. Nested node graphs are disallowed in the editor currently due to lack of support. You'll want to check that the selected nodes do not include a nodegraph otherwise this will create unsupported nesting.

  2. @lfl-eholthouser, does this also include preserving connections ? I assume to keep it simple it it may not for dev-days , but good to have clarify what the desired logic is here.

@lfl-eholthouser
Copy link
Contributor Author

@kwokcb I was imagining it would preserve connections That way if someone had created a whole graph at the same level as the surface shader, but then realized they actually wanted it in its own nodegraph that work would not have to be redone. This could be two separate issues as well. If the initial phase is tackled during dev days, a new issue can be creating for adding support for connections in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants