Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking crashes in sharrow compile #15

Closed
i-am-sijia opened this issue Jun 26, 2024 · 1 comment
Closed

Benchmarking crashes in sharrow compile #15

i-am-sijia opened this issue Jun 26, 2024 · 1 comment

Comments

@i-am-sijia
Copy link
Contributor

When I attempted to run MTC benchmarking with the latest ActivitySim and Sharrow, it crashed in the sharrow compile mode. Complaining about utility not matching. I tried again from a fresh installation, it crashed at the same point.

To replicate:

image

activitysim.log

@jpn--
Copy link
Member

jpn-- commented Jul 25, 2024

This error occurred due to the atol parameter on the check being set to 0. We can see in the output the max absolute difference is only 3.278e-07, which is quite small but not actually zero. So in ActivitySim/activitysim#878 I have adjusted the default atol parameter on these checks in ActivitySim to 1e-06. I have run this same test per the notes above and I now see no error.

@jpn-- jpn-- closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants