Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check Sharrow memory usage fix (#751) is merged and implemented #816

Closed
i-am-sijia opened this issue Feb 22, 2024 · 1 comment
Closed
Assignees
Labels
Bug Something isn't working/bug f

Comments

@i-am-sijia
Copy link
Contributor

Describe the bug
In Phase 8, we identified a memory usage issue in Sharrow. It was holding onto Sharrow flow data from already completed simulations. This was revealed when we compared the memory foot print of mandatory tour scheduling model of runs with vs without Sharrow. In between the simulation of tour scheduling segments (i.e., work, school, univ), the non-Sharrow run had memory released and restart from a low "base" point but the Sharrow run did not release memory and it piled up.

This was fixed in PR #751 . And at the end of the data type optimization work in Phase 8, the profiling result showed it worked. See documentation here -> #673.

In the most recent benchmarking run, it seems the memory of the mandatory tour scheduling is piling up again, in between its segments, and also impacting the starting point of school escorting.

image

Zoomed in on Mandatory Tour Scheduling:

Non-sharrow:
image

Sharrow:
image

@i-am-sijia i-am-sijia added the Bug Something isn't working/bug f label Feb 22, 2024
@jpn--
Copy link
Member

jpn-- commented Apr 2, 2024

I believe we have collected evidence that this actually working fine, and any apparent intermittent high(er) memory usage is likely related to the vagaries of garbage collection.

@jpn-- jpn-- closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working/bug f
Projects
Status: Done
Development

No branches or pull requests

2 participants