Access to global constants and removing chooser col filtering #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpn--
requested changes
Nov 13, 2025
Member
|
@dhensle I have review this, and found there are substantive failures in the tests for this PR. Some of them look like issues with columns getting dropped at the wrong time, so that there are duplicate values when there shouldn't be. But the placeholder_multiple_zone test is getting a different problem: the model runs without crash or failure, but some of the math comes out different. I spent a few minutes trying to find the issue but it's somewhere deep. Can you investigate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #1016 and #1015. (These are in the same PR since they both arose when cleaning a single model's configs up.)