Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default item.csv stops at 19803, scrubbing won't go above that either #42

Open
LaernuTairos opened this issue May 9, 2022 · 4 comments

Comments

@LaernuTairos
Copy link

LaernuTairos commented May 9, 2022

Hey Adam.

I'm aware of the warning but I noticed the itemid list during scrubs won't pull item past adaman bullets 19803.
The default list only goes up to that as well.
But looking at the FFXIAH site and the SQLs for LSB, this should be going up to almost 30000. So items are missing it looks like.
Example: 28314 Aetosaur gear, can't get it in the CSV, unless we manually do that, but so much is missing it would take soooo long lol.
It seems like this may be on purpose because alot of items right after those bullets are rare/ex but those stop eventually & the IDs goes back to sellable items

Is there a command we can use to force the scrubber to go up to that #? Or is it already supposed to do that and I'm messing something up here. Maybe I got an old item.csv somehow, or it's an issue?
Thanks!

@ParalHAXX
Copy link

I have the same problem, i would like to pull prices for all the new items, but doesn't know how to do it without manually adding them one by one into the .csv, which is somewhat really painful.

If someone have an idea, i will be really interested.

Thank you

@AdamGagorik
Copy link
Owner

The download logic for the scrubber works by using category URLs.

For example, they look like this: http://www.ffxiah.com/browse/62/grips.

It seems like I stupidly hard-coded the max url integer to be 240. I have no idea why.

@AdamGagorik
Copy link
Owner

Here is the line that limits the category URL:

if category < 240:

@EDGECOM666
Copy link

check this out AdamGagorik

https://github.com/EDGECOM666/FFXIAHBOT_CSV

if you want to use my items.csv feel free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants