Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.selcuksportshd1590.xyz #196466

Closed
adguard-bot opened this issue Jan 16, 2025 · 16 comments
Closed

www.selcuksportshd1590.xyz #196466

adguard-bot opened this issue Jan 16, 2025 · 16 comments
Assignees

Comments

@adguard-bot
Copy link

Issue URL (Ads)

https://www.selcuksportshd1590.xyz/

Comment

tr geo specific

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard Browser Extension v4.4.49 MV2
System version: Windows 10
Browser: Brave
Tracking protection: disabled
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Turkish
Browsing Security: disabled
Browsing Security statistics: disabled
@zloyden
Copy link
Contributor

zloyden commented Jan 16, 2025

Seems to be geo-blocked, it does not work with a Turkish IP on my end.
@AdamWr @BlazDT please also take a look at this.

@zloyden zloyden closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2025
@kodiakhub
Copy link

@zloyden Please take a look.

Screenshot

image
image

This filter rule need to be updated:

[$domain=/^i\[a-z\]*\.strmrdr\[a-z\]+\..*/]#%#//scriptlet('set-constant', 'adscfg.enabled', 'false')

Also this (for regex domain):

||googleusercontent.com/img/*/crt$domain=selcuksportshd1472.xyz

@zloyden
Copy link
Contributor

zloyden commented Jan 16, 2025

So, the rules without domain part help?
I guess these should work.

[$domain=/^i[a-z]*\.strmrdr[a-z0-9]+\..*/]#%#//scriptlet('set-constant', 'adscfg.enabled', 'false')
||googleusercontent.com/img/*/crt$domain=/selcuksportshd\d+\.xyz/

@kodiakhub
Copy link

@zloyden yes, see:

Video

s.mp4

@zloyden zloyden reopened this Jan 16, 2025
@github-actions github-actions bot removed the A: In progress Work on the issue is in progress label Jan 16, 2025
@zloyden zloyden added the A: In progress Work on the issue is in progress label Jan 16, 2025
@zloyden
Copy link
Contributor

zloyden commented Jan 16, 2025

I've added the rules. Update should be available soon.
Thanks for checking this out.

@kodiakhub
Copy link

@zloyden I guess there is no filter update available? 🤔

@AdamWr
Copy link
Member

AdamWr commented Jan 17, 2025

There is a problem with filters compiler and it treats this rule as invalid when some characters are not escaped - AdguardTeam/FiltersCompiler#241
The workaround has been added, but if I'm not wrong, unfortunately it doesn't work in extension.

Maybe we could just change it to something like:

[$domain=/^i.*\.strmrdr.*\..*/]#%#//scriptlet('set-constant', 'adscfg.enabled', 'false')

@kodiakhub

This comment has been minimized.

@kodiakhub
Copy link

kodiakhub commented Jan 27, 2025

@AdamWr So far i see cinque, due, tre subdomain, so i suggest this, it's safe to add to filter list?

[$domain=/^[a-z]*e\.(?=.*[0-9])[a-z0-9]+\.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')

Also this need to be updated:

||selcuksportshd*.xyz/img/g/crtswp-s-min.png

to:

||googleusercontent.com/img/*/crtswp-s-min.png

Because it also appears in other domains such as "due, tre, cinque, strmrdr" /b|g|(etc)/

Screenshot

Image

@AdamWr
Copy link
Member

AdamWr commented Jan 27, 2025

As far as I understand, it matches any subdomain which ends with e, second level domain which has number and click TLD, for example:

more.1a.click
e.abc1.click
we.4re.click

so I'm not sure about that.
I would prefer something more specific.
If there is always cinque, due, tre, then it should be used, but I'm still not sure about that because it looks like that second level domain is "random".
I guess we would need more examples how these domains changes.

@kodiakhub
Copy link

kodiakhub commented Jan 27, 2025

I guess we would need more examples how these domains changes.

Sure!

But what if we make the 16-character domain as the target? 🤔

[$domain=/^[a-z]*e\.(?=.*[0-9])[a-z0-9]{16}\.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')
Details

Image

@AdamWr
Copy link
Member

AdamWr commented Jan 27, 2025

If it's always "16-character domain" then combined with cinque, due, tre subdomain should be fine, I guess.

[$domain=/^(?:cinque|due|tre)\.(?=.*[0-9])[a-z0-9]{16}\.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')

I see that there is also player.html, if it's always then we could use $url modifier.

@kodiakhub
Copy link

If it's always "16-character domain" then combined with cinque, due, tre subdomain should be fine, I guess.

[$domain=/^(?:cinque|due|tre).(?=.*[0-9])[a-z0-9]{16}.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')

Unfortunately, this part (?:cinque|due|tre) does not work in the user filter in the AdGuard extension. I first thought of this too, but I changed the rule because it wasn't working. 😄

I see that there is also player.html, if it's always then we could use $url modifier.

I have no idea about this, because I got help from chatGPT. But if you give what it looks like with the $url filter rule, we can test it.😄

@AdamWr
Copy link
Member

AdamWr commented Jan 27, 2025

If it doesn't work then we can use 3 different rules:

[$domain=/^tre\.(?=.*[0-9])[a-z0-9]{16}\.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')
[$domain=/^due\.(?=.*[0-9])[a-z0-9]{16}\.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')
[$domain=/^cinque\.(?=.*[0-9])[a-z0-9]{16}\.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')

Regarding $url rule, something like this:

[$url=/^https?:\/\/(?:cinque|due|tre)\.(?=.*[0-9])[a-z0-9]{16}\.click\/.*\/player\.html/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false') 

should works.

@kodiakhub
Copy link

kodiakhub commented Jan 27, 2025

If it doesn't work then we can use 3 different rules:

[$domain=/^tre.(?=.[0-9])[a-z0-9]{16}.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')
[$domain=/^due.(?=.
[0-9])[a-z0-9]{16}.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')
[$domain=/^cinque.(?=.*[0-9])[a-z0-9]{16}.click$/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')
Regarding $url rule, something like this:

[$url=/^https?://(?:cinque|due|tre).(?=.[0-9])[a-z0-9]{16}.click/./player.html/]#%#//scriptlet('set-constant', 'config.advertisement.enabled', 'false')
should works.

Both works, but I would recommend adding the $url filter rule as it is a single string rule. Will check the status from time to time. 😄

Note: normal refresh too late inject, hard refresh it works.


Also this need to be added/updated:

Screenshot

Image

AdamWr added a commit that referenced this issue Jan 27, 2025
@AdamWr
Copy link
Member

AdamWr commented Jan 27, 2025

Okay, I have added 2 rules.
There is $url related issue - AdguardTeam/FiltersCompiler#237, so it might be marked as invalid rule by filters compiler, and if so, then it will be not available in filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants