Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createMSDataObject and readMSDataFromFile functions should be made to read Experiment Data from file #269

Open
AdityaSavara opened this issue Nov 1, 2021 · 1 comment
Open

createMSDataObject and readMSDataFromFile functions should be made to read Experiment Data from file #269

AdityaSavara opened this issue Nov 1, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AdityaSavara
Copy link
Owner

Currently, we have a function named

createReferenceDataObject which calls readReferenceFile then returns a ReferenceData object.

We don't have an analogous set of functions for the MSData class. We should.
We could then also have an optional field for the number of header rows which would bring us closer to being able to simply read in exported mass spectrometry files.
@AdityaSavara AdityaSavara added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 1, 2021
@AdityaSavara
Copy link
Owner Author

When reading the ExperimentData from file, currently a top row that is a comment is expected (for describing the experiment etc.). That should be made optional, or at least a warning should be provided if the person is missing that top row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AdityaSavara