Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-Router Extension Not Working #31

Open
coatsnmore opened this issue Aug 4, 2017 · 5 comments
Open

UI-Router Extension Not Working #31

coatsnmore opened this issue Aug 4, 2017 · 5 comments
Assignees

Comments

@coatsnmore
Copy link

We are seeing issues with the ui-router extension. It breaks on the following line for each state in the ui-router extension#initializeModule method:

var offerData = $state.$current.locals.globals.offerData;

With the following error:
image

With the following dependencies:

"dependencies": {
    "@uirouter/angularjs": "^1.0.5",
    "angular": "^1.6.2",
    "bootstrap": "^4.0.0-alpha.6",
    "lodash": "^4.17.4"
  },

I am assuming this is a version incompatibility, but don't know enough to offer a solution.

@coatsnmore
Copy link
Author

Reproduced with ui-router extension 0.2.1.

@XDex
Copy link
Collaborator

XDex commented Aug 7, 2017

@coatsnmore I've taken a quick look, the problem is that there've been a number of breaking changes in ui-router 1.x release, compared to 0.2.x one, which is supported by the existing ui-router extension. We'll need to reimplement the extension to support the latest ui-router. I'll try to find some time to do it in the next few weeks..

@shawncreed
Copy link

@XDex Is there any chance you've been able to update this? This issue is a blocker for me on one of my client projects. Thank you!

@XDex
Copy link
Collaborator

XDex commented Nov 3, 2017

@shawncreed Sorry, we've been quite busy lately, I'll try to take a look once I have some spare time in the following weeks.. Btw, PRs are always welcome :)

@XDex
Copy link
Collaborator

XDex commented Dec 27, 2017

@coatsnmore @shawncreed Just fixed this in #38, please try out the new ui-router extension and let me know if you run into any issues..

@XDex XDex self-assigned this Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants