From a9ab64514eef89ffbba08821f960a1dd733300e9 Mon Sep 17 00:00:00 2001 From: Dmytro Shevtsov Date: Tue, 21 Nov 2023 15:15:07 -0600 Subject: [PATCH 1/4] COMDOX-156: Add a check for external links on GitHub --- .remarkrc.mjs | 21 +++-- package.json | 1 + yarn.lock | 216 +++++++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 228 insertions(+), 10 deletions(-) diff --git a/.remarkrc.mjs b/.remarkrc.mjs index b15ba81..4adc09c 100644 --- a/.remarkrc.mjs +++ b/.remarkrc.mjs @@ -1,6 +1,7 @@ -import remarkValidateLinks from 'remark-validate-links'; -import remarkFrontmatter from 'remark-frontmatter'; -import remarkLintFrontmatterSchema from 'remark-lint-frontmatter-schema'; +import remarkValidateLinks from "remark-validate-links"; +import remarkFrontmatter from "remark-frontmatter"; +import remarkLintFrontmatterSchema from "remark-lint-frontmatter-schema"; +import remarkLintNoDeadUrls from "remark-lint-no-dead-urls"; const remarkConfig = { plugins: [ @@ -11,13 +12,21 @@ const remarkConfig = { { schemas: { /* One schema for many files */ - './.github/linters/metadata.schema.yml': [ + "./.github/linters/metadata.schema.yml": [ /* Support glob patterns ———v */ - './src/pages/**/*.md', + "./src/pages/**/*.md", ], }, }, ], + [ + remarkLintNoDeadUrls, + { + skipUrlPatterns: [ + "https://www.php.net" + ] + } + ], ], }; -export default remarkConfig; \ No newline at end of file +export default remarkConfig; diff --git a/package.json b/package.json index 74499f8..1548a74 100644 --- a/package.json +++ b/package.json @@ -16,6 +16,7 @@ "remark-cli": "^10.0.1", "remark-frontmatter": "4.0.1", "remark-lint-frontmatter-schema": "^3.15.2", + "remark-lint-no-dead-urls": "^1.1.0", "remark-validate-links": "^11.0.2" }, "scripts": { diff --git a/yarn.lock b/yarn.lock index a4a6e9a..b883983 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2794,6 +2794,13 @@ __metadata: languageName: node linkType: hard +"@leichtgewicht/ip-codec@npm:^2.0.1": + version: 2.0.4 + resolution: "@leichtgewicht/ip-codec@npm:2.0.4" + checksum: 468de1f04d33de6d300892683d7c8aecbf96d1e2c5fe084f95f816e50a054d45b7c1ebfb141a1447d844b86a948733f6eebd92234da8581c84a1ad4de2946a2d + languageName: node + linkType: hard + "@lezer/common@npm:^0.15.0, @lezer/common@npm:^0.15.7": version: 0.15.12 resolution: "@lezer/common@npm:0.15.12" @@ -6392,6 +6399,18 @@ __metadata: languageName: node linkType: hard +"check-links@npm:^1.1.8": + version: 1.1.8 + resolution: "check-links@npm:1.1.8" + dependencies: + got: ^9.6.0 + is-relative-url: ^2.0.0 + p-map: ^2.0.0 + p-memoize: ^2.1.0 + checksum: b73296feb4f4a6b58fd93fb34a8252e42dae166b3232e789dad02e378dddd3d46427906291beb033b6bc273b4c0ffc0e51a7e9762b6a52e70eaa719ade164310 + languageName: node + linkType: hard + "cheerio-select@npm:^2.1.0": version: 2.1.0 resolution: "cheerio-select@npm:2.1.0" @@ -6613,6 +6632,13 @@ __metadata: languageName: node linkType: hard +"co@npm:3.1.0": + version: 3.1.0 + resolution: "co@npm:3.1.0" + checksum: b7c685595103663317be1cbe3a00386b0b3643a6a859aaeb20ca2a7fa8b0d5c5f744de55d8b0b44bb07635c86bcd48d64684fcfccf52381ede3de55ed374dc80 + languageName: node + linkType: hard + "collapse-white-space@npm:^1.0.2": version: 1.0.6 resolution: "collapse-white-space@npm:1.0.6" @@ -6743,6 +6769,7 @@ __metadata: remark-cli: ^10.0.1 remark-frontmatter: 4.0.1 remark-lint-frontmatter-schema: ^3.15.2 + remark-lint-no-dead-urls: ^1.1.0 remark-validate-links: ^11.0.2 languageName: unknown linkType: soft @@ -7805,6 +7832,24 @@ __metadata: languageName: node linkType: hard +"dns-packet@npm:^5.2.4": + version: 5.6.1 + resolution: "dns-packet@npm:5.6.1" + dependencies: + "@leichtgewicht/ip-codec": ^2.0.1 + checksum: 64c06457f0c6e143f7a0946e0aeb8de1c5f752217cfa143ef527467c00a6d78db1835cfdb6bb68333d9f9a4963cf23f410439b5262a8935cce1236f45e344b81 + languageName: node + linkType: hard + +"dns-socket@npm:^4.2.2": + version: 4.2.2 + resolution: "dns-socket@npm:4.2.2" + dependencies: + dns-packet: ^5.2.4 + checksum: d02b83ecc9b0f1d2fc459f93c6390c768a8805002637d1f74113d623fa7b2478a695ade7761a0a847622781f5e6dd008a9a1469ac75a617bdf1b775f2156943c + languageName: node + linkType: hard + "doctrine@npm:^2.1.0": version: 2.1.0 resolution: "doctrine@npm:2.1.0" @@ -11615,6 +11660,13 @@ __metadata: languageName: node linkType: hard +"ip-regex@npm:^4.0.0": + version: 4.3.0 + resolution: "ip-regex@npm:4.3.0" + checksum: 7ff904b891221b1847f3fdf3dbb3e6a8660dc39bc283f79eb7ed88f5338e1a3d1104b779bc83759159be266249c59c2160e779ee39446d79d4ed0890dfd06f08 + languageName: node + linkType: hard + "ip@npm:^2.0.0": version: 2.0.0 resolution: "ip@npm:2.0.0" @@ -11629,6 +11681,13 @@ __metadata: languageName: node linkType: hard +"is-absolute-url@npm:^2.0.0": + version: 2.1.0 + resolution: "is-absolute-url@npm:2.1.0" + checksum: 781e8cf8a2af54b1b7a92f269244d96c66224030d91120e734ebeebbce044c167767e1389789d8aaf82f9e429cb20ae93d6d0acfe6c4b53d2bd6ebb47a236d76 + languageName: node + linkType: hard + "is-absolute-url@npm:^3.0.0": version: 3.0.3 resolution: "is-absolute-url@npm:3.0.3" @@ -11887,6 +11946,15 @@ __metadata: languageName: node linkType: hard +"is-ip@npm:^3.1.0": + version: 3.1.0 + resolution: "is-ip@npm:3.1.0" + dependencies: + ip-regex: ^4.0.0 + checksum: da2c2b282407194adf2320bade0bad94be9c9d0bdab85ff45b1b62d8185f31c65dff3884519d57bf270277e5ea2046c7916a6e5a6db22fe4b7ddcdd3760f23eb + languageName: node + linkType: hard + "is-lambda@npm:^1.0.1": version: 1.0.1 resolution: "is-lambda@npm:1.0.1" @@ -11956,6 +12024,18 @@ __metadata: languageName: node linkType: hard +"is-online@npm:^8.2.1": + version: 8.5.1 + resolution: "is-online@npm:8.5.1" + dependencies: + got: ^9.6.0 + p-any: ^2.0.0 + p-timeout: ^3.0.0 + public-ip: ^4.0.1 + checksum: 87d7f321dc872f0e4c7ac058595dcd058d7e09931f3b4fc29164f9d610564b9e9b15adf9ff4427bd273a47ef0da55b66a97a0e535584249d04a26d0ec134bf56 + languageName: node + linkType: hard + "is-path-inside@npm:^3.0.2": version: 3.0.3 resolution: "is-path-inside@npm:3.0.3" @@ -12017,6 +12097,15 @@ __metadata: languageName: node linkType: hard +"is-relative-url@npm:^2.0.0": + version: 2.0.0 + resolution: "is-relative-url@npm:2.0.0" + dependencies: + is-absolute-url: ^2.0.0 + checksum: 5acb66d6374a0c89fb68a770c94eeee3061b7d2e94d1fdff4d780b3054caf681ad33ed9d554eebeaedd897d90b781684c84ed85c7581d5d50767e857af3a199e + languageName: node + linkType: hard + "is-relative-url@npm:^3.0.0": version: 3.0.0 resolution: "is-relative-url@npm:3.0.0" @@ -13270,7 +13359,7 @@ __metadata: languageName: node linkType: hard -"map-age-cleaner@npm:^0.1.3": +"map-age-cleaner@npm:^0.1.1, map-age-cleaner@npm:^0.1.3": version: 0.1.3 resolution: "map-age-cleaner@npm:0.1.3" dependencies: @@ -13697,6 +13786,17 @@ __metadata: languageName: node linkType: hard +"mem@npm:^4.0.0": + version: 4.3.0 + resolution: "mem@npm:4.3.0" + dependencies: + map-age-cleaner: ^0.1.1 + mimic-fn: ^2.0.0 + p-is-promise: ^2.0.0 + checksum: cf488608e5d59c6cb68004b70de317222d4be9f857fd535dfa6a108e04f40821479c080bc763c417b1030569d303538c59d441280078cfce07fefd1c523f98ef + languageName: node + linkType: hard + "mem@npm:^8.1.1": version: 8.1.1 resolution: "mem@npm:8.1.1" @@ -14150,7 +14250,14 @@ __metadata: languageName: node linkType: hard -"mimic-fn@npm:^2.1.0": +"mimic-fn@npm:^1.0.0": + version: 1.2.0 + resolution: "mimic-fn@npm:1.2.0" + checksum: 69c08205156a1f4906d9c46f9b4dc08d18a50176352e77fdeb645cedfe9f20c0b19865d465bd2dec27a5c432347f24dc07fc3695e11159d193f892834233e939 + languageName: node + linkType: hard + +"mimic-fn@npm:^2.0.0, mimic-fn@npm:^2.1.0": version: 2.1.0 resolution: "mimic-fn@npm:2.1.0" checksum: d2421a3444848ce7f84bd49115ddacff29c15745db73f54041edc906c14b131a38d05298dae3081667627a59b2eb1ca4b436ff2e1b80f69679522410418b478a @@ -15220,6 +15327,17 @@ __metadata: languageName: node linkType: hard +"p-any@npm:^2.0.0": + version: 2.1.0 + resolution: "p-any@npm:2.1.0" + dependencies: + p-cancelable: ^2.0.0 + p-some: ^4.0.0 + type-fest: ^0.3.0 + checksum: c65924474214b5cb66b4ad8a2860f4d57f1cde81c0e0f505c013ee7bc9bde1ea68d0a6a82732f16643f8e14d473887da5d617397ccda4bf25a218492d70a1d86 + languageName: node + linkType: hard + "p-cancelable@npm:^1.0.0": version: 1.1.0 resolution: "p-cancelable@npm:1.1.0" @@ -15255,6 +15373,13 @@ __metadata: languageName: node linkType: hard +"p-is-promise@npm:^2.0.0": + version: 2.1.0 + resolution: "p-is-promise@npm:2.1.0" + checksum: c9a8248c8b5e306475a5d55ce7808dbce4d4da2e3d69526e4991a391a7809bfd6cfdadd9bf04f1c96a3db366c93d9a0f5ee81d949e7b1684c4e0f61f747199ef + languageName: node + linkType: hard + "p-limit@npm:3.1.0, p-limit@npm:^3.0.2": version: 3.1.0 resolution: "p-limit@npm:3.1.0" @@ -15318,6 +15443,13 @@ __metadata: languageName: node linkType: hard +"p-map@npm:^2.0.0": + version: 2.1.0 + resolution: "p-map@npm:2.1.0" + checksum: 9e3ad3c9f6d75a5b5661bcad78c91f3a63849189737cd75e4f1225bf9ac205194e5c44aac2ef6f09562b1facdb9bd1425584d7ac375bfaa17b3f1a142dab936d + languageName: node + linkType: hard + "p-map@npm:^4.0.0": version: 4.0.0 resolution: "p-map@npm:4.0.0" @@ -15327,6 +15459,16 @@ __metadata: languageName: node linkType: hard +"p-memoize@npm:^2.1.0": + version: 2.1.0 + resolution: "p-memoize@npm:2.1.0" + dependencies: + mem: ^4.0.0 + mimic-fn: ^1.0.0 + checksum: dea93ed68cfc9be8d147054c5ccd70c8145224de828ad84246273ac41b601e6f6becadae7c3be8e93ffc6673767e79c781706f88b3f67d74ba95ef631d3b033e + languageName: node + linkType: hard + "p-queue@npm:^6.6.2": version: 6.6.2 resolution: "p-queue@npm:6.6.2" @@ -15337,7 +15479,17 @@ __metadata: languageName: node linkType: hard -"p-timeout@npm:^3.2.0": +"p-some@npm:^4.0.0": + version: 4.1.0 + resolution: "p-some@npm:4.1.0" + dependencies: + aggregate-error: ^3.0.0 + p-cancelable: ^2.0.0 + checksum: 7ef6a808c53ac2d96954dd26c1406ebbc14c89a092f46f65b0902601ed9db3b2fb7855d18624645157d56de9a51c59ce98378a68b797617204028addfbada10a + languageName: node + linkType: hard + +"p-timeout@npm:^3.0.0, p-timeout@npm:^3.2.0": version: 3.2.0 resolution: "p-timeout@npm:3.2.0" dependencies: @@ -16573,6 +16725,17 @@ __metadata: languageName: node linkType: hard +"public-ip@npm:^4.0.1": + version: 4.0.4 + resolution: "public-ip@npm:4.0.4" + dependencies: + dns-socket: ^4.2.2 + got: ^9.6.0 + is-ip: ^3.1.0 + checksum: 9a0c3194b219d14e8996080f90857ca025c37ebe233cb89b7ba629714ebcdc6dfd563084931d497c597b56599468ec064b7a9196bbdc92feefa908d1e1585ea7 + languageName: node + linkType: hard + "pump@npm:^3.0.0": version: 3.0.0 resolution: "pump@npm:3.0.0" @@ -17274,6 +17437,18 @@ __metadata: languageName: node linkType: hard +"remark-lint-no-dead-urls@npm:^1.1.0": + version: 1.1.0 + resolution: "remark-lint-no-dead-urls@npm:1.1.0" + dependencies: + check-links: ^1.1.8 + is-online: ^8.2.1 + unified-lint-rule: ^1.0.4 + unist-util-visit: ^2.0.1 + checksum: e409b9896b6da801643b07514a32b7ff55b0f056f4585a6fdfaad7900e41907368750bccd84ae24d7f633291457243e01f871cd9a74f04befce37b6d8c0f165a + languageName: node + linkType: hard + "remark-mdx@npm:1.6.22": version: 1.6.22 resolution: "remark-mdx@npm:1.6.22" @@ -18308,6 +18483,13 @@ __metadata: languageName: node linkType: hard +"sliced@npm:^1.0.1": + version: 1.0.1 + resolution: "sliced@npm:1.0.1" + checksum: 84528d23279985ead75809eeec5d601b0fb6bc28348c6627f4feb40747533a1e36a75e8bc60f9079528079b21c434890b397e8fc5c24a649165cc0bbe90b4d70 + languageName: node + linkType: hard + "slugify@npm:^1.4.4, slugify@npm:^1.6.1": version: 1.6.5 resolution: "slugify@npm:1.6.5" @@ -19580,6 +19762,13 @@ __metadata: languageName: node linkType: hard +"type-fest@npm:^0.3.0": + version: 0.3.1 + resolution: "type-fest@npm:0.3.1" + checksum: 347ff46c2285616635cb59f722e7f396bee81b8988b6fc1f1536b725077f2abf6ccfa22ab7a78e9b6ce7debea0e6614bbf5946cbec6674ec1bde12113af3a65c + languageName: node + linkType: hard + "type-fest@npm:^0.8.0, type-fest@npm:^0.8.1": version: 0.8.1 resolution: "type-fest@npm:0.8.1" @@ -19779,6 +19968,15 @@ __metadata: languageName: node linkType: hard +"unified-lint-rule@npm:^1.0.4": + version: 1.0.6 + resolution: "unified-lint-rule@npm:1.0.6" + dependencies: + wrapped: ^1.0.1 + checksum: fb3fa8a08bab260e8200a40de48180d422cc7beb118cd74352490a6e8e42346ffbaed47e43593df4b5519eead0f67d71d1e4031b1b100a9aaf5f42d7b6135d54 + languageName: node + linkType: hard + "unified-lint-rule@npm:^2.1.1": version: 2.1.2 resolution: "unified-lint-rule@npm:2.1.2" @@ -20096,7 +20294,7 @@ __metadata: languageName: node linkType: hard -"unist-util-visit@npm:2.0.3, unist-util-visit@npm:^2.0.0, unist-util-visit@npm:^2.0.3": +"unist-util-visit@npm:2.0.3, unist-util-visit@npm:^2.0.0, unist-util-visit@npm:^2.0.1, unist-util-visit@npm:^2.0.3": version: 2.0.3 resolution: "unist-util-visit@npm:2.0.3" dependencies: @@ -20944,6 +21142,16 @@ __metadata: languageName: node linkType: hard +"wrapped@npm:^1.0.1": + version: 1.0.1 + resolution: "wrapped@npm:1.0.1" + dependencies: + co: 3.1.0 + sliced: ^1.0.1 + checksum: 549d3a0dae46f97eae15f749dc9c512cbbb0db716e1f2bc48e3e134123c941750ed008bb2799d154406154e69fb3b2e504964d9bd8e3c63e99ac4991cfd00ae8 + languageName: node + linkType: hard + "wrappy@npm:1": version: 1.0.2 resolution: "wrappy@npm:1.0.2" From dd2528048fe2f474a49bf75c232e91fa3ce718aa Mon Sep 17 00:00:00 2001 From: Jeff Matthews Date: Wed, 22 Nov 2023 12:16:50 -0600 Subject: [PATCH 2/4] COMDOX-156: Fixed dead URL warnings --- .remarkrc.mjs | 1 + src/pages/guides/sellers/copy-paste-detector.md | 2 +- src/pages/guides/sellers/developer-portal.md | 2 +- src/pages/guides/sellers/installation-and-varnish-tests.md | 4 ++-- src/pages/guides/sellers/malware-scan.md | 4 ++-- src/pages/guides/sellers/semantic-version-check.md | 2 +- src/pages/guides/sellers/submit-for-marketing-review.md | 2 +- .../guides/sellers/subscriptions/buying-subscriptions.md | 2 +- .../guides/sellers/subscriptions/extension-subscriptions.md | 2 +- .../guides/sellers/subscriptions/selling-subscriptions.md | 2 +- src/pages/index.md | 2 +- 11 files changed, 13 insertions(+), 12 deletions(-) diff --git a/.remarkrc.mjs b/.remarkrc.mjs index 4adc09c..f9a33b4 100644 --- a/.remarkrc.mjs +++ b/.remarkrc.mjs @@ -23,6 +23,7 @@ const remarkConfig = { remarkLintNoDeadUrls, { skipUrlPatterns: [ + "https://marketplacesupport.magento.com", "https://www.php.net" ] } diff --git a/src/pages/guides/sellers/copy-paste-detector.md b/src/pages/guides/sellers/copy-paste-detector.md index 1da0cb7..e4bc7c3 100644 --- a/src/pages/guides/sellers/copy-paste-detector.md +++ b/src/pages/guides/sellers/copy-paste-detector.md @@ -39,6 +39,6 @@ Implementing a solution for detecting plagiarism in source code is not a trivial - We might incorrectly identify code fragments that follow a common pattern as duplicates. To prevent a submission from being rejected due to incorrect results, we also perform manual code review. Even with manual reviews, we can still make mistakes. -If you notice a submission that is rejected or approved based on inaccurate information from the copy paste detector, [create a Marketplace Support ticket](https://commercemarketplace-support.adobe.com/hc/en-us) so that we can resolve your case and keep our community healthy. Please specify your Submission ID in a ticket. +If you notice a submission that is rejected or approved based on inaccurate information from the copy paste detector, [create a Marketplace Support ticket](https://marketplacesupport.magento.com/hc/en-us) so that we can resolve your case and keep our community healthy. Please specify your Submission ID in a ticket. We always welcome feedback and discussion on the [Magento Community Engineering Slack](https://magentocommeng.slack.com/archives/C7SL5CGDN) #marketplace channel. diff --git a/src/pages/guides/sellers/developer-portal.md b/src/pages/guides/sellers/developer-portal.md index ea408b3..cb59954 100644 --- a/src/pages/guides/sellers/developer-portal.md +++ b/src/pages/guides/sellers/developer-portal.md @@ -21,6 +21,6 @@ Once you're logged in, these menus appear at the top of portal front page. |[Shared Packages](shared-packages.md)|Takes you to the Your Shared Packages page.| |[Reports](sales.md)|[Sales](sales.md) - Takes you to your Sales reports.
[Analytics](analytics.md) - Takes you to your sales Analytics reports.| |Resources|Lists policy information and provides links to the documentation.| -|[Support](https://commercemarketplace-support.adobe.com/hc/en-us)|Opens the [Commerce Marketplace Help Center](https://commercemarketplace-support.adobe.com/hc/en-us).| +|[Support](https://marketplacesupport.magento.com/hc/en-us)|Opens the [Commerce Marketplace Help Center](https://marketplacesupport.magento.com/hc/en-us).| |Community|Links to the Adobe Developer [Magento Open Source](https://developer.adobe.com/open/magento) page. | |[Profile Information](profile-information.md)|Account Information
Sign Out| diff --git a/src/pages/guides/sellers/installation-and-varnish-tests.md b/src/pages/guides/sellers/installation-and-varnish-tests.md index 54fc334..7bc743b 100644 --- a/src/pages/guides/sellers/installation-and-varnish-tests.md +++ b/src/pages/guides/sellers/installation-and-varnish-tests.md @@ -49,7 +49,7 @@ The Installation and Varnish tests always use the latest patch version for the M ### Additional configuration -The Varnish test requires [Varnish as a caching application](https://experienceleague.adobe.com/docs/commerce-operations/configuration-guide/cache/varnish/config-varnish-magento.html). The test checks for the presence of the **X-EQP-Cache** HTTP header set by Varnish and analyzes its value on page loads. To complete this check, the following additional instruction must be added to the **vcl_deliver** function: +The Varnish test requires [Varnish as a caching application](https://experienceleague.adobe.com/docs/commerce-operations/configuration-guide/cache/configure-varnish-commerce.html). The test checks for the presence of the **X-EQP-Cache** HTTP header set by Varnish and analyzes its value on page loads. To complete this check, the following additional instruction must be added to the **vcl_deliver** function: ```vcl sub vcl_deliver { @@ -136,6 +136,6 @@ To debug Varnish test errors, we recommend using a locally installed Commerce ve ## Troubleshooting -If the submission fails Installation and Varnish testing, and you cannot reproduce or troubleshoot the issues locally, [create a Support ticket](https://commercemarketplace-support.adobe.com/hc/en-us) to request assistance. Ensure that the relevant Submission ID is included on the ticket. +If the submission fails Installation and Varnish testing, and you cannot reproduce or troubleshoot the issues locally, [create a Support ticket](https://marketplacesupport.magento.com/hc/en-us) to request assistance. Ensure that the relevant Submission ID is included on the ticket. We always welcome feedback and discussion on the [Magento Community Engineering Slack](https://magentocommeng.slack.com/archives/C7SL5CGDN) #marketplace channel. diff --git a/src/pages/guides/sellers/malware-scan.md b/src/pages/guides/sellers/malware-scan.md index 530fb0e..5191e0a 100644 --- a/src/pages/guides/sellers/malware-scan.md +++ b/src/pages/guides/sellers/malware-scan.md @@ -42,8 +42,8 @@ If the malware scan fails, check the integrity of the files you uploaded by usin ## Troubleshooting -If the malware scan fails on a valid listing, [create a Support ticket](https://commercemarketplace-support.adobe.com/hc/en-us) and describe the use case. +If the malware scan fails on a valid listing, [create a Support ticket](https://marketplacesupport.magento.com/hc/en-us) and describe the use case. -If you find any code on the [Commerce Marketplace](https://commercemarketplace.adobe.com) that looks suspicious, contact Magento immediately through the [Marketplace Support Portal](https://commercemarketplace-support.adobe.com/hc/en-us). +If you find any code on the [Commerce Marketplace](https://commercemarketplace.adobe.com) that looks suspicious, contact Magento immediately through the [Marketplace Support Portal](https://marketplacesupport.magento.com/hc/en-us). We always welcome feedback and discussion on the [Magento Community Engineering Slack](https://magentocommeng.slack.com/archives/C7SL5CGDN) #marketplace channel. diff --git a/src/pages/guides/sellers/semantic-version-check.md b/src/pages/guides/sellers/semantic-version-check.md index fd15107..26039f5 100644 --- a/src/pages/guides/sellers/semantic-version-check.md +++ b/src/pages/guides/sellers/semantic-version-check.md @@ -57,7 +57,7 @@ php magento-semver/bin/svc compare This command requires an environment with PHP version 7.2.29 or later. -If the semantic version check detects any issues, [create a support ticket](https://commercemarketplace-support.adobe.com/hc/en-us) to request assistance. Specify the relevant Submission ID in the ticket. +If the semantic version check detects any issues, [create a support ticket](https://marketplacesupport.magento.com/hc/en-us) to request assistance. Specify the relevant Submission ID in the ticket. As the check is solely based on [Magento SemVer open source project](https://github.com/magento/magento-semver), submitting an issue or pull request on GitHub is highly recommended. diff --git a/src/pages/guides/sellers/submit-for-marketing-review.md b/src/pages/guides/sellers/submit-for-marketing-review.md index c3a0902..acbc900 100644 --- a/src/pages/guides/sellers/submit-for-marketing-review.md +++ b/src/pages/guides/sellers/submit-for-marketing-review.md @@ -111,7 +111,7 @@ You must provide a thumbnail and at least two high-quality images for the image ### Support (optional) -Customers are advised to contact you directly for support, using the information that you provide. For support issues related to Commerce Marketplace, see the [Help Center](https://commercemarketplace-support.adobe.com/hc/en-us). +Customers are advised to contact you directly for support, using the information that you provide. For support issues related to Commerce Marketplace, see the [Help Center](https://marketplacesupport.magento.com/hc/en-us). 1. Under **Marketing Submission**, click **Support**. diff --git a/src/pages/guides/sellers/subscriptions/buying-subscriptions.md b/src/pages/guides/sellers/subscriptions/buying-subscriptions.md index 7f47f1b..a4cbd1e 100644 --- a/src/pages/guides/sellers/subscriptions/buying-subscriptions.md +++ b/src/pages/guides/sellers/subscriptions/buying-subscriptions.md @@ -66,4 +66,4 @@ You can request a refund within 25 days of the initial purchase payment. After t You can re-subscribe to a cancelled extension subscription once. If you decide to cancel the subscription for a second time, you will not be able to re-subscribe to that SKU. -Thank you for using the Adobe Commerce Marketplace. For all questions and suggestions regarding extension subscriptions, please contact [Marketplace Support](https://commercemarketplace-support.adobe.com) or find us in the [Community Slack workspace](https://developer.adobe.com/open/magento/slack). +Thank you for using the Adobe Commerce Marketplace. For all questions and suggestions regarding extension subscriptions, please contact [Marketplace Support](htthttps://marketplacesupport.magento.com/) or find us in the [Community Slack workspace](https://developer.adobe.com/open/magento/slack). diff --git a/src/pages/guides/sellers/subscriptions/extension-subscriptions.md b/src/pages/guides/sellers/subscriptions/extension-subscriptions.md index 5f933c1..1d44df2 100644 --- a/src/pages/guides/sellers/subscriptions/extension-subscriptions.md +++ b/src/pages/guides/sellers/subscriptions/extension-subscriptions.md @@ -20,4 +20,4 @@ To learn more about buying or selling subscription-licensed extensions, visit: - [Buying Subscription-based Extensions](../subscriptions/buying-subscriptions.md) - [Selling Subscription-based Extensions](../subscriptions/selling-subscriptions.md) -Thank you for using the Adobe Commerce Marketplace. For all questions and suggestions regarding extension subscriptions, please contact [Marketplace Support](https://commercemarketplace-support.adobe.com) or find us in the [Community Slack workspace](https://developer.adobe.com/open/magento/slack). +Thank you for using the Adobe Commerce Marketplace. For all questions and suggestions regarding extension subscriptions, please contact [Marketplace Support](https://marketplacesupport.magento.com/) or find us in the [Community Slack workspace](https://developer.adobe.com/open/magento/slack). diff --git a/src/pages/guides/sellers/subscriptions/selling-subscriptions.md b/src/pages/guides/sellers/subscriptions/selling-subscriptions.md index 64ce32a..95ad5ba 100644 --- a/src/pages/guides/sellers/subscriptions/selling-subscriptions.md +++ b/src/pages/guides/sellers/subscriptions/selling-subscriptions.md @@ -65,4 +65,4 @@ Customers can cancel their extension subscription at any time. Customers can only re-subscribe to a cancelled extension subscription once. Repeated cancellations and re-subscriptions to an extension are not supported. -Thank you for using the Adobe Commerce Marketplace. For all questions and suggestions regarding extension subscriptions, please contact [Marketplace Support](https://commercemarketplace-support.adobe.com) or find us in the [Community Slack workspace](https://developer.adobe.com/open/magento/slack). +Thank you for using the Adobe Commerce Marketplace. For all questions and suggestions regarding extension subscriptions, please contact [Marketplace Support](https://marketplacesupport.magento.com/) or find us in the [Community Slack workspace](https://developer.adobe.com/open/magento/slack). diff --git a/src/pages/index.md b/src/pages/index.md index 344bce1..072ded2 100644 --- a/src/pages/index.md +++ b/src/pages/index.md @@ -44,7 +44,7 @@ Provides programmatic access to the Commerce Developer Portal. -[Support](https://commercemarketplace-support.adobe.com/hc/en-us) +[Support](https://marketplacesupport.magento.com/hc/en-us) Search the Commerce Marketplace Help Center knowledge base or submit a support ticket. From 07037885fc6ae2319d311d902727e69debfecf03 Mon Sep 17 00:00:00 2001 From: Jeff Matthews Date: Wed, 22 Nov 2023 12:23:19 -0600 Subject: [PATCH 3/4] COMDOX-156: Fixed dead URL warnings --- src/pages/guides/sellers/submit-for-technical-review.md | 2 +- src/pages/guides/sellers/technical-review-guidelines.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/guides/sellers/submit-for-technical-review.md b/src/pages/guides/sellers/submit-for-technical-review.md index 8a9f8a4..5decad6 100644 --- a/src/pages/guides/sellers/submit-for-technical-review.md +++ b/src/pages/guides/sellers/submit-for-technical-review.md @@ -118,7 +118,7 @@ All products and services are subject to the same Commerce Marketplace terms and |Field|Description| |--- |--- | |Adobe Commerce Version Compatibility|Specifies each version of Commerce the listing supports.| -|License Type|Identifies the license type that defines the terms of use. To learn more, see the Open Source Initiative's Licenses by Name. Options:
**Custom License** - To use a custom license, enter the Name of the license and the License URL, where customers can read the terms of use.
**Academic Free License 3.0** - The [Academic Free License 3.0](https://opensource.org/licenses/AFL-3.0) (AFL) is an open source license that permits the free distribution and reuse of proprietary software and derivative works, provided that the source code is made available.
**Apache License 2.0** - The [Apache License](http://www.apache.org/licenses/LICENSE-2.0) 2.0 describes the terms of use, reproduction, and distribution of third-party software products that include portions of Apache software. It requires clear attribution to The Apache Software Foundation for any distributions that include Apache software.
**BSD 2-Clause License** - The [Berkeley Software Distribution 2-Clause License](https://opensource.org/licenses/BSD-2-Clause) requires the copyright notice to appear in all source code, but imposes minimal restrictions on the redistribution of open source software. The 2-clause license was derived from the original four-clause BSD license which requires a notice to appear in all advertising and prohibits the use of the contributor names in endorsements without prior written permission.
**GNU General Public License 3.0** - The [GNU General Public License 3.0](http://www.gnu.org/licenses/quick-guide-gplv3.html) (GLP-3.0) is widely used and based on the GNU open source license, and allows for the redistribution of software received from the copyright holder within the provisions outlined in the agreement. Any improved version of the software must be made available for free. To learn more, see [Frequently Asked Questions about GNU Licenses](https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility).
**GNU Lesser General Public License 3.0** - The [GNU Lesser General Public License 3.0](http://www.gnu.org/licenses/lgpl-3.0.en.html) (LGPL-3.0) is widely used and based on the GNU open source license. LGPL-3.0 is somewhat less restrictive than the standard GLP-3.0, and also requires that you provide installation instructions. To learn more, see [Frequently Asked Questions about GNU Licenses](https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility).
**MIT License** - The [Massachusetts Institute of Technology License](https://opensource.org/licenses/MIT) (MIT) allows for the reuse, modification, distribution, sub-licensing, and sale of proprietary software, provided that all copies include the MIT license and copyright notice.
**Mozilla Public License 1.1** - The [Mozilla Public License 1.1](https://www.mozilla.org/en-US/MPL/1.1)) (MPL-1.1) is an open source license that includes explicit patent rights and allows extensions of the code to be licensed in non-open ways. There is no requirement for a derivative work to be distributed under the same license.
**Open Software License 3.0** - The [Open Software License 3.0](https://opensource.org/licenses/OSL-3.0) (OSL-3.0) is a worldwide, royalty-free, non-exclusive license that allows sub-licensing and derivative work, provided that they are distributed under the same license.| +|License Type|Identifies the license type that defines the terms of use. To learn more, see the Open Source Initiative's Licenses by Name. Options:
**Custom License** - To use a custom license, enter the Name of the license and the License URL, where customers can read the terms of use.
**Academic Free License 3.0** - The [Academic Free License 3.0](https://opensource.org/license/afl-3-0-php/) (AFL) is an open source license that permits the free distribution and reuse of proprietary software and derivative works, provided that the source code is made available.
**Apache License 2.0** - The [Apache License](http://www.apache.org/licenses/LICENSE-2.0) 2.0 describes the terms of use, reproduction, and distribution of third-party software products that include portions of Apache software. It requires clear attribution to The Apache Software Foundation for any distributions that include Apache software.
**BSD 2-Clause License** - The [Berkeley Software Distribution 2-Clause License](https://opensource.org/license/bsd-2-clause/) requires the copyright notice to appear in all source code, but imposes minimal restrictions on the redistribution of open source software. The 2-clause license was derived from the original four-clause BSD license which requires a notice to appear in all advertising and prohibits the use of the contributor names in endorsements without prior written permission.
**GNU General Public License 3.0** - The [GNU General Public License 3.0](http://www.gnu.org/licenses/quick-guide-gplv3.html) (GLP-3.0) is widely used and based on the GNU open source license, and allows for the redistribution of software received from the copyright holder within the provisions outlined in the agreement. Any improved version of the software must be made available for free. To learn more, see [Frequently Asked Questions about GNU Licenses](https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility).
**GNU Lesser General Public License 3.0** - The [GNU Lesser General Public License 3.0](http://www.gnu.org/licenses/lgpl-3.0.en.html) (LGPL-3.0) is widely used and based on the GNU open source license. LGPL-3.0 is somewhat less restrictive than the standard GLP-3.0, and also requires that you provide installation instructions. To learn more, see [Frequently Asked Questions about GNU Licenses](https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility).
**MIT License** - The [Massachusetts Institute of Technology License](https://opensource.org/license/mit/) (MIT) allows for the reuse, modification, distribution, sub-licensing, and sale of proprietary software, provided that all copies include the MIT license and copyright notice.
**Mozilla Public License 1.1** - The [Mozilla Public License 1.1](https://www.mozilla.org/en-US/MPL/1.1)) (MPL-1.1) is an open source license that includes explicit patent rights and allows extensions of the code to be licensed in non-open ways. There is no requirement for a derivative work to be distributed under the same license.
**Open Software License 3.0** - The [Open Software License 3.0](https://opensource.org/license/osl-3-0-php/) (OSL-3.0) is a worldwide, royalty-free, non-exclusive license that allows sub-licensing and derivative work, provided that they are distributed under the same license.| |Documents|Upload your customer-facing documentation in PDF format. The user guide is required, and you can optionally include a reference manual and installation guide. Maximum file size: 5 MB File type: PDF
**User Guide** - Your extension or app must include one user guide.
**Reference Manual** - (Optional)
**Installation Guide** - (Optional)
**_Note:_** Although the installation guide is optional, it might be required by some license types.| |Release Notes|The preliminary Release Notes text can include simple HTML, without CSS. Maximum characters: 10,000| |[Shared Packages](shared-packages.md)|If applicable, identifies each shared package that is required by this extension.| diff --git a/src/pages/guides/sellers/technical-review-guidelines.md b/src/pages/guides/sellers/technical-review-guidelines.md index 5d2cb48..2d46c26 100644 --- a/src/pages/guides/sellers/technical-review-guidelines.md +++ b/src/pages/guides/sellers/technical-review-guidelines.md @@ -87,7 +87,7 @@ _See also:_ [Coding Standards](https://developer.adobe.com/commerce/php/coding-s All code and marketing content that is submitted to Commerce Marketplace is checked for plagiarism to ensure that it has not been copied from existing Marketplace extensions or from the Commerce codebase. -If the extension contains source code from the Open Source Edition, the extension must be licensed under [Open Source License v. 3.0](https://opensource.org/licenses/OSL-3.0) and properly credit Adobe, Inc. +If the extension contains source code from the Open Source Edition, the extension must be licensed under [Open Source License v. 3.0](https://opensource.org/license/osl-3-0-php/) and properly credit Adobe, Inc. _More details:_ [Copy Paste Detector](copy-paste-detector.md) From 6f99dd0b7e76a1d5962604925bb0c42f235009cb Mon Sep 17 00:00:00 2001 From: Jeff Matthews Date: Wed, 22 Nov 2023 12:28:29 -0600 Subject: [PATCH 4/4] COMDOX-156: Exclude domain causing false positive link warnings --- .remarkrc.mjs | 1 + 1 file changed, 1 insertion(+) diff --git a/.remarkrc.mjs b/.remarkrc.mjs index f9a33b4..ffee128 100644 --- a/.remarkrc.mjs +++ b/.remarkrc.mjs @@ -24,6 +24,7 @@ const remarkConfig = { { skipUrlPatterns: [ "https://marketplacesupport.magento.com", + "https://opensource.org/", "https://www.php.net" ] }