Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AEM UI Extensibility] CFC Custom Grid Columns sorting #43

Open
1 task done
davidjgonzalez opened this issue Jun 7, 2023 · 3 comments
Open
1 task done

[AEM UI Extensibility] CFC Custom Grid Columns sorting #43

davidjgonzalez opened this issue Jun 7, 2023 · 3 comments
Assignees

Comments

@davidjgonzalez
Copy link
Contributor

davidjgonzalez commented Jun 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Which topic?

https://developer.adobe.com/uix/docs/services/aem-cf-console-admin/api/grid-columns/

What's wrong with the content?

2023-06-07 at 12 30 PM

Setting sortable: true does not appear to make a column sortable (there is no sort direction icon next to the label, nor does clicking the column label do anything). I think this should actually be a function hook that acts as a comparator - for example, I have an "Age" custom column, with values likes "9 seconds" and "1 year" ... i assume if this works, it would do a string compare and think "9 seconds" is > "1 year" -- even though its not.

Following suit, defaultSortOrder does not seem to do anything. Assuming this should work, it would be good to clarify what this actually does. Does it cause the gird to sort the values in the specified for this column on initial load? What id 2 columns are specified with this? Which one sorts first, and which one is the "tie breaker" (2nd sort).

Also, the description of this field is in the wrong column in the docs table - it should be in the "description" col rather than "required" col

What changes do you propose?

No response

Anything else that can help to cover this?

No response

@naydav
Copy link
Contributor

naydav commented Jun 9, 2023

Hi @davidjgonzalez ,

Thank you very much for your feedback. The issue with column sorting is a known issue, but you have provided some additional aspects. We will start working on addressing the task next week.

Thank you.

@naydav
Copy link
Contributor

naydav commented Jun 9, 2023

Realted PR: #42

@naydav naydav self-assigned this Jun 9, 2023
@naydav
Copy link
Contributor

naydav commented Jun 15, 2023

The #42 has been merged.
But I didn't close ticket because a fix requires additional work (in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants