Skip to content

Test Geojson file fields #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 4, 2024
Merged

Test Geojson file fields #107

merged 15 commits into from
Dec 4, 2024

Conversation

Antsalacia
Copy link
Collaborator

Add test in earthspy.py to test the field name and the coordinates

@wehrad
Copy link
Owner

wehrad commented Nov 29, 2024

Thanks for working on this @Antsalacia! :)
Can you try and revert earthspy.py to its main version? So that only the changes to test_earthspy.py appear here. You can check how to do it here: https://stackoverflow.com/questions/1817766/how-to-revert-to-origins-master-branchs-version-of-file

@wehrad wehrad added the enhancement New feature or request label Nov 29, 2024
@wehrad
Copy link
Owner

wehrad commented Nov 29, 2024

Next we'd need a test checking that the last coordinate is the same as the first one (as this is needed for a polygon).

@wehrad
Copy link
Owner

wehrad commented Dec 2, 2024

I just resolved the conflicts, we're almost good to go! :)

@wehrad
Copy link
Owner

wehrad commented Dec 2, 2024

There's still a couple of pre-commit issues to fix, but most of them will be fixed if you push the code once it has been formatted by black, that is, right after you ran pre-commit.

@wehrad wehrad changed the title Add test for the Geojson Test Geojson file fields Dec 2, 2024
@wehrad
Copy link
Owner

wehrad commented Dec 2, 2024

closes #34

@wehrad wehrad merged commit b7db112 into wehrad:main Dec 4, 2024
4 of 7 checks passed
@Antsalacia Antsalacia deleted the fix/json branch December 5, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants