[Control Plane] Extract shared ErrorResponse helper

[santoshkumarradha]

Summary

Multiple handler files define similar ErrorResponse structs and error handling patterns. Extract these to a shared location to reduce duplication.

Current State

• Issue: ErrorResponse struct and similar error patterns repeated across 10+ handler files
• Example location: control-plane/internal/handlers/memory.go (lines 52-57)

Current Pattern (Duplicated)

// Found in multiple files:
type ErrorResponse struct {
    Error string \`json:"error"\`
}

// Error response code duplicated:
c.JSON(http.StatusBadRequest, ErrorResponse{Error: "invalid request"})

Proposed Solution

Create a shared error utilities file:

// control-plane/internal/handlers/errors.go

package handlers

// ErrorResponse is the standard error response format.
type ErrorResponse struct {
    Error   string \`json:"error"\`
    Code    string \`json:"code,omitempty"\`
    Details string \`json:"details,omitempty"\`
}

// RespondError sends a JSON error response with the given status code.
func RespondError(c *gin.Context, status int, message string) {
    c.JSON(status, ErrorResponse{Error: message})
}

// RespondBadRequest sends a 400 Bad Request error response.
func RespondBadRequest(c *gin.Context, message string) {
    RespondError(c, http.StatusBadRequest, message)
}

// RespondNotFound sends a 404 Not Found error response.
func RespondNotFound(c *gin.Context, message string) {
    RespondError(c, http.StatusNotFound, message)
}

// RespondInternalError sends a 500 Internal Server Error response.
func RespondInternalError(c *gin.Context, message string) {
    RespondError(c, http.StatusInternalServerError, message)
}

Tasks

1. Create control-plane/internal/handlers/errors.go with shared types/functions
2. Update existing handlers to use shared error utilities
3. Remove duplicate ErrorResponse definitions

Acceptance Criteria

• Shared error file created
• At least 3 handler files updated to use shared utilities
• No duplicate ErrorResponse struct definitions remain
• All tests pass
• Code compiles without errors

Files

• control-plane/internal/handlers/errors.go (new)
• Multiple handler files to update

---

Using AI to solve this issue? Read our AI-Assisted Contributions guide for testing requirements, prompt strategies, and common pitfalls to avoid.

[Varshith2403315]

Hi! I'd like to work on this issue if it's still available.

I noticed commit d27e892 referencing this issue. Is the refactor already completed there, or is additional work still needed across other handler files?

Happy to continue the refactor if it's still open.

[santoshkumarradha]

Hey @Varshith2403315, thanks for your interest! The issue is still open and no work has been done on it yet. That commit doesn't seem to exist in our repo, so you're good to start fresh. Feel free to pick this up! Just a heads up, the scope is a bit bigger than described. There are about 33 handler files with inconsistent error patterns (some use ErrorResponse struct, others use gin.H), so there's plenty to consolidate. Happy to review your PR when it's ready!

[github-actions]

Thanks for picking this up, @Varshith2403315! 🎉

Here's what to expect:

• We'll check in after 7 days if we haven't heard an update
• After 14 days, we'll send a second reminder
• After 21 days without activity, we'll unassign to let others contribute

Tips for success:

• Drop a comment when you start working on it
• Share any blockers - we're here to help!
• Link your PR with Fixes #119 in the description

Happy coding! 🚀

[Varshith2403315]

Thanks for assigning this!
I'll start by auditing the control-plane handlers to identify the existing error response patterns (ErrorResponse structs, gin.H, etc.) and then introduce the shared helper in handlers/errors.go.

After that I'll refactor the handlers to use the common utilities and remove the duplicated error response definitions.