From b388de56500274aded7a43365fcdd856db0eb257 Mon Sep 17 00:00:00 2001 From: Mahmoud Gaber Date: Wed, 8 May 2024 23:48:13 +0300 Subject: [PATCH 1/3] test: Add testing for the update requests --- .../workup/users/UsersApplicationTests.java | 90 +++++++++++++++++++ 1 file changed, 90 insertions(+) diff --git a/services/users/src/test/java/com/workup/users/UsersApplicationTests.java b/services/users/src/test/java/com/workup/users/UsersApplicationTests.java index 47263e14..71ccf10c 100644 --- a/services/users/src/test/java/com/workup/users/UsersApplicationTests.java +++ b/services/users/src/test/java/com/workup/users/UsersApplicationTests.java @@ -324,4 +324,94 @@ void testGetFreelancerLanguages() { Assertions.assertEquals(languages.size(), 1); Assertions.assertEquals(language, languages.getFirst()); } + + @Test + void testUpdateAchievement() { + Freelancer freelancer = freelancerRepository.save(UsersTestUtils.createTestFreelancer()); + Achievement achievement = achievementRepository.save(UsersTestUtils.createTestAchievement()); + freelancer.getAchievements().add(achievement); + freelancerRepository.save(freelancer); + String updatedName = "New Achievement Name"; + String updatedAwardedBy = "New Awarded By"; + UpdateFreelancerAchievementRequest request = + UpdateFreelancerAchievementRequest.builder() + .withFreelancer_id(freelancer.getId().toString()) + .withAchievement_id(achievement.getId().toString()) + .withNew_achievement_name(updatedName) + .withNew_awarded_by(updatedAwardedBy) + .build(); + UpdateFreelancerAchievementResponse response = + (UpdateFreelancerAchievementResponse) + template.convertSendAndReceive(ServiceQueueNames.USERS, request); + Achievement expectedAchievement = UsersTestUtils.createTestAchievement(); + expectedAchievement.setAchievement_name(updatedName); + expectedAchievement.setAwarded_by(updatedAwardedBy); + expectedAchievement.setAward_date(achievement.getAward_date()); + Assertions.assertNotNull(response); + Assertions.assertEquals(HttpStatusCode.OK, response.getStatusCode()); + freelancer = freelancerRepository.findById(freelancer.getId().toString()).get(); + Achievement updatedAchievement = freelancer.getAchievements().get(0); + UsersTestUtils.assertAchievementEquals(expectedAchievement, updatedAchievement); + } + + @Test + void testUpdateEducation() { + Freelancer freelancer = freelancerRepository.save(UsersTestUtils.createTestFreelancer()); + Education education = educationRepository.save(UsersTestUtils.createTestEducation()); + freelancer.getEducations().add(education); + freelancerRepository.save(freelancer); + + String updatedSchoolName = "New School Name"; + String updatedDegree = "New Degree"; + UpdateFreelancerEducationRequest request = + UpdateFreelancerEducationRequest.builder() + .withFreelancer_id(freelancer.getId().toString()) + .withEducation_id(education.getId().toString()) + .withNew_school_name(updatedSchoolName) + .withNew_degree(updatedDegree) + .build(); + UpdateFreelancerEducationResponse response = + (UpdateFreelancerEducationResponse) + template.convertSendAndReceive(ServiceQueueNames.USERS, request); + Education expectedEducation = UsersTestUtils.createTestEducation(); + expectedEducation.setSchool_name(updatedSchoolName); + expectedEducation.setDegree(updatedDegree); + expectedEducation.setEducation_start_date(education.getEducation_start_date()); + expectedEducation.setEnd_date(education.getEnd_date()); + Assertions.assertNotNull(response); + Assertions.assertEquals(HttpStatusCode.OK, response.getStatusCode()); + freelancer = freelancerRepository.findById(freelancer.getId().toString()).get(); + Education updatedEducation = freelancer.getEducations().get(0); + UsersTestUtils.assertEducationEquals(expectedEducation, updatedEducation); + } + + @Test + void testUpdateExperience() { + Freelancer freelancer = freelancerRepository.save(UsersTestUtils.createTestFreelancer()); + Experience experience = experienceRepository.save(UsersTestUtils.createTestExperience()); + freelancer.getExperiences().add(experience); + freelancerRepository.save(freelancer); + String updatedCompanyName = "New Company Name"; + String updatedJobTitle = "New Job Title"; + UpdateFreelancerExperienceRequest request = + UpdateFreelancerExperienceRequest.builder() + .withFreelancer_id(freelancer.getId().toString()) + .withExperience_id(experience.getId().toString()) + .withNew_company_name(updatedCompanyName) + .withNew_job_title(updatedJobTitle) + .build(); + UpdateFreelancerExperienceResponse response = + (UpdateFreelancerExperienceResponse) + template.convertSendAndReceive(ServiceQueueNames.USERS, request); + Assertions.assertNotNull(response); + Assertions.assertEquals(HttpStatusCode.OK, response.getStatusCode()); + Experience expectedExperience = UsersTestUtils.createTestExperience(); + expectedExperience.setCompany_name(updatedCompanyName); + expectedExperience.setJob_title(updatedJobTitle); + expectedExperience.setEmployment_start(experience.getEmployment_start()); + expectedExperience.setEmployment_end(experience.getEmployment_end()); + freelancer = freelancerRepository.findById(freelancer.getId().toString()).get(); + Experience updatedExperience = freelancer.getExperiences().get(0); + UsersTestUtils.assertExperienceEquals(expectedExperience, updatedExperience); + } } From ee31ec6e31d0c34f04661b48a60d83e0ebcf51b8 Mon Sep 17 00:00:00 2001 From: Mahmoud Gaber Date: Wed, 8 May 2024 23:56:40 +0300 Subject: [PATCH 2/3] fix: Change the update commands to use userId instead of freelancer_id --- .../users/commands/UpdateFreelancerAchievementCommand.java | 3 +-- .../users/commands/UpdateFreelancerEducationCommand.java | 3 +-- .../users/commands/UpdateFreelancerExperienceCommand.java | 3 +-- .../test/java/com/workup/users/UsersApplicationTests.java | 6 +++--- .../users/requests/UpdateFreelancerAchievementRequest.java | 1 - .../users/requests/UpdateFreelancerEducationRequest.java | 1 - .../users/requests/UpdateFreelancerExperienceRequest.java | 1 - 7 files changed, 6 insertions(+), 12 deletions(-) diff --git a/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerAchievementCommand.java b/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerAchievementCommand.java index c21da6c8..f94005e0 100644 --- a/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerAchievementCommand.java +++ b/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerAchievementCommand.java @@ -11,8 +11,7 @@ public class UpdateFreelancerAchievementCommand extends UserCommand { @Override public UpdateFreelancerAchievementResponse Run(UpdateFreelancerAchievementRequest request) { - Optional freelancerOptional = - freelancerRepository.findById(request.getFreelancer_id()); + Optional freelancerOptional = freelancerRepository.findById(request.getUserId()); if (freelancerOptional.isEmpty()) return UpdateFreelancerAchievementResponse.builder() .withStatusCode(HttpStatusCode.NOT_FOUND) diff --git a/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerEducationCommand.java b/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerEducationCommand.java index 03beaf0f..97aaaae1 100644 --- a/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerEducationCommand.java +++ b/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerEducationCommand.java @@ -12,8 +12,7 @@ public class UpdateFreelancerEducationCommand @Override public UpdateFreelancerEducationResponse Run(UpdateFreelancerEducationRequest request) { - Optional freelancerOptional = - freelancerRepository.findById(request.getFreelancer_id()); + Optional freelancerOptional = freelancerRepository.findById(request.getUserId()); if (freelancerOptional.isEmpty()) return UpdateFreelancerEducationResponse.builder() .withStatusCode(HttpStatusCode.NOT_FOUND) diff --git a/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerExperienceCommand.java b/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerExperienceCommand.java index e0bf47fb..95a6ac8a 100644 --- a/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerExperienceCommand.java +++ b/services/users/src/main/java/com/workup/users/commands/UpdateFreelancerExperienceCommand.java @@ -11,8 +11,7 @@ public class UpdateFreelancerExperienceCommand extends UserCommand { @Override public UpdateFreelancerExperienceResponse Run(UpdateFreelancerExperienceRequest request) { - Optional freelancerOptional = - freelancerRepository.findById(request.getFreelancer_id()); + Optional freelancerOptional = freelancerRepository.findById(request.getUserId()); if (freelancerOptional.isEmpty()) return UpdateFreelancerExperienceResponse.builder() .withStatusCode(HttpStatusCode.NOT_FOUND) diff --git a/services/users/src/test/java/com/workup/users/UsersApplicationTests.java b/services/users/src/test/java/com/workup/users/UsersApplicationTests.java index 71ccf10c..a566a65b 100644 --- a/services/users/src/test/java/com/workup/users/UsersApplicationTests.java +++ b/services/users/src/test/java/com/workup/users/UsersApplicationTests.java @@ -335,7 +335,7 @@ void testUpdateAchievement() { String updatedAwardedBy = "New Awarded By"; UpdateFreelancerAchievementRequest request = UpdateFreelancerAchievementRequest.builder() - .withFreelancer_id(freelancer.getId().toString()) + .withUserId(freelancer.getId().toString()) .withAchievement_id(achievement.getId().toString()) .withNew_achievement_name(updatedName) .withNew_awarded_by(updatedAwardedBy) @@ -365,7 +365,7 @@ void testUpdateEducation() { String updatedDegree = "New Degree"; UpdateFreelancerEducationRequest request = UpdateFreelancerEducationRequest.builder() - .withFreelancer_id(freelancer.getId().toString()) + .withUserId(freelancer.getId().toString()) .withEducation_id(education.getId().toString()) .withNew_school_name(updatedSchoolName) .withNew_degree(updatedDegree) @@ -395,7 +395,7 @@ void testUpdateExperience() { String updatedJobTitle = "New Job Title"; UpdateFreelancerExperienceRequest request = UpdateFreelancerExperienceRequest.builder() - .withFreelancer_id(freelancer.getId().toString()) + .withUserId(freelancer.getId().toString()) .withExperience_id(experience.getId().toString()) .withNew_company_name(updatedCompanyName) .withNew_job_title(updatedJobTitle) diff --git a/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerAchievementRequest.java b/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerAchievementRequest.java index e31a4447..24522ef3 100644 --- a/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerAchievementRequest.java +++ b/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerAchievementRequest.java @@ -10,7 +10,6 @@ @SuperBuilder(setterPrefix = "with") @Jacksonized public class UpdateFreelancerAchievementRequest extends CommandRequest { - String freelancer_id; String achievement_id; String new_achievement_name; String new_awarded_by; diff --git a/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerEducationRequest.java b/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerEducationRequest.java index 3140bf08..2423467e 100644 --- a/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerEducationRequest.java +++ b/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerEducationRequest.java @@ -10,7 +10,6 @@ @SuperBuilder(setterPrefix = "with") @Jacksonized public class UpdateFreelancerEducationRequest extends CommandRequest { - String freelancer_id; String education_id; String new_school_name; String new_degree; diff --git a/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerExperienceRequest.java b/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerExperienceRequest.java index a19f5862..89d5ac1a 100644 --- a/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerExperienceRequest.java +++ b/shared/src/main/java/com/workup/shared/commands/users/requests/UpdateFreelancerExperienceRequest.java @@ -10,7 +10,6 @@ @SuperBuilder(setterPrefix = "with") @Jacksonized public class UpdateFreelancerExperienceRequest extends CommandRequest { - String freelancer_id; String experience_id; String new_company_name; String new_job_title; From b78098a46c66e0a34eb6b02913b05e755d2fb1e5 Mon Sep 17 00:00:00 2001 From: Mahmoud Gaber Date: Thu, 9 May 2024 00:08:18 +0300 Subject: [PATCH 3/3] test: Add tests for delete operations Add tests for delete operations and change the commands to use userId instead of freelancer_id --- .../RemoveFreelancerAchievementCommand.java | 3 +- .../RemoveFreelancerEducationCommand.java | 3 +- .../RemoveFreelancerExperienceCommand.java | 3 +- .../RemoveFreelancerLanguageCommand.java | 2 +- .../RemoveFreelancerSkillCommand.java | 2 +- .../workup/users/UsersApplicationTests.java | 110 ++++++++++++++++++ .../RemoveFreelancerAchievementRequest.java | 1 - .../RemoveFreelancerEducationRequest.java | 1 - .../RemoveFreelancerExperienceRequest.java | 1 - .../RemoveFreelancerLanguageRequest.java | 1 - .../RemoveFreelancerSkillRequest.java | 1 - 11 files changed, 115 insertions(+), 13 deletions(-) diff --git a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerAchievementCommand.java b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerAchievementCommand.java index 14fdec63..1500f06f 100644 --- a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerAchievementCommand.java +++ b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerAchievementCommand.java @@ -11,8 +11,7 @@ public class RemoveFreelancerAchievementCommand extends UserCommand { @Override public RemoveFreelancerAchievementResponse Run(RemoveFreelancerAchievementRequest request) { - Optional freelancerOptional = - freelancerRepository.findById(request.getFreelancerId()); + Optional freelancerOptional = freelancerRepository.findById(request.getUserId()); if (freelancerOptional.isEmpty()) return RemoveFreelancerAchievementResponse.builder() .withStatusCode(HttpStatusCode.NOT_FOUND) diff --git a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerEducationCommand.java b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerEducationCommand.java index e2f4d8eb..b7740bfc 100644 --- a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerEducationCommand.java +++ b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerEducationCommand.java @@ -12,8 +12,7 @@ public class RemoveFreelancerEducationCommand @Override public RemoveFreelancerEducationResponse Run(RemoveFreelancerEducationRequest request) { - Optional freelancerOptional = - freelancerRepository.findById(request.getFreelancer_id()); + Optional freelancerOptional = freelancerRepository.findById(request.getUserId()); if (freelancerOptional.isEmpty()) return RemoveFreelancerEducationResponse.builder() .withStatusCode(HttpStatusCode.NOT_FOUND) diff --git a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerExperienceCommand.java b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerExperienceCommand.java index 665ca054..c34467b0 100644 --- a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerExperienceCommand.java +++ b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerExperienceCommand.java @@ -11,8 +11,7 @@ public class RemoveFreelancerExperienceCommand extends UserCommand { @Override public RemoveFreelancerExperienceResponse Run(RemoveFreelancerExperienceRequest request) { - Optional freelancerOptional = - freelancerRepository.findById(request.getFreelancer_id()); + Optional freelancerOptional = freelancerRepository.findById(request.getUserId()); if (freelancerOptional.isEmpty()) return RemoveFreelancerExperienceResponse.builder() .withStatusCode(HttpStatusCode.NOT_FOUND) diff --git a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerLanguageCommand.java b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerLanguageCommand.java index 31acbee3..35d7b5ef 100644 --- a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerLanguageCommand.java +++ b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerLanguageCommand.java @@ -10,7 +10,7 @@ public class RemoveFreelancerLanguageCommand extends UserCommand { @Override public RemoveFreelancerLanguageResponse Run(RemoveFreelancerLanguageRequest request) { - Optional freelancerOptional = freelancerRepository.findById(request.getUser_id()); + Optional freelancerOptional = freelancerRepository.findById(request.getUserId()); if (freelancerOptional.isEmpty()) return RemoveFreelancerLanguageResponse.builder() .withStatusCode(HttpStatusCode.NOT_FOUND) diff --git a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerSkillCommand.java b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerSkillCommand.java index 2dd93979..4fee235d 100644 --- a/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerSkillCommand.java +++ b/services/users/src/main/java/com/workup/users/commands/RemoveFreelancerSkillCommand.java @@ -10,7 +10,7 @@ public class RemoveFreelancerSkillCommand extends UserCommand { @Override public RemoveFreelancerSkillResponse Run(RemoveFreelancerSkillRequest request) { - Optional freelancerOptional = freelancerRepository.findById(request.getUser_id()); + Optional freelancerOptional = freelancerRepository.findById(request.getUserId()); if (freelancerOptional.isEmpty()) return RemoveFreelancerSkillResponse.builder() .withStatusCode(HttpStatusCode.NOT_FOUND) diff --git a/services/users/src/test/java/com/workup/users/UsersApplicationTests.java b/services/users/src/test/java/com/workup/users/UsersApplicationTests.java index a566a65b..f87a82be 100644 --- a/services/users/src/test/java/com/workup/users/UsersApplicationTests.java +++ b/services/users/src/test/java/com/workup/users/UsersApplicationTests.java @@ -414,4 +414,114 @@ void testUpdateExperience() { Experience updatedExperience = freelancer.getExperiences().get(0); UsersTestUtils.assertExperienceEquals(expectedExperience, updatedExperience); } + + @Test + void testRemoveAchievement() { + Freelancer freelancer = freelancerRepository.save(UsersTestUtils.createTestFreelancer()); + Achievement achievement = achievementRepository.save(UsersTestUtils.createTestAchievement()); + freelancer.getAchievements().add(achievement); + freelancerRepository.save(freelancer); + + RemoveFreelancerAchievementRequest request = + RemoveFreelancerAchievementRequest.builder() + .withUserId(freelancer.getId().toString()) + .withAchievementId(achievement.getId().toString()) + .build(); + RemoveFreelancerAchievementResponse response = + (RemoveFreelancerAchievementResponse) + template.convertSendAndReceive(ServiceQueueNames.USERS, request); + + Assertions.assertNotNull(response); + Assertions.assertEquals(HttpStatusCode.OK, response.getStatusCode()); + freelancer = freelancerRepository.findById(freelancer.getId().toString()).get(); + Assertions.assertTrue(freelancer.getAchievements().isEmpty()); + } + + @Test + void testRemoveEducation() { + Freelancer freelancer = freelancerRepository.save(UsersTestUtils.createTestFreelancer()); + Education education = educationRepository.save(UsersTestUtils.createTestEducation()); + freelancer.getEducations().add(education); + freelancerRepository.save(freelancer); + + RemoveFreelancerEducationRequest request = + RemoveFreelancerEducationRequest.builder() + .withUserId(freelancer.getId().toString()) + .withEducation_id(education.getId().toString()) + .build(); + RemoveFreelancerEducationResponse response = + (RemoveFreelancerEducationResponse) + template.convertSendAndReceive(ServiceQueueNames.USERS, request); + + Assertions.assertNotNull(response); + Assertions.assertEquals(HttpStatusCode.OK, response.getStatusCode()); + freelancer = freelancerRepository.findById(freelancer.getId().toString()).get(); + Assertions.assertTrue(freelancer.getEducations().isEmpty()); + } + + @Test + void testRemoveExperience() { + Freelancer freelancer = freelancerRepository.save(UsersTestUtils.createTestFreelancer()); + Experience experience = experienceRepository.save(UsersTestUtils.createTestExperience()); + freelancer.getExperiences().add(experience); + freelancerRepository.save(freelancer); + + RemoveFreelancerExperienceRequest request = + RemoveFreelancerExperienceRequest.builder() + .withUserId(freelancer.getId().toString()) + .withExperience_id(experience.getId().toString()) + .build(); + RemoveFreelancerExperienceResponse response = + (RemoveFreelancerExperienceResponse) + template.convertSendAndReceive(ServiceQueueNames.USERS, request); + + Assertions.assertNotNull(response); + Assertions.assertEquals(HttpStatusCode.OK, response.getStatusCode()); + freelancer = freelancerRepository.findById(freelancer.getId().toString()).get(); + Assertions.assertTrue(freelancer.getExperiences().isEmpty()); + } + + @Test + void testRemoveSkill() { + Freelancer freelancer = freelancerRepository.save(UsersTestUtils.createTestFreelancer()); + String skill = "Java"; + freelancer.getSkills().add(skill); + freelancerRepository.save(freelancer); + + RemoveFreelancerSkillRequest request = + RemoveFreelancerSkillRequest.builder() + .withUserId(freelancer.getId().toString()) + .withSkillToRemove(skill) + .build(); + RemoveFreelancerSkillResponse response = + (RemoveFreelancerSkillResponse) + template.convertSendAndReceive(ServiceQueueNames.USERS, request); + + Assertions.assertNotNull(response); + Assertions.assertEquals(HttpStatusCode.OK, response.getStatusCode()); + freelancer = freelancerRepository.findById(freelancer.getId().toString()).get(); + Assertions.assertTrue(freelancer.getSkills().isEmpty()); + } + + @Test + void testRemoveLanguage() { + Freelancer freelancer = freelancerRepository.save(UsersTestUtils.createTestFreelancer()); + String language = "English"; + freelancer.getLanguages().add(language); + freelancerRepository.save(freelancer); + + RemoveFreelancerLanguageRequest request = + RemoveFreelancerLanguageRequest.builder() + .withUserId(freelancer.getId().toString()) + .withLanguageToRemove(language) + .build(); + RemoveFreelancerLanguageResponse response = + (RemoveFreelancerLanguageResponse) + template.convertSendAndReceive(ServiceQueueNames.USERS, request); + + Assertions.assertNotNull(response); + Assertions.assertEquals(HttpStatusCode.OK, response.getStatusCode()); + freelancer = freelancerRepository.findById(freelancer.getId().toString()).get(); + Assertions.assertTrue(freelancer.getLanguages().isEmpty()); + } } diff --git a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerAchievementRequest.java b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerAchievementRequest.java index 266cca34..aa323fa8 100644 --- a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerAchievementRequest.java +++ b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerAchievementRequest.java @@ -9,6 +9,5 @@ @SuperBuilder(setterPrefix = "with") @Jacksonized public class RemoveFreelancerAchievementRequest extends CommandRequest { - String freelancerId; String achievementId; } diff --git a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerEducationRequest.java b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerEducationRequest.java index 1c68fa73..ba87db1d 100644 --- a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerEducationRequest.java +++ b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerEducationRequest.java @@ -9,6 +9,5 @@ @SuperBuilder(setterPrefix = "with") @Jacksonized public class RemoveFreelancerEducationRequest extends CommandRequest { - String freelancer_id; String education_id; } diff --git a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerExperienceRequest.java b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerExperienceRequest.java index 1e82f5eb..030148b1 100644 --- a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerExperienceRequest.java +++ b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerExperienceRequest.java @@ -9,6 +9,5 @@ @SuperBuilder(setterPrefix = "with") @Jacksonized public class RemoveFreelancerExperienceRequest extends CommandRequest { - String freelancer_id; String experience_id; } diff --git a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerLanguageRequest.java b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerLanguageRequest.java index a2537640..16413734 100644 --- a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerLanguageRequest.java +++ b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerLanguageRequest.java @@ -9,6 +9,5 @@ @SuperBuilder(setterPrefix = "with") @Jacksonized public class RemoveFreelancerLanguageRequest extends CommandRequest { - private String user_id; private String languageToRemove; } diff --git a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerSkillRequest.java b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerSkillRequest.java index 3f1cfece..c5c6f53a 100644 --- a/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerSkillRequest.java +++ b/shared/src/main/java/com/workup/shared/commands/users/requests/RemoveFreelancerSkillRequest.java @@ -9,6 +9,5 @@ @SuperBuilder(setterPrefix = "with") @Jacksonized public class RemoveFreelancerSkillRequest extends CommandRequest { - String user_id; String skillToRemove; }