Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Update run_dynamics_fast to use C++ MEX API instead of C API with mxArray #13

Open
aweinert-MIT opened this issue Mar 11, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aweinert-MIT
Copy link
Member

aweinert-MIT commented Mar 11, 2022

Relation

The MATLAB mex function, run_dynamics_fast is used by multiple repositories, including em-model-manned-bayes to simulate aircraft trajectories with a 6DOF physics model.

The code currently uses the MATLAB C Matrix API which works with the mxArray data structure.

Description

Update the software to use the more modern C++ MEX API. If appropriate, casts should be updated to modern C++ style as well, per the Google C++ Style Guide on casting.

Alternatives

The original source for run_dynamics_fast can be traced back to over a decade ago and the code does not take advantage of modern C++ features to improve robustness, efficiency, and ease of use. For long term substantiality of the code, an upgrade to the C++ MEX API is recommended.

Additional

Issues #12 , #11 , #10 also address run_dynamics_fast but these other issues are expected to require significantly less resources to complete than this task focused on the C++ MEX API.

While the contributing guidelines does not define a style guide for C++, we currently recommend the Google C++ Style Guide for this issue.

@aweinert-MIT aweinert-MIT added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant