Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple feature requests #244

Open
Ranksu10 opened this issue Jan 10, 2025 · 4 comments
Open

Multiple feature requests #244

Ranksu10 opened this issue Jan 10, 2025 · 4 comments

Comments

@Ranksu10
Copy link

Ranksu10 commented Jan 10, 2025

  1. Add a /party toggle command along with a placeholder, e.g., %parties_toggle%, that returns true/false.
    If enabled, the player will not receive party invites, and others attempting to send an invite will see an error message, such as:
    player-invite-toggle: "&cThis player has party invite requests disabled!"

  2. Add a sound notification when a player receives a new party invite.
    This feature should be customizable in the config (enable: true/false) the sound and adjust its volume and pitch.

  3. Expand message customization for command syntax.
    Currently, customization seems limited to the "wrong-message" message. It would be helpful to allow customization of the syntax for all command-related messages. i.e:

wrong-message: '&cWrong syntax: Type &7/%syntax%'

invite-syntax: '/%command% %sub_command% <player>'
delete-syntax: '/%command% %sub_command% <party> [silent]'
and so on...

%command% and %subcommand% should refer to the config.yml:

main-commands:
    party:
      command: 'party'
      description: 'Parties help page'
      aliases: []
    p:
      command: 'p'
      description: 'Send a party message'
      aliases: []
  sub-commands:
    help: 'help'
    accept: 'accept'
    ask: 'ask'
    chat: 'chat'
    ...
  misc-commands:
    bungeecord: 'bungeecord'
    config: 'config'
    ...

As for the misc-commands, it's up to you if you want to add them as well.

  1. Add a placeholder that checks if a player is or not in a party. i.e: %parties_in_a_party% that returns true/false

I feel these feature requests could improve even more the quality and customization of this plugin, I hope you take these in consideration!

Best regards,
Ranksu

@Ranksu10 Ranksu10 changed the title Suggestion: add a party toggle command and sound on invite Multiple feature requests Jan 10, 2025
@AlessioDP
Copy link
Owner

Thank you for the ideas :)

You can already do some of them:

  1. You can already mute some messages, with /party ignore (party specific) or /party mute, there isn't a placeholder that you can check. The toggle command can be used to publicly alert other players that you do not want/can receive messages.
  2. The syntax is dynamically handled by the plugin depending on what settings are enabled, that is the reason behind the missing message, its possible to enable an override wrong syntax message as new feature.
  3. There isn't a specific placeholder that checks for player party existence but the opposite: %out_party% (message configurable), it is meant to be used together with the party name placeholder to be able to show some text only when the player is not inside a party: [%party%%out_party%] -> [None] or [MyParty] (with %out_party% configured as None). For a conditional checking you can use %out_party% == "" (inside a party).

@Ranksu10
Copy link
Author

Ranksu10 commented Jan 11, 2025

Ty for the answer, and you're right, but now that I check, is there any placeholder that verify if the player has party notifications muted? (i.e: %parties_mute%)

Also, I think you miss 1 suggestion:

Add a sound notification when a player receives a new party invite.
This feature should be customizable in the config (enable: true/false) the sound and adjust its volume and pitch.

But it's alright if it's not ideal!

Also, it would be nice to add an extra message when a player has /party mute enabled and is using /party accept (when other player attempts to invite him). This message would like something like this:
mute-notification: "&cYou are currently ignoring party invites. Type /party mute to disable..."

Another extra suggestion would be to save the status of /party chat (if enabled/disabled for a player), so every time I rejoin the server, server restarts, or plugin is reloaded, I don't need to use /party chat again

@Ranksu10
Copy link
Author

1. Ty for the answer, and you're right, but now that I check, is there any placeholder that verify if the player has party notifications muted? (i.e: %parties_mute%)
2. Also, it would be nice to add an extra message when a player has /party mute enabled and is using /party accept (when other player attempts to invite him). This message would like something like this:
mute-notification: "&cYou are currently ignoring party invites. Type /party mute to disable..."
3. Another extra suggestion would be to save the status of /party chat (if enabled/disabled for a player), so every time I rejoin the server, server restarts, or plugin is reloaded, I don't need to use /party chat again`

Just a reminder, these 3 suggestions would be ideal if you add them!

@AlessioDP
Copy link
Owner

I already added all of them into my to do list ;)

I will just keep this issue open as reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants