Remove useless per-item fetch and add real User-Agent

Author: AlexPresso

src/main/java/me/alexpresso/zuninja/classes/item/ItemDetail.java

@@ -1,6 +1,5 @@
 package me.alexpresso.zuninja.services.item;
 
-import me.alexpresso.zuninja.classes.item.ItemDetail;
 import me.alexpresso.zuninja.domain.nodes.item.Fusion;
 import me.alexpresso.zuninja.domain.nodes.item.Item;
 
@@ -11,8 +10,6 @@
 public interface ItemService {
     List<Item> fetchItems() throws IOException, InterruptedException;
 
-    ItemDetail fetchItemDetail(Item item) throws IOException, InterruptedException;
-
     List<Item> getItems();
 
     Map<String, Item> updateItems() throws IOException, InterruptedException;

src/main/java/me/alexpresso/zuninja/services/item/ItemService.java

@@ -1,7 +1,6 @@
 package me.alexpresso.zuninja.services.item;
 
 import com.fasterxml.jackson.core.type.TypeReference;
-import me.alexpresso.zuninja.classes.item.ItemDetail;
 import me.alexpresso.zuninja.domain.nodes.item.Fusion;
 import me.alexpresso.zuninja.domain.nodes.item.Item;
 import me.alexpresso.zuninja.domain.nodes.item.Pack;
@@ -46,11 +45,6 @@ public List<Item> fetchItems() throws IOException, InterruptedException {
         return (List<Item>) this.requestService.request("/public/item", "GET", new TypeReference<List<Item>>() {});
     }
 
-    @Override
-    public ItemDetail fetchItemDetail(final Item item) throws IOException, InterruptedException {
-        return (ItemDetail) this.requestService.request(String.format("/public/item/%s", item.getSlug()), "GET", new TypeReference<ItemDetail>(){});
-    }
-
     @Override
     public List<Item> getItems() {
         return this.itemRepository.findAll();
@@ -73,21 +67,19 @@ public Map<String, Item> updateItems() throws IOException, InterruptedException
 
         items.parallelStream().forEach(item -> {
             try {
-                final var detail = this.fetchItemDetail(item);
-
                 dbItems.put(item.getId(), dbItems.getOrDefault(item.getId(), item)
                     .setPack(packs.get(item.getPack().getId()))
                     .setGenre(item.getGenre())
                     .setName(item.getName())
                     .setRarity(item.getRarity())
                     .setSlug(item.getSlug())
-                    .setCounting(detail.isCounting())
-                    .setCraftable(detail.isCraftable())
-                    .setInvocable(detail.isInvocable())
-                    .setRecyclable(detail.isRecyclable())
-                    .setTradable(detail.isTradable())
-                    .setGoldable(detail.isGoldable())
-                    .setUpgradable(detail.isUpgradable())
+                    .setCounting(item.isCounting())
+                    .setCraftable(item.isCraftable())
+                    .setInvocable(item.isInvocable())
+                    .setRecyclable(item.isRecyclable())
+                    .setTradable(item.isTradable())
+                    .setGoldable(item.isGoldable())
+                    .setUpgradable(item.isUpgradable())
                 );
 
                 logger.info("({}/{}) Updated {} ", count.getAndIncrement(), items.size(), item.getName());

src/main/java/me/alexpresso/zuninja/services/item/ItemServiceImpl.java

@@ -54,7 +54,7 @@ public Object request(final String uri, final String method, final Object data,
                 "sec-fetch-dest", "empty",
                 "sec-fetch-mode", "cors",
                 "sec-fetch-site", "same-site",
-                "user-agent", "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36",
+                "user-agent", "github.com/alexpresso/zunivers-ninja",
                 "x-zunivers-rulesettype", this.gameMode.name()
             ).uri(URI.create(String.format("https://%s%s", this.apiBaseUrl, uri)));