Skip to content
This repository was archived by the owner on Sep 13, 2024. It is now read-only.
This repository was archived by the owner on Sep 13, 2024. It is now read-only.

updateMenu should be public #243

@Christilut

Description

@Christilut

This method is marked private:

private updateMenu(menu?: Menu) { }

But if you update the menu with wth Menu.setApplicationMenu(menu) then the commandId's have changed but this package does not know about the new commandId's. The result is that clicking any menu item does not work since they refer to non-existing commandId's.

If I run titlebar.updateMenu(menu) after setApplicationMenu, the commandIds are also updated and clicks work as expected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions