Reduce compilation time of the QC project (#219)

* Framework - delete unnecessary headers, add needed, correct inclusion type

* Forward declarations and moving stuff inside .cxx files

* more forward declarations and Framework tests clean up

* cleanups in Modules

* use default ctors and dtors wherever possible

* some additional (hopefully) improvements

* Formatting

Author: knopers8

Framework/CMakeLists.txt

@@ -43,6 +43,7 @@ add_library(QualityControl
             src/CcdbDatabase.cxx
             src/InformationService.cxx
             src/InformationServiceDump.cxx
+            src/TaskFactory.cxx
             src/TaskRunner.cxx
             src/TaskRunnerFactory.cxx
             src/TaskInterface.cxx

Framework/include/QualityControl/CcdbDatabase.h

@@ -16,7 +16,8 @@
 #ifndef QC_REPOSITORY_CCDBDATABASE_H
 #define QC_REPOSITORY_CCDBDATABASE_H
 
-#include "CCDB/CcdbApi.h"
+#include <CCDB/CcdbApi.h>
+
 #include "QualityControl/DatabaseInterface.h"
 
 namespace o2::quality_control::repository
@@ -49,7 +50,7 @@ namespace o2::quality_control::repository
 class CcdbDatabase : public DatabaseInterface
 {
  public:
-  CcdbDatabase();
+  CcdbDatabase() = default;
   virtual ~CcdbDatabase();
 
   void connect(std::string host, std::string database, std::string username, std::string password) override;
@@ -84,7 +85,7 @@ class CcdbDatabase : public DatabaseInterface
    */
   std::string getListing(std::string subpath = "", std::string accept = "text/plain");
   o2::ccdb::CcdbApi ccdbApi;
-  std::string mUrl;
+  std::string mUrl = "";
 };
 
 } // namespace o2::quality_control::repository

Framework/include/QualityControl/CheckInterface.h

@@ -16,6 +16,10 @@
 #ifndef QC_CHECKER_CHECKINTERFACE_H
 #define QC_CHECKER_CHECKINTERFACE_H
 
+#include <string>
+
+#include <Rtypes.h>
+
 #include "QualityControl/MonitorObject.h"
 #include "QualityControl/Quality.h"
 

Framework/include/QualityControl/Checker.h

@@ -20,17 +20,33 @@
 // std & boost
 #include <chrono>
 #include <memory>
+#include <string>
+#include <map>
+#include <vector>
 // O2
 #include <Common/Timer.h>
-#include <Configuration/ConfigurationInterface.h>
 #include <Framework/Task.h>
-#include <Monitoring/MonitoringFactory.h>
+#include <Headers/DataHeader.h>
 // QC
 #include "QualityControl/CheckInterface.h"
 #include "QualityControl/DatabaseInterface.h"
 #include "QualityControl/MonitorObject.h"
 #include "QualityControl/QcInfoLogger.h"
 
+namespace o2::framework
+{
+struct InputSpec;
+struct OutputSpec;
+class DataAllocator;
+} // namespace o2::framework
+
+namespace o2::monitoring
+{
+class Monitoring;
+}
+
+class TClass;
+
 namespace o2::quality_control::checker
 {
 

Framework/include/QualityControl/CheckerFactory.h

@@ -16,7 +16,12 @@
 #ifndef QC_CHECKERFACTORY_H
 #define QC_CHECKERFACTORY_H
 
-#include "Framework/DataProcessorSpec.h"
+#include <string>
+
+namespace o2::framework
+{
+struct DataProcessorSpec;
+}
 
 namespace o2::quality_control::checker
 {

Framework/include/QualityControl/DataDumpGui.h

@@ -17,7 +17,9 @@
 #ifndef QC_CORE_DATADUMP_H
 #define QC_CORE_DATADUMP_H
 
-#include "FairMQDevice.h"
+#include <string>
+
+#include <fairmq/FairMQDevice.h>
 
 namespace o2::quality_control::core
 {

Framework/include/QualityControl/DatabaseFactory.h

@@ -17,8 +17,6 @@
 #define QC_REPOSITORY_DATABASEFACTORY_H
 
 #include <memory>
-// O2
-#include "Common/Exceptions.h"
 // QC
 #include "QualityControl/DatabaseInterface.h"
 

Framework/include/QualityControl/DatabaseInterface.h

@@ -16,10 +16,12 @@
 #ifndef QC_REPOSITORY_DATABASEINTERFACE_H
 #define QC_REPOSITORY_DATABASEINTERFACE_H
 
-#include "QualityControl/MonitorObject.h"
+#include <string>
 #include <memory>
+#include <vector>
 #include <unordered_map>
-//#include <bits/unique_ptr.h>
+
+#include "QualityControl/MonitorObject.h"
 
 namespace o2::quality_control::repository
 {
@@ -31,9 +33,9 @@ class DatabaseInterface
 {
  public:
   /// Default constructor
-  DatabaseInterface() {}
+  DatabaseInterface() = default;
   /// Destructor
-  virtual ~DatabaseInterface() {}
+  virtual ~DatabaseInterface() = default;
 
   /**
    * Connects to the database.

Framework/include/QualityControl/ExamplePrinterSpec.h

@@ -16,6 +16,17 @@
 #ifndef QUALITYCONTROL_EXAMPLEPRINTERSPEC_H
 #define QUALITYCONTROL_EXAMPLEPRINTERSPEC_H
 
+#include <string>
+#include <memory>
+
+#include <TH1F.h>
+#include <TObjArray.h>
+
+#include <Framework/Task.h>
+#include <Framework/DataRefUtils.h>
+
+#include "QualityControl/MonitorObject.h"
+
 namespace o2::quality_control::example
 {
 

Framework/include/QualityControl/HistoMerger.h

@@ -16,13 +16,21 @@
 #ifndef QC_CORE_HISTOMERGER_H
 #define QC_CORE_HISTOMERGER_H
 
-#include <memory>
+#include <string>
 #include <vector>
 
-#include "Common/Timer.h"
+#include <Common/Timer.h>
 #include <Framework/Task.h>
 #include <Headers/DataHeader.h>
-#include <TH1.h>
+
+namespace o2::framework
+{
+struct InputSpec;
+struct OutputSpec;
+} // namespace o2::framework
+
+class TH1;
+class TObjArray;
 
 #include "QualityControl/MonitorObject.h"