Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set aspect ratio of pattern image #586

Closed
t0mpr1c3 opened this issue Oct 17, 2023 · 4 comments · Fixed by #587
Closed

Set aspect ratio of pattern image #586

t0mpr1c3 opened this issue Oct 17, 2023 · 4 comments · Fixed by #587
Assignees
Labels
Milestone

Comments

@t0mpr1c3
Copy link
Contributor

t0mpr1c3 commented Oct 17, 2023

The image is viewed with square pixels. But stitches do not necessarily have the same height and width. Perhaps there could be an option to set the ratio of height to width to get a better idea of how the knitting is going to come out.

You could set the gauge in Preferences, or in the Options panel on the RHS of the display. I think I prefer putting it on the Options panel with a slider control, but I don't really have strong feelings about it.

Adrienne suggests that it could default to either 1x1 as it is now, or to a typical Fair Isle gauge such as 28x36 to 10cm/4ins.

@t0mpr1c3 t0mpr1c3 added this to the next milestone Oct 17, 2023
@t0mpr1c3
Copy link
Contributor Author

Perhaps we should also make suggestions in the documentation for what the aspect ratio is likely to be. I understand that it varies with the knitting mode and the number of colours. I seem to recall Alessandrina writing about that on her blog somewhere.

@t0mpr1c3
Copy link
Contributor Author

I suppose you would do a swatch to calibrate the ratio for your specific machine/stitch/yarn/tension, and use that ratio when digitizing images in GIMP. It's that digitizing step that is critical, so it probably doesn't matter too much if the ratio isn't exactly right onscreen. Screen resolution is also an issue for large patterns. So maybe just 2 presets of (say) 1:1 and 3:4 is OK?

@t0mpr1c3
Copy link
Contributor Author

Adrienne commented:

Yes, the important place to do your gauge math is in Gimp or wherever. The problem we're trying to solve is that when you bring it into AYAB at 1x1 it looks a bit stretched on screen, but knits up correctly. I suppose just the presets you're suggesting would be enough, as it's only about the visuals, no effect on the actual knitting.

On reflection, maybe just a few preset choices is better than entering the actual gauge, as we don't want to give the idea that AYAB can change the image itself to match your gauge. That's a whole image-manipulation thing that AYAB doesn't attempt to tackle.

@t0mpr1c3
Copy link
Contributor Author

I suggest we try 1:1 and 4:5 for starters, it's easy to add more later. I'll put the option in preferences to avoid cluttering up the options panel, but again it's easy enough to move.

@t0mpr1c3 t0mpr1c3 linked a pull request Oct 17, 2023 that will close this issue
@t0mpr1c3 t0mpr1c3 self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant