Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improve the sideways scroll of the lower display. #615

Closed
6 tasks
Adrienne200 opened this issue Feb 21, 2024 · 6 comments · Fixed by #674
Closed
6 tasks

[BUG] Improve the sideways scroll of the lower display. #615

Adrienne200 opened this issue Feb 21, 2024 · 6 comments · Fixed by #674
Milestone

Comments

@Adrienne200
Copy link

Adrienne200 commented Feb 21, 2024

AYAB software version: 0.99 RC2
Computer/OS: Windows 7, small laptop
Knitting machine: KH910
AYAB hardware: Interface or shield

I'm using a small Windows laptop with a minuscule screen, 1024x600. Mostly the UI scales down to this size quite well, but the new lower display doesn't scroll properly. It might also not scroll smoothly on a larger screen.

Steps to reproduce the behavior:

  1. Open the "Stirnband" sample which is 160 pixels wide
  2. All settings at default, start to knit a few rows.
  3. Try scrolling sideways in the lower display.

Expected:

Actual:
On a small screen, when you move the slider it seems to jump from one area to the next without any indication of overlap, and never show the middle. It may be better on a larger screen but I'll guess that it isn't very good there either.
sideways scroll small screen

@t0mpr1c3
Copy link
Contributor

Good suggestions -- I edited the above to add checkboxes.

@t0mpr1c3
Copy link
Contributor

t0mpr1c3 commented Mar 1, 2024

This isn't straightforward in Qt, I propose postponing this to after v1.0, except for fixing the alignment.

@X-sam X-sam modified the milestones: 1.0.0, next Mar 30, 2024
@X-sam
Copy link
Member

X-sam commented Jul 4, 2024

Some questions about changes to the knit progress view-
Windows doesn't support colored backgrounds on table headers, so the options are "highlight current color but the info isn't 'sticky'"(left) or "don't highlight current color but the info is 'sticky'"(right). Both of them have a sticky column indicator that turns bold when you select a specific column.

Non-sticky row info Sticky Row Info
Screenshot 2024-07-04 160250 Screenshot 2024-07-04 161500

I believe the latter is what Adrienne is asking for.

@X-sam
Copy link
Member

X-sam commented Jul 4, 2024

Here are some videos to clarify (seems you need to click on them to view them):

Non-sticky row info Sticky Row Info
video of non-sticky video of sticky

@t0mpr1c3
Copy link
Contributor

t0mpr1c3 commented Jul 6, 2024

I was under the impression that implementing the sticky header was really complicated in Qt. I am far from expert though.

@X-sam
Copy link
Member

X-sam commented Jul 7, 2024

I was under the impression that implementing the sticky header was really complicated in Qt. I am far from expert though.

I mean, I did it... The videos are from test branches I made.

@X-sam X-sam linked a pull request Jul 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants