Occasional warnings

[ranous]

I'm getting these warnings occasionally - maybe once a day. Normally I wouldn't care but they show up in big red letters in the system status window. Here's an example:

WARNING: Data File /home/ranous/allsky/config/overlay/extra/pistatus.json is invalid - IGNORING.

Now I've seen this happen with different module's json files so it's not isolated to a specific module. Not positive what's going on but perhaps these files are being read while they're being written and they see a partial result. Hard to say without a log of the invalid data or saving the corrupted file somewhere for further analysis. If it is due to incomplete writes, then perhaps save the extradata in a temp file and move it to the correct filename after it's closed.

[Alex-developer]

Which version are you running and which Pi?

That error is thrown by the overlay manager when its trying to open and read the json from the file. Its possible that it could be caused by trying o read he file as its written but its not something i have ever seen and you would have to be very unlucky !

Looking at the code it could do with some more detail on what the error is so I will create an issue from this and get it looked at in the next release.

I like the idea of writing to a temp file and moving the file which should be pretty easy as all of the modules save their data via the same function so thanks for the idea which I will add to he next release :-)

Alex

[ranous]

I'm running the latest bit running on a Pi4 using a HQ camera. Well, whatever is going on, happened again last night. I've seen the problem four times with four different modules, all running as periodic jobs.

[EricClaeys]

Please attach /var/log/allsky.log and /var/log/allskyperiodic.log.

[EricClaeys]

Allsky uploads images and videos to a remote Website using a temporary name, then renames the file to the final name for exactly this reason. Ditto for the current image (image.jpg) on the Pi.