Update Uniform Sample to accept and output multiple fields #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l unit tests to use the string convention and update teh docs
fix error message
cyrush
reviewed
May 27, 2025
| } | ||
|
|
||
|
|
||
| std::string field = field_selection[0]; |
There was a problem hiding this comment.
We're still using it to grab the topo and then data
cyrush
reviewed
May 27, 2025
src/libs/ascent/runtimes/flow_filters/ascent_runtime_vtkh_filters.cpp
Outdated
Show resolved
Hide resolved
cyrush
reviewed
May 27, 2025
cyrush
reviewed
May 27, 2025
Thanks! I think I've hit them all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now takes in a list of fields.