Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Updating custom character changes the data for incorrect character. #439

Closed
BillTheBeast opened this issue Feb 13, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@BillTheBeast
Copy link

BillTheBeast commented Feb 13, 2025

What doesn't work?

When sending a updated stats for the character to the server incorrect character is in most cases being updated.
More specifically it always updates the very last character from the CustomCharacter table, not the one which id was provided.
This also changes that characters CharacterId, if it is provided.

What is the endpoint and method? (if applicable)

Endpoint: CustomCharacter/

Method: PUT

How can it be reproduced?

  1. Send an update call with updated character stats to the server with stats from any character with any characterid already in the list.

What should it do instead?

Update the stats of the character whose id was provided.

@BillTheBeast BillTheBeast added the bug Something isn't working label Feb 13, 2025
@MikhailDeriabin MikhailDeriabin moved this from Backlog to In progress in Altzone-Server Feb 13, 2025
@MikhailDeriabin
Copy link
Member

Fixed by adding CustomCharacter._id to the update method call.

Fixes are applied to both latest-release and dev builds

@github-project-automation github-project-automation bot moved this from In progress to Done in Altzone-Server Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants