ensure failed lookup requests are persisted too (#490)

* ensure failed lookup requests are persisted too.

* updated unit test

Author: acn-sbuad

src/Altinn.Notifications.Core/Services/OrderRequestService.cs

@@ -51,14 +51,6 @@ public async Task<NotificationOrderRequestResponse> RegisterNotificationOrder(No
         var copiedRecipents = orderRequest.Recipients.Select(r => r.DeepCopy()).ToList();
         var lookupResult = await GetRecipientLookupResult(copiedRecipents, orderRequest.NotificationChannel);
 
-        if (lookupResult?.Status == RecipientLookupStatus.Failed)
-        {
-            return new NotificationOrderRequestResponse()
-            {
-                RecipientLookup = lookupResult
-            };
-        }
-
         var templates = SetSenderIfNotDefined(orderRequest.Templates);
 
         var order = new NotificationOrder(

src/Altinn.Notifications/Controllers/EmailNotificationOrdersController.cs

@@ -73,11 +73,6 @@ public async Task<ActionResult<NotificationOrderRequestResponseExt>> Post(EmailN
         var orderRequest = emailNotificationOrderRequest.MapToOrderRequest(creator);
         NotificationOrderRequestResponse result = await _orderRequestService.RegisterNotificationOrder(orderRequest);
 
-        if (result.RecipientLookup?.Status == RecipientLookupStatus.Failed)
-        {
-            return BadRequest(result);
-        }
-
         return Accepted(result.OrderId!.GetSelfLinkFromOrderId(), result.MapToExternal());
     }
 }

test/Altinn.Notifications.IntegrationTests/Notifications/EmailNotificationsOrderController/EmailNotificationOrdersControllerTests.cs

@@ -247,7 +247,7 @@ public async Task Post_ValidAccessToken_ServiceReturnsSuccessRequestResult_Accep
     }
 
     [Fact]
-    public async Task Post_ServiceReturnsFailedLookupStatus_BadRequest()
+    public async Task Post_ServiceReturnsFailedLookupStatus_Accepted()
     {
         // Arrange
         Mock<IOrderRequestService> serviceMock = new();
@@ -276,7 +276,7 @@ public async Task Post_ServiceReturnsFailedLookupStatus_BadRequest()
         string respoonseString = await response.Content.ReadAsStringAsync();
 
         // Assert
-        Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
+        Assert.Equal(HttpStatusCode.Accepted, response.StatusCode);
         NotificationOrderRequestResponseExt? responseObject = JsonSerializer.Deserialize<NotificationOrderRequestResponseExt>(respoonseString, _options);
         Assert.Null(responseObject?.OrderId);
         Assert.Equal(RecipientLookupStatusExt.Failed, responseObject!.RecipientLookup!.Status);

test/Altinn.Notifications.Tests/Notifications.Core/TestingServices/OrderRequestServiceTests.cs

@@ -213,7 +213,7 @@ public async Task RegisterNotificationOrder_ForSms_NoSenderNumberDefaultInserted
     }
 
     [Fact]
-    public async Task RegisterNotificationOrder_LookupFails_NoOrderCreated()
+    public async Task RegisterNotificationOrder_LookupFails_OrderCreated()
     {
         // Arrange
         DateTime sendTime = DateTime.UtcNow;
@@ -243,7 +243,7 @@ public async Task RegisterNotificationOrder_LookupFails_NoOrderCreated()
 
         // Assert        
         Assert.Equal(RecipientLookupStatus.Failed, actual.RecipientLookup?.Status);
-        repoMock.Verify(r => r.Create(It.IsAny<NotificationOrder>()), Times.Never);
+        repoMock.Verify(r => r.Create(It.IsAny<NotificationOrder>()), Times.Once);
     }
 
     [Fact]