Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending notification to a national identity number #439

Closed
17 of 18 tasks
Tracked by #203
acn-sbuad opened this issue Feb 16, 2024 · 0 comments
Closed
17 of 18 tasks
Tracked by #203

Comments

@acn-sbuad
Copy link
Contributor

acn-sbuad commented Feb 16, 2024

Description

Considerations

  • Which status code to return if recipient has reserved themselves in KRR?
  • Which status code to return if recipient does not have any contact details
  • If none of the provided recipients have a successful address lookup should we reject the order request?

Specification

Response model for posting order: Full details in response. No need for additional request

Alternative 1:

"orderId":"GUID",
"recipientLookup":[Success, PartialSuccess, Failed]
"recipientLookupValidation": 
	{
		"personLookup": {
			"isReserved": "1234568,12345678,2345678",
			"missingEmail":"12345,12345,12345",
			"missingMobileNumber":"23456,23456,23456"
			},
		"organisationLookup":{
			"missingEmail":"12345",
			"missingMobileNumber":"23456"
	}
}

Alternative 2:

"orderId":"GUID",
"recipientLookup":[Success, PartialSuccess, Failed]
"recipientLookupValidation": [
	{
	"missingContact": "1234568, 9842345",
	"isReserved": "1234568, 9842345"	
	}]

Tasks

  • Add property bool IgnoreReservation to EmailNotificationOrderRequestExt
  • Add property bool IgnoreReservation to SmsNotificationOrderRequestExt
  • Add new model NotificationOrderRequestResponseExt following the JSON example above
  • add new property to NotificationOrderRequest and NotificationOrder domain models
  • Extend endpoints with logic for checking existence of contact points for recipient
  • Modify validation rules for order request endpoints
  • QA
  • Update swagger
  • Update user documentation
  • Manual test

Acceptance criteria

  • Default state for an order request is that the order is reservable.
  • It is possible to place an email notification order specifying only the national identity number of the recipient
  • It is possible to place an sms notification order specifying only the national identity number of the recipient
  • It is possible to place a notifications order specifying both the national identity number of the recipient and an email address
  • It is possible to place a notifications order specifying both the national identity number of the recipient and a mobile number
  • Creator should get immediate confirmation that we have found contact point and there is no reservation
  • OrderRequest endpoint should return 202 if recipient is reserved
  • OrderRequest endpoint should return 202 if no contact details are found for recipient
@acn-sbuad acn-sbuad changed the title API Add support for ordering notification to a national identity number Feb 19, 2024
@acn-sbuad acn-sbuad changed the title Add support for ordering notification to a national identity number Add support sending notification to a national identity number Feb 19, 2024
@acn-sbuad acn-sbuad changed the title Add support sending notification to a national identity number Add support for sending notification to a national identity number Feb 19, 2024
@acn-sbuad acn-sbuad assigned acn-sbuad and unassigned acn-sbuad Mar 22, 2024
@acn-sbuad acn-sbuad self-assigned this Apr 8, 2024
acn-sbuad added a commit that referenced this issue Apr 12, 2024
* sending nin to db

* lookup on order placement is not persisted in order in db

* fixed code smell

* removed unused refence

* added unit test

* updated unit tests
@acn-sbuad acn-sbuad assigned acn-sbuad and unassigned acn-sbuad Apr 12, 2024
@acn-sbuad acn-sbuad removed their assignment Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant