Skip to content

Fix Build In WSL #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Fix Build In WSL #35

merged 2 commits into from
Mar 16, 2024

Conversation

AminoffZ
Copy link
Owner

This PR aims to fix the build script in WSL, there were some path resolution issues. Also extract-inline changed to ts file.

@AminoffZ AminoffZ requested a review from mAmineChniti March 16, 2024 16:20
@AminoffZ
Copy link
Owner Author

@mAmineChniti Do you want to check on your dev environment that I didn't break anything?

@mAmineChniti
Copy link
Collaborator

mAmineChniti commented Mar 16, 2024

@AminoffZ it works normally on my machine.

@mAmineChniti mAmineChniti merged commit 96bfc65 into main Mar 16, 2024
@mAmineChniti mAmineChniti deleted the wsl-build-fix branch March 16, 2024 16:36
@AminoffZ
Copy link
Owner Author

@mAmineChniti Perfect! No not yet, gonna publish now that this is resolved 👍
Btw is there a reason why eslint doesn't warn the LSP before failing in the workflow? Would be nice to be able to catch linting errors directly in the editor before running checks/lint script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants