Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use props and bindings #14

Open
ruiramos opened this issue Oct 30, 2015 · 1 comment
Open

Use props and bindings #14

ruiramos opened this issue Oct 30, 2015 · 1 comment
Labels
enhancement help wanted

Comments

@ruiramos
Copy link

Since we're extending View, any reason we're not using props for the settings and bindings to set the label text content inside the label element? It would make this element more extendable. I can help with the PR if you agree.
@pgilad
Copy link
Member

pgilad commented Oct 30, 2015

👍 Great idea! PR is definitely welcomed

dhritzkiv added a commit that referenced this issue May 27, 2017
@dhritzkiv
Impelement disabled via props and bindings; add tests
d3ab49e 
Improves on #18/#20
Fixes #13
Fixe #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ruiramos @pgilad