Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let fetchById accept options #23

Closed
wants to merge 1 commit into from
Closed

let fetchById accept options #23

wants to merge 1 commit into from

Conversation

pgilad
Copy link
Member

@pgilad pgilad commented Apr 3, 2015

@wraithgar
Copy link
Contributor

Should probably enforce this w/ a test. +1 on the idea/code. Minor release.

@lukekarrys
Copy link
Contributor

+1 for the code from me, but agree that it would be really nice to have a test with this also.

@pgilad
Copy link
Member Author

pgilad commented Apr 4, 2015

I couldn't get a relevant test to pass without spending too much time on this.
My feeling is that this code isn't ready to be merged. It could be an side-case along the way, or that the original tests are overriding something else.
I can close this PR unless someone wants to make it work somehow ;-)

re:edit I'm closing this for now...

@pgilad pgilad closed this Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetchById should take secondary [xhr] options object
4 participants
@pgilad @wraithgar @lukekarrys @bear