-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verse numbers displayed sometimes after verse (in conjunction with red Jesus cite) #3371
Labels
Comments
Downgrade to 5.0.835 solved the problem, 5.0.840 contains the bug. |
Tested with Jsword version 2.4.16 and it did not reproduce there. The current JSword version (2.4.19) has this issue. |
This is regression from fix to #3304. |
tuomas2
added a commit
to AndBible/jsword
that referenced
this issue
Feb 11, 2025
tuomas2
added a commit
to AndBible/jsword
that referenced
this issue
Feb 13, 2025
This reverts commit dfb0b0c.
tuomas2
added a commit
to AndBible/jsword
that referenced
this issue
Feb 13, 2025
This reverts commit ccb4971. Fix did not work and moreover it caused regression: AndBible/and-bible#3371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version 5.0.841 fdroid standard release, on LineageOS 22.1 (= Android 15)
Causing effectively, that in the affected verses the text isn't part of the verse, and the verse itself is empty. This happens on various places, and I didn't find an example where no red Jesus cite is involved.
This isn't a problem with the module. To prove it, I created a minimum example module, and placed it at Jon:1.1. Here the relevant part of the OSIS source:
Result:
![Image](https://private-user-images.githubusercontent.com/175323916/411349246-80b825b7-826c-4fb6-bc56-268431289ac2.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzAzODYsIm5iZiI6MTczOTY3MDA4NiwicGF0aCI6Ii8xNzUzMjM5MTYvNDExMzQ5MjQ2LTgwYjgyNWI3LTgyNmMtNGZiNi1iYzU2LTI2ODQzMTI4OWFjMi5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwMTQxMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jMWViOTE2MWY0ZDYxYWQyMmMxMWI1OGYyYmY1ZTI2NDAwMmE3NjRhODc1Nzg5YzA4ZGE1ZTVmODNmNmMzMDZmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.gZG1igJLT8H1Fm3LtBzC4Li1D5334QAE1CklMsZx2JI)
Curiously, when removing the verse after, or the title, or the verse before, everything is fine.
History: My Bible module worked for years. Then, I can remember, for some Bible+ Versions it happened, but disappeared for later versions. But now it happened again for at least 2 current versions.
In the attached ZIP, you can find the minimum example module sources, and the compiled module. To compile run this:
To get an uncompressed SWORD file
debug/nt
run that:osis2mod "debug" "osis_source.xml" -v German
test_module_sources.zip
The text was updated successfully, but these errors were encountered: