Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verse numbers displayed sometimes after verse (in conjunction with red Jesus cite) #3371

Closed
chkloos opened this issue Feb 9, 2025 · 3 comments

Comments

@chkloos
Copy link

chkloos commented Feb 9, 2025

Version 5.0.841 fdroid standard release, on LineageOS 22.1 (= Android 15)

Image

Causing effectively, that in the affected verses the text isn't part of the verse, and the verse itself is empty. This happens on various places, and I didn't find an example where no red Jesus cite is involved.

This isn't a problem with the module. To prove it, I created a minimum example module, and placed it at Jon:1.1. Here the relevant part of the OSIS source:

<chapter osisID="John.1" n="1">
<verse osisID="John.1.1" n="1">A</verse>
<title type="main">B</title>
<verse osisID="John.1.2" n="2"><q who="Jesus">C</q></verse>
<verse osisID="John.1.3" n="3">D</verse>
</chapter>

Result:
Image

Curiously, when removing the verse after, or the title, or the verse before, everything is fine.

History: My Bible module worked for years. Then, I can remember, for some Bible+ Versions it happened, but disappeared for later versions. But now it happened again for at least 2 current versions.

In the attached ZIP, you can find the minimum example module sources, and the compiled module. To compile run this:

osis2mod "modules/test" "osis_source.xml" -z l -b 4 -l 9 -v German
zip -r test.zip mods.d modules

To get an uncompressed SWORD file debug/nt run that: osis2mod "debug" "osis_source.xml" -v German

test_module_sources.zip

@chkloos
Copy link
Author

chkloos commented Feb 11, 2025

Downgrade to 5.0.835 solved the problem, 5.0.840 contains the bug.

@tuomas2
Copy link
Contributor

tuomas2 commented Feb 11, 2025

Tested with Jsword version 2.4.16 and it did not reproduce there. The current JSword version (2.4.19) has this issue.

@tuomas2 tuomas2 moved this from Needs triage to Blockers in Tuomas' project board Feb 11, 2025
@tuomas2
Copy link
Contributor

tuomas2 commented Feb 11, 2025

This is regression from fix to #3304.

tuomas2 added a commit to AndBible/jsword that referenced this issue Feb 11, 2025
tuomas2 added a commit to AndBible/jsword that referenced this issue Feb 13, 2025
tuomas2 added a commit to AndBible/jsword that referenced this issue Feb 13, 2025
This reverts commit ccb4971.

Fix did not work and moreover it caused regression: AndBible/and-bible#3371
@github-project-automation github-project-automation bot moved this from Blockers to Closed in Tuomas' project board Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

No branches or pull requests

2 participants