From 022433380f14936b0a80ebb664809a78a8e63b0d Mon Sep 17 00:00:00 2001 From: katzman Date: Mon, 2 Oct 2023 22:44:26 +0000 Subject: [PATCH] Lint --- contracts/core/strategy/APStrategy_V1.sol | 3 +-- contracts/integrations/flux/FluxStrategy.sol | 8 ++++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/contracts/core/strategy/APStrategy_V1.sol b/contracts/core/strategy/APStrategy_V1.sol index 7e51e2ffe..0a634bddd 100644 --- a/contracts/core/strategy/APStrategy_V1.sol +++ b/contracts/core/strategy/APStrategy_V1.sol @@ -6,7 +6,6 @@ import {IStrategy} from "./IStrategy.sol"; import {Pausable} from "@openzeppelin/contracts/security/Pausable.sol"; abstract contract APStrategy_V1 is IStrategy, Pausable { - /*** CONSTNATS ***/ uint256 constant EXP_SCALE = 1e18; @@ -54,7 +53,7 @@ abstract contract APStrategy_V1 is IStrategy, Pausable { function unpause() external virtual onlyAdmin { _unpause(); } - + modifier nonZeroAmount(uint256 amt) { if (amt == 0) revert ZeroAmount(); _; diff --git a/contracts/integrations/flux/FluxStrategy.sol b/contracts/integrations/flux/FluxStrategy.sol index b7ea25b1d..b2b1111b4 100644 --- a/contracts/integrations/flux/FluxStrategy.sol +++ b/contracts/integrations/flux/FluxStrategy.sol @@ -29,7 +29,7 @@ contract FluxStrategy is APStrategy_V1, ReentrancyGuard { /// @return yieldTokenAmt the qty of `config.yieldToken` that were yielded from the deposit action function deposit( uint256 amt - ) external override payable whenNotPaused nonReentrant nonZeroAmount(amt) returns (uint256) { + ) external payable override whenNotPaused nonReentrant nonZeroAmount(amt) returns (uint256) { IERC20(config.baseToken).safeTransferFrom(_msgSender(), address(this), amt); IERC20(config.baseToken).safeApprove(config.yieldToken, amt); uint256 yieldTokens = _enterPosition(amt); @@ -49,7 +49,7 @@ contract FluxStrategy is APStrategy_V1, ReentrancyGuard { /// @return baseTokenAmt the qty of `config.baseToken` that are approved for transfer by msg.sender function withdraw( uint256 amt - ) external override payable whenNotPaused nonReentrant nonZeroAmount(amt) returns (uint256) { + ) external payable override whenNotPaused nonReentrant nonZeroAmount(amt) returns (uint256) { if (!IFlux(config.yieldToken).transferFrom(_msgSender(), address(this), amt)) { revert TransferFailed(); } @@ -66,7 +66,7 @@ contract FluxStrategy is APStrategy_V1, ReentrancyGuard { /// @dev This method expects that the `amt` provided is denominated in `baseToken` /// @param amt the qty of the `baseToken` that should be checked for conversion rates /// @return yieldTokenAmt the expected qty of `yieldToken` if this strategy received `amt` of `baseToken` - function previewDeposit(uint256 amt) external override view returns (uint256) { + function previewDeposit(uint256 amt) external view override returns (uint256) { // Exchange Rate == (EXP_SCALE * USDC) / fUSDC uint256 exRate = IFlux(config.yieldToken).exchangeRateStored(); // Expected fUSDC == (amtUSDC * EXP_SCALE / exRate) @@ -77,7 +77,7 @@ contract FluxStrategy is APStrategy_V1, ReentrancyGuard { /// @dev This method expects that the `amt` provided is denominated in `yieldToken` /// @param amt the qty of the `yieldToken` that should be checked for conversion rates /// @return yieldTokenAmt the expected qty of `baseToken` if this strategy received `amt` of `yieldToken` - function previewWithdraw(uint256 amt) external override view returns (uint256) { + function previewWithdraw(uint256 amt) external view override returns (uint256) { // Exchange Rate == (EXP_SCALE * USDC) / fUSDC uint256 exRate = IFlux(config.yieldToken).exchangeRateStored(); // Expected USDC == (amtfUSDC * exRate) / EXP_SCALE