From 3da4e7e5ab2a8b779942caf9dc36ef31c167bba3 Mon Sep 17 00:00:00 2001 From: gs8nrv <55771972+GuillaumeNervoXS@users.noreply.github.com> Date: Fri, 22 Sep 2023 11:32:41 +0200 Subject: [PATCH] removed all TOODs --- .../angle-staked-stable-e2e.test.ts | 2 -- .../angle-staked-stable-events.test.ts | 1 - .../angle-staked-stable-integration.test.ts | 10 +++------- .../angle-staked-stable/angle-staked-stable-pool.ts | 9 +-------- src/dex/angle-staked-stable/angle-staked-stable.ts | 8 +------- 5 files changed, 5 insertions(+), 25 deletions(-) diff --git a/src/dex/angle-staked-stable/angle-staked-stable-e2e.test.ts b/src/dex/angle-staked-stable/angle-staked-stable-e2e.test.ts index 4adc93c9a..ca78ba024 100644 --- a/src/dex/angle-staked-stable/angle-staked-stable-e2e.test.ts +++ b/src/dex/angle-staked-stable/angle-staked-stable-e2e.test.ts @@ -140,7 +140,5 @@ describe('AngleStakedStable E2E', () => { tokenBAmount, nativeTokenAmount, ); - - // TODO: Add any additional test cases required to test AngleStakedStable }); }); diff --git a/src/dex/angle-staked-stable/angle-staked-stable-events.test.ts b/src/dex/angle-staked-stable/angle-staked-stable-events.test.ts index 50427749f..00c58a310 100644 --- a/src/dex/angle-staked-stable/angle-staked-stable-events.test.ts +++ b/src/dex/angle-staked-stable/angle-staked-stable-events.test.ts @@ -50,7 +50,6 @@ async function fetchPoolState( blockNumber: number, poolAddress: string, ): Promise { - // TODO: complete me! return angleStakedStablePools.generateState(blockNumber); } diff --git a/src/dex/angle-staked-stable/angle-staked-stable-integration.test.ts b/src/dex/angle-staked-stable/angle-staked-stable-integration.test.ts index 4d8bdbc7d..6a226c108 100644 --- a/src/dex/angle-staked-stable/angle-staked-stable-integration.test.ts +++ b/src/dex/angle-staked-stable/angle-staked-stable-integration.test.ts @@ -35,7 +35,6 @@ function getReaderCalldata( readerIface: Interface, amounts: bigint[], funcName: string, - // TODO: Put here additional arguments you need ) { return amounts.map(amount => ({ target: exchangeAddress, @@ -48,7 +47,6 @@ function decodeReaderResult( readerIface: Interface, funcName: string, ) { - // TODO: Adapt this function for your needs return results.map(result => { const parsed = readerIface.decodeFunctionResult(funcName, result); return BigInt(parsed[0]._hex); @@ -62,9 +60,8 @@ async function checkOnChainPricing( prices: bigint[], amounts: bigint[], ) { - const exchangeAddress = '0x004626a008b1acdc4c74ab51644093b155e59a23'; // TODO: Put here the real exchange address + const exchangeAddress = '0x004626a008b1acdc4c74ab51644093b155e59a23'; - // TODO: Replace dummy interface with the real one // Normally you can get it from angleStakedStable.Iface or from eventPool. // It depends on your implementation const readerIface = AngleStakedStableEventPool.angleStakedStableIface; @@ -161,7 +158,6 @@ describe('AngleStakedStable', function () { const tokens = Tokens[network]; - // TODO: Put here token Symbol to check against // Don't forget to update relevant tokens in constant-e2e.ts const srcTokenSymbol = 'agEUR'; const destTokenSymbol = 'stEUR'; @@ -219,7 +215,7 @@ describe('AngleStakedStable', function () { destTokenSymbol, SwapSide.SELL, amountsForSell, - funcNameSell, // TODO: Put here proper function name to check pricing + funcNameSell, ); }); @@ -233,7 +229,7 @@ describe('AngleStakedStable', function () { destTokenSymbol, SwapSide.BUY, amountsForBuy, - funcNameBuy, // TODO: Put here proper function name to check pricing + funcNameBuy, ); }); diff --git a/src/dex/angle-staked-stable/angle-staked-stable-pool.ts b/src/dex/angle-staked-stable/angle-staked-stable-pool.ts index b6265e78e..6aded42f7 100644 --- a/src/dex/angle-staked-stable/angle-staked-stable-pool.ts +++ b/src/dex/angle-staked-stable/angle-staked-stable-pool.ts @@ -36,12 +36,10 @@ export class AngleStakedStableEventPool extends StatefulEventSubscriber AngleStakedStableEventPool.angleStakedStableIface.parseLog(log); this.addressesSubscribed = [config.stEUR]; @@ -90,7 +88,6 @@ export class AngleStakedStableEventPool extends StatefulEventSubscriber> { - // TODO: complete me! let poolState = { totalAssets: 0n, totalSupply: 0n, @@ -166,7 +163,6 @@ export class AngleStakedStableEventPool extends StatefulEventSubscriber 0n ? 1n : 0n; @@ -184,7 +179,6 @@ export class AngleStakedStableEventPool extends StatefulEventSubscriber 0n ? 1n : 0n; diff --git a/src/dex/angle-staked-stable/angle-staked-stable.ts b/src/dex/angle-staked-stable/angle-staked-stable.ts index d8a2d9285..43c6d550b 100644 --- a/src/dex/angle-staked-stable/angle-staked-stable.ts +++ b/src/dex/angle-staked-stable/angle-staked-stable.ts @@ -47,7 +47,7 @@ export class AngleStakedStable readonly network: Network, readonly dexKey: string, readonly dexHelper: IDexHelper, - protected adapters = Adapters[network] || {}, // TODO: add any additional optional params to support other fork DEXes + protected adapters = Adapters[network] || {}, ) { super(dexHelper, dexKey); const config = AngleStakedStableConfig[dexKey][network]; @@ -63,7 +63,6 @@ export class AngleStakedStable // for pricing requests. It is optional for a DEX to // implement this function async initializePricing(blockNumber: number) { - // TODO: complete me! this.eventPools = new AngleStakedStableEventPool( this.dexKey, this.network, @@ -90,7 +89,6 @@ export class AngleStakedStable side: SwapSide, blockNumber: number, ): Promise { - // TODO: complete me! if (!this._knownAddress(srcToken, destToken)) return []; else return [this.dexKey]; } @@ -107,7 +105,6 @@ export class AngleStakedStable blockNumber: number, limitPools?: string[], ): Promise> { - // TODO: complete me! const srcTokenAddress = srcToken.address.toLowerCase(); const destTokenAddress = destToken.address.toLowerCase(); if (!this._knownAddress(srcToken, destToken)) return null; @@ -173,7 +170,6 @@ export class AngleStakedStable getCalldataGasCost( poolPrices: PoolPrices, ): number | number[] { - // TODO: update if there is any payload in getAdapterParam return CALLDATA_GAS_COST.DEX_NO_PAYLOAD; } @@ -188,7 +184,6 @@ export class AngleStakedStable data: AngleStakedStableData, side: SwapSide, ): AdapterExchangeParam { - // TODO: complete me! const { exchange } = data; // Encode here the payload for adapter @@ -250,7 +245,6 @@ export class AngleStakedStable // getTopPoolsForToken. It is optional for a DEX // to implement this async updatePoolState(): Promise { - // TODO: complete me! const tokenBalanceMultiCall = [ { target: this.config.stEUR,