🐛 Tags are assigned incorrectly in summon.mcfunction for vanilla display entities

[PhinxDash]

🛑 Before you Start

• I have searched existing bug reports for my problem.
• I have read the F-A-Q.
• I am using the latest version of Animated Java
• I will only report a single bug in this report. If I have found multiple bugs, I will create a separate report for each one.

🗣️ Describe the bug

The tags for vanilla display entities are incorrect in summon.mcfuntion after exporting.

Here is the full relevant line in the generated data pack.

summon minecraft:item_display ~ ~ ~ { Tags:[ 'aj.new', 'aj.global.entity', 'aj.global.root', 'aj.blueprint.entity', 'aj.blueprint.root' ], teleport_duration: 0, interpolation_duration: 1, Passengers:[{id:"minecraft:item_display",Tags:["aj.new","aj.global.entity","aj.global.data","aj.blueprint.entity","aj.blueprint.data"],data:{rigHash:"66b1adbcf6258fa4ed78bfd5c505924fe0b643f54c1708f06947feeeedbeadcc",locators:{locator1:{posx:0f,posy:0.1875f,posz:0f,rotx:0f,roty:0f,uuid:""},locator2:{posx:0f,posy:0.125f,posz:0f,rotx:0f,roty:0f,uuid:""},locator3:{posx:0f,posy:0.0625f,posz:0f,rotx:0f,roty:0f}},cameras:{},uuids:{data_data:"",bone_menu:"",locator_locator1:"",locator_locator2:"",locator_locator3:"",text_display_text_example:"",item_display_item_example:"",block_display_block_example:"",bone_center:""}}},{Tags:["aj.blueprint.bone","aj.blueprint.bone.center.child","aj.blueprint.bone.center.child.bone","aj.blueprint.bone.center.decendant","aj.blueprint.bone.center.decendant.bone","aj.blueprint.bone.center.tree","aj.blueprint.bone.center.tree.bone","aj.blueprint.bone.menu","aj.blueprint.bone.menu.tree","aj.blueprint.bone.menu.tree.bone","aj.blueprint.display_node.menu","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.menu","aj.global.bone","aj.global.bone.center.child","aj.global.bone.center.child.bone","aj.global.bone.center.decendant","aj.global.bone.center.decendant.bone","aj.global.bone.center.tree","aj.global.bone.center.tree.bone","aj.global.bone.menu.tree","aj.global.bone.menu.tree.bone","aj.global.display_node.menu","aj.global.entity","aj.global.node","aj.global.node.menu","aj.new"],id:"minecraft:item_display",transformation:{translation:[0f,0f,0f],left_rotation:[0f,0f,0f,1f],right_rotation:[0f,0f,0f,1f],scale:[0f,0f,0f]},interpolation_duration:1,teleport_duration:0,item_display:"head",item:{id:"minecraft:white_dye",components:{"minecraft:item_model":"animated_java:blueprint/blueprint/menu","minecraft:custom_model_data":{strings:["default"]}}},height:48f,width:48f},{Tags:["aj.blueprint.bone.center.child","aj.blueprint.bone.center.child.text_display","aj.blueprint.bone.center.decendant","aj.blueprint.bone.center.decendant.text_display","aj.blueprint.bone.center.tree","aj.blueprint.display_node.text_example","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.text_example","aj.blueprint.text_display","aj.blueprint.text_display.text_example","aj.global.bone.center.child","aj.global.bone.center.child.text_display","aj.global.bone.center.decendant","aj.global.bone.center.decendant.text_display","aj.global.bone.center.tree","aj.global.display_node.text_example","aj.global.entity","aj.global.node","aj.global.node.text_example","aj.global.text_display","aj.new"],id:"minecraft:text_display",transformation:{translation:[0f,0f,0f],left_rotation:[0f,0f,0f,1f],right_rotation:[0f,0f,0f,1f],scale:[0f,0f,0f]},interpolation_duration:1,teleport_duration:0,height:48f,width:48f,text:"Hello World!",background:1087515692,line_width:200,shadow:1b,see_through:1b,alignment:"left"},{Tags:["aj.blueprint.bone.center.child","aj.blueprint.bone.center.child.item_display","aj.blueprint.bone.center.decendant","aj.blueprint.bone.center.decendant.item_display","aj.blueprint.bone.center.tree","aj.blueprint.display_node.item_example","aj.blueprint.entity","aj.blueprint.item_display","aj.blueprint.item_display.item_example","aj.blueprint.node","aj.blueprint.node.item_example","aj.global.bone.center.child","aj.global.bone.center.child.item_display","aj.global.bone.center.decendant","aj.global.bone.center.decendant.item_display","aj.global.bone.center.tree","aj.global.display_node.item_example","aj.global.entity","aj.global.item_display","aj.global.node","aj.global.node.item_example","aj.new"],id:"minecraft:item_display",item:{id:"minecraft:diamond",count:1}},{Tags:["aj.blueprint.block_display","aj.blueprint.block_display.block_example","aj.blueprint.bone.center.child","aj.blueprint.bone.center.child.block_display","aj.blueprint.bone.center.decendant","aj.blueprint.bone.center.decendant.block_display","aj.blueprint.bone.center.tree","aj.blueprint.display_node.block_example","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.block_example","aj.global.block_display","aj.global.bone.center.child","aj.global.bone.center.child.block_display","aj.global.bone.center.decendant","aj.global.bone.center.decendant.block_display","aj.global.bone.center.tree","aj.global.display_node.block_example","aj.global.entity","aj.global.node","aj.global.node.block_example","aj.new"],id:"minecraft:block_display",block_state:{Name:"stone",Properties:{}}},{Tags:["aj.blueprint.bone","aj.blueprint.bone.center","aj.blueprint.bone.center.tree","aj.blueprint.bone.center.tree.bone","aj.blueprint.display_node.center","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.center","aj.global.bone","aj.global.bone.center.tree","aj.global.bone.center.tree.bone","aj.global.display_node.center","aj.global.entity","aj.global.node","aj.global.node.center","aj.global.root.child","aj.global.root.child.bone","aj.new"],id:"minecraft:item_display",transformation:{translation:[0f,0f,0f],left_rotation:[0f,0f,0f,1f],right_rotation:[0f,0f,0f,1f],scale:[0f,0f,0f]},interpolation_duration:1,teleport_duration:0,item_display:"head",item:{id:"minecraft:white_dye",components:{"minecraft:item_model":"animated_java:blueprint/blueprint/center","minecraft:custom_model_data":{strings:["default"]}}},height:48f,width:48f}], }

It is a very large block of text, but there is a text_display, item_display, and a block_display, along with 2 regular bones. The regular bones have what I'm assuming are the correct tags, aside from those relating to the vanilla displays, but the vanilla displays have incorrect and missing tags. For example, none of them have tags of the format "aj.blueprint.bone.". I don't have the best knowledge of what the tags should be, but I also notice that there are tags that seem to be wrongly placed. For example, the item_display has the tag aj.global.block_display.

This means that properly selecting vanilla display entities with tags is not possible. Additionally, things like the default pose don't work, since it uses selections like:
execute on passengers if entity @s[tag=aj.blueprint.bone.text_example] run

⚠️ Error Message

🔄️ How to Reproduce

Here is the blueprint I was using. This is the only blueprint I have been testing with recently, and this is the first time I have tested with vanilla displays, so I don't know how widespread of an issue this is. Note that the selected export version was 1.21.5, but the issue template only allows selecting 1.21.4 so that is what I put. The AJ version was 1.7.3. Note that in the attached blueprint, the vanilla displays are in a folder together rather than having their own. However, I also tested separately with the vanilla displays each being in their own folders, but the issue persisted.

test.ajblueprint.zip

✅ Expected Behavior

The tags in the generated data pack should match what is expected by the data pack, what is in the documentation, etc. relating to vanilla display entities.

💡 Solutions & Alternatives

No response

🟩 Minecraft Version

1.21.4

🟦 Blockbench Version

4.12.6

💻 Operating System

MacOS

📃 Installed Blockbench Plugins

No response

⛰️ Minecraft Environment

N.A.

[SnaveSutit]

Additionally, things like the default pose don't work, since it uses selections like:
execute on passengers if entity @s[tag=aj.blueprint.bone.text_example] run

The @s here is intentional. on passengers is running the selector on every passenger (node) of the root entity, which includes all vanilla display entities.

For example: The function below is called as the rig's data entity. Each execute on vehicle on passengers is selecting the root with on vehicle, then all of the root's passengers with on passengers. Then filtering a specific node with the @s[tag=...] selector.

but I also notice that there are tags that seem to be wrongly placed. For example, the item_display has the tag aj.global.block_display.

This is odd, but I am unable to reproduce this issue with modern Animated Java. So perhaps the issue has been fixed?

the vanilla displays have incorrect and missing tags. For example, none of them have tags of the format "aj.blueprint.bone."

Looks like there are plenty of those tags in there to me...

For more information about Animated Java's tag system, check out this document:
https://animated-java.dev/docs/rigs/tags

[PhinxDash]

I just tested again after uninstalling AJ, installing the latest release (1.7.3) from the file, and creating a new blueprint with the target version set to 1.21.5 (although it seems to happen regardless of the version for me.)

From the new generated data pack, here is the full summon.mcfunction file:

data modify storage aj:temp args set value {variant:''}
$execute store success score #success aj.i run data modify storage aj:temp args set value $(args)
summon minecraft:item_display ~ ~ ~ { Tags:[ 'aj.new', 'aj.global.entity', 'aj.global.root', 'aj.blueprint.entity', 'aj.blueprint.root' ], teleport_duration: 0, interpolation_duration: 1, Passengers:[{id:"minecraft:item_display",Tags:["aj.new","aj.global.entity","aj.global.data","aj.blueprint.entity","aj.blueprint.data"],data:{rigHash:"5ce10cca64e0f8f6122f52931d8ff46b38250897bc117fc28b28b4eb2fc796bf",locators:{},cameras:{},uuids:{data_data:"",bone_bone2_example:"",bone_bone1_example:"",item_display_item_example:"",block_display_block_example:"",text_display_text_example:""}}},{Tags:["aj.blueprint.bone","aj.blueprint.bone.bone1_example.child","aj.blueprint.bone.bone1_example.child.bone","aj.blueprint.bone.bone1_example.decendant","aj.blueprint.bone.bone1_example.decendant.bone","aj.blueprint.bone.bone1_example.tree","aj.blueprint.bone.bone1_example.tree.bone","aj.blueprint.bone.bone2_example","aj.blueprint.bone.bone2_example.tree","aj.blueprint.bone.bone2_example.tree.bone","aj.blueprint.display_node.bone2_example","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.bone2_example","aj.global.bone","aj.global.bone.bone1_example.child","aj.global.bone.bone1_example.child.bone","aj.global.bone.bone1_example.decendant","aj.global.bone.bone1_example.decendant.bone","aj.global.bone.bone1_example.tree","aj.global.bone.bone1_example.tree.bone","aj.global.bone.bone2_example.tree","aj.global.bone.bone2_example.tree.bone","aj.global.display_node.bone2_example","aj.global.entity","aj.global.node","aj.global.node.bone2_example","aj.new"],id:"minecraft:item_display",transformation:{translation:[0f,0f,0f],left_rotation:[0f,0f,0f,1f],right_rotation:[0f,0f,0f,1f],scale:[0f,0f,0f]},interpolation_duration:1,teleport_duration:0,item_display:"head",item:{id:"minecraft:white_dye",components:{"minecraft:item_model":"animated_java:blueprint/blueprint/bone2_example","minecraft:custom_model_data":{strings:["default"]}}},height:48f,width:48f},{Tags:["aj.blueprint.bone","aj.blueprint.bone.bone1_example","aj.blueprint.bone.bone1_example.tree","aj.blueprint.bone.bone1_example.tree.bone","aj.blueprint.display_node.bone1_example","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.bone1_example","aj.global.bone","aj.global.bone.bone1_example.tree","aj.global.bone.bone1_example.tree.bone","aj.global.display_node.bone1_example","aj.global.entity","aj.global.node","aj.global.node.bone1_example","aj.global.root.child","aj.global.root.child.bone","aj.new"],id:"minecraft:item_display",transformation:{translation:[0f,0f,0f],left_rotation:[0f,0f,0f,1f],right_rotation:[0f,0f,0f,1f],scale:[0f,0f,0f]},interpolation_duration:1,teleport_duration:0,item_display:"head",item:{id:"minecraft:white_dye",components:{"minecraft:item_model":"animated_java:blueprint/blueprint/bone1_example","minecraft:custom_model_data":{strings:["default"]}}},height:48f,width:48f},{Tags:["aj.blueprint.display_node.item_example","aj.blueprint.entity","aj.blueprint.item_display","aj.blueprint.item_display.item_example","aj.blueprint.node","aj.blueprint.node.item_example","aj.global.display_node.item_example","aj.global.entity","aj.global.item_display","aj.global.node","aj.global.node.item_example","aj.global.root.child","aj.global.root.child.item_display","aj.new"],id:"minecraft:item_display",item:{id:"minecraft:diamond",count:1}},{Tags:["aj.blueprint.block_display","aj.blueprint.block_display.block_example","aj.blueprint.display_node.block_example","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.block_example","aj.global.block_display","aj.global.display_node.block_example","aj.global.entity","aj.global.node","aj.global.node.block_example","aj.global.root.child","aj.global.root.child.block_display","aj.new"],id:"minecraft:block_display",block_state:{Name:"stone",Properties:{}}},{Tags:["aj.blueprint.display_node.text_example","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.text_example","aj.blueprint.text_display","aj.blueprint.text_display.text_example","aj.global.display_node.text_example","aj.global.entity","aj.global.node","aj.global.node.text_example","aj.global.root.child","aj.global.root.child.text_display","aj.global.text_display","aj.new"],id:"minecraft:text_display",transformation:{translation:[0f,0f,0f],left_rotation:[0f,0f,0f,1f],right_rotation:[0f,0f,0f,1f],scale:[0f,0f,0f]},interpolation_duration:1,teleport_duration:0,height:48f,width:48f,text:"Hello World!",background:1073741824,line_width:200,shadow:0b,see_through:0b,alignment:"center"}], }
execute as @e[type=minecraft:item_display,tag=aj.new,limit=1,distance=..0.01] run function animated_java:blueprint/zzz/summon/as_root_entity

To clarify more, I have looked through the tags documentation, and these significantly do not match what they should be, although it is to such an extent that I can't easily tell what the pattern is. However, it seems to me that, in terms of the order that the bones and vanilla displays are written, it seems that certain tags are shifted left.
For example:

• The bone that has the item_model path for "bone2_example" has many tags for "bone1_example" which is to the right of it.
• The bone that has the item_model path for "bone1_example" has many tags for the vanilla item display "item_example" which is to the right of it.
• The vanilla item_display "item_example" has many tags for "block_example" which is to the right of it.
• The vanilla block_display "block_example" has many tags for "text_example" which is to the right of it.
• The vanilla text_display "text_example" has no tags whatsoever, and there is nothing to the right of it, since it is the last one in the order they are written in.

Potentially related or perhaps not, (still related to tags) here is the full set_default_pose.mcfunction file:

execute unless entity @s[type=minecraft:item_display,tag=aj.blueprint.root] run return run function animated_java:global/errors/function_not_executed_as_root_entity {'export_namespace': 'blueprint', 'function_path': 'animated_java:blueprint/set_default_pose'}
execute on passengers if entity @s[tag=aj.blueprint.bone.bone2_example] run data merge entity @s {transformation: [-1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,-1f,0f,0f,0f,0f,1f], start_interpolation: -1}
execute on passengers if entity @s[tag=aj.blueprint.bone.bone1_example] run data merge entity @s {transformation: [-1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,-1f,0f,0f,0f,0f,1f], start_interpolation: -1}
execute on passengers if entity @s[tag=aj.blueprint.bone.item_example] run data merge entity @s {transformation: [-1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,-1f,0f,0f,0f,0f,1f], start_interpolation: -1}
execute on passengers if entity @s[tag=aj.blueprint.bone.block_example] run data merge entity @s {transformation: [-1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,-1f,0f,0f,0f,0f,1f], start_interpolation: -1}
execute on passengers if entity @s[tag=aj.blueprint.bone.text_example] run data merge entity @s {transformation: [1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,1f], start_interpolation: -1}

As you can see, it uses tags with the format aj.<export_namespace>.bone.<name> for everything, including the vanilla displays "item_example", "block_example", and "text_example". Even if tags were assigned correctly in summon.mcfunction, these tags would still not be present for the vanilla displays, which I believe is intended based on the documentation and your previous message. However, the fact that they are trying to be used in set_default_pose.mcfunction is still an issue.

Strangely, after I remove the vanilla displays in Blockbench and re-export after deleting all AJ files from the data pack, I still get the following in summon.mcfunction with the seemingly shifted-left tags and no tags for the last-written bone. I have been using this version of AJ for a long time and never have noticed this problem before, but for some reason it is now consistently happening. That leads me to believe I changed something specific on my end at some point that is causing this, but I do not know what.

data modify storage aj:temp args set value {variant:''}
$execute store success score #success aj.i run data modify storage aj:temp args set value $(args)
summon minecraft:item_display ~ ~ ~ { Tags:[ 'aj.new', 'aj.global.entity', 'aj.global.root', 'aj.blueprint.entity', 'aj.blueprint.root' ], teleport_duration: 0, interpolation_duration: 1, Passengers:[{id:"minecraft:item_display",Tags:["aj.new","aj.global.entity","aj.global.data","aj.blueprint.entity","aj.blueprint.data"],data:{rigHash:"73d9541be63dbfd936b1f0614bc0342f070d04e9b75619bc8f2a538a6e48b34b",locators:{},cameras:{},uuids:{data_data:"",bone_bone2_example:"",bone_bone1_example:""}}},{Tags:["aj.blueprint.bone","aj.blueprint.bone.bone1_example.child","aj.blueprint.bone.bone1_example.child.bone","aj.blueprint.bone.bone1_example.decendant","aj.blueprint.bone.bone1_example.decendant.bone","aj.blueprint.bone.bone1_example.tree","aj.blueprint.bone.bone1_example.tree.bone","aj.blueprint.bone.bone2_example","aj.blueprint.bone.bone2_example.tree","aj.blueprint.bone.bone2_example.tree.bone","aj.blueprint.display_node.bone2_example","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.bone2_example","aj.global.bone","aj.global.bone.bone1_example.child","aj.global.bone.bone1_example.child.bone","aj.global.bone.bone1_example.decendant","aj.global.bone.bone1_example.decendant.bone","aj.global.bone.bone1_example.tree","aj.global.bone.bone1_example.tree.bone","aj.global.bone.bone2_example.tree","aj.global.bone.bone2_example.tree.bone","aj.global.display_node.bone2_example","aj.global.entity","aj.global.node","aj.global.node.bone2_example","aj.new"],id:"minecraft:item_display",transformation:{translation:[0f,0f,0f],left_rotation:[0f,0f,0f,1f],right_rotation:[0f,0f,0f,1f],scale:[0f,0f,0f]},interpolation_duration:1,teleport_duration:0,item_display:"head",item:{id:"minecraft:white_dye",components:{"minecraft:item_model":"animated_java:blueprint/blueprint/bone2_example","minecraft:custom_model_data":{strings:["default"]}}},height:48f,width:48f},{Tags:["aj.blueprint.bone","aj.blueprint.bone.bone1_example","aj.blueprint.bone.bone1_example.tree","aj.blueprint.bone.bone1_example.tree.bone","aj.blueprint.display_node.bone1_example","aj.blueprint.entity","aj.blueprint.node","aj.blueprint.node.bone1_example","aj.global.bone","aj.global.bone.bone1_example.tree","aj.global.bone.bone1_example.tree.bone","aj.global.display_node.bone1_example","aj.global.entity","aj.global.node","aj.global.node.bone1_example","aj.global.root.child","aj.global.root.child.bone","aj.new"],id:"minecraft:item_display",transformation:{translation:[0f,0f,0f],left_rotation:[0f,0f,0f,1f],right_rotation:[0f,0f,0f,1f],scale:[0f,0f,0f]},interpolation_duration:1,teleport_duration:0,item_display:"head",item:{id:"minecraft:white_dye",components:{"minecraft:item_model":"animated_java:blueprint/blueprint/bone1_example","minecraft:custom_model_data":{strings:["default"]}}},height:48f,width:48f}], }
execute as @e[type=minecraft:item_display,tag=aj.new,limit=1,distance=..0.01] run function animated_java:blueprint/zzz/summon/as_root_entity

[SnaveSutit]

Yeah, all bones that are a child of bone1_example are supposed to have aj.blueprint.bone.bone1_example.child.
Same for all the other tags that those bones have that mention other bones, but have a suffix like .tree or .child.

If you look closely, you will notice there is only ever one mention of "aj.blueprint.bone.bone1_example". This is the tag that identifies which bone is bone1_example.

Everything you've shown me in your last message looks to be how Animated Java is supposed to work.

[PhinxDash]

I see now what I was confused about regarding thinking the tags were “shifted left” when really it is just that each bone or vanilla display has their tags specified first before the minecraft:<type>_display while the root and data entity have the tags specified after.

I believe that my following point about set_default_pose.mcfunction may still be an actual problem, but I will create a new issue and close this one:

It uses tags with the format aj.<export_namespace>.bone.<name> for everything, including the vanilla displays "item_example", "block_example", and "text_example" which are not present for vanilla displays and are not supposed to be present for them (if I understand the documentation).

execute on passengers if entity @s[tag=aj.blueprint.bone.bone2_example] run data merge entity @s {transformation: [-1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,-1f,0f,0f,0f,0f,1f], start_interpolation: -1}
execute on passengers if entity @s[tag=aj.blueprint.bone.bone1_example] run data merge entity @s {transformation: [-1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,-1f,0f,0f,0f,0f,1f], start_interpolation: -1}
execute on passengers if entity @s[tag=aj.blueprint.bone.item_example] run data merge entity @s {transformation: [-1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,-1f,0f,0f,0f,0f,1f], start_interpolation: -1}
execute on passengers if entity @s[tag=aj.blueprint.bone.block_example] run data merge entity @s {transformation: [-1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,-1f,0f,0f,0f,0f,1f], start_interpolation: -1}
execute on passengers if entity @s[tag=aj.blueprint.bone.text_example] run data merge entity @s {transformation: [1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,1f,0f,0f,0f,0f,1f], start_interpolation: -1}```