Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[feature Request]: Dark Mode/ Light Mode Toggle #625

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Poushmita
Copy link

Description

Added the Dark Mode/ Light Mode toggle for every pages and with updated styles.

Closes #65

Type of PR

  • (Added New Feature)

Screenshots / videos (if applicable)

-### Home
o1

- About Us

o2

- Collections

o3

- Services

o4

- Contact Us

o5

- Cart

o6

- Login

o7

- Signup

o8

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

  • Added the toggle for every page .
  • Updated the styles of the paragraph, h1, h2 etc. accordingly.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Poushmita! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 4d48030
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/67177db100f36600085a73bb
😎 Deploy Preview https://deploy-preview-625--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51
Copy link
Owner

@Poushmita in below picture see , use right side toggle button , such that on input it should change the modes.

image

@Poushmita
Copy link
Author

Poushmita commented Oct 21, 2024

@Anjaliavv51
Please confirm:

  1. Does the left toggle button successfully change the mode?
  2. I set the dark mode background to dark purple on login/sign-up pages and black for the rest. Would you like any changes to these colours?
  3. The right side toggle button is not in every page. Should I add the right toggle button to all pages?
  • If the left toggle button is fine, please merge this PR. I will create another issue regarding the problem( changing mode by the right side toggle button) you mentioned above..

(Note: - I am requesting this because the right side toggle button was not in the website when, I forked it .
So, I am unable to analyse the problem with the right one. if I pull all changes in my local code then it will overlap with my changes.
So, if you please consider to merge the PR first then I will change rest of the needs and will make another PR for it.
And, please tell me if any conflicts arise.)

@Poushmita
Copy link
Author

@Anjaliavv51 If you like this, I can update my PR with these stylings.

Additional Style

Screenshots

one two

@Anjaliavv51
Copy link
Owner

@Anjaliavv51 If you like this, I can update my PR with these stylings.

Additional Style

Screenshots

one two

yes these changes are great

@Poushmita
Copy link
Author

@Anjaliavv51 Check the changes and merge my PR. Please let me know, if anything is needed.

Final Change

Screenshots

1 2

@Poushmita
Copy link
Author

@Anjaliavv51 Merge this PR.

1 similar comment
@Poushmita
Copy link
Author

@Anjaliavv51 Merge this PR.

@Anjaliavv51
Copy link
Owner

@Poushmita their are still so bugs and misalignment check in ur deployment in the below link and rectify

https://deploy-preview-625--rococo-mooncake-0d89f7.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[feature Request]: Dark Mode/ Light Mode Toggle
2 participants