Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Modal on Landing Page is Now Responsive on Smaller Screens #791

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

rajveeerr
Copy link
Contributor

@rajveeerr rajveeerr commented Oct 29, 2024

Resolved responsiveness issues with the default popup modal on the landing page. The modal now adapts properly to smaller screens, improving the user experience on mobile and tablet devices. Adjustments were made using Flexbox properties like flex-wrap, along with media queries to ensure the layout scales well on various screen sizes.

Related Issues

Type of PR

  • Bug Fix

Screenshots

Before

Screenshot 2024-10-29 at 9 20 31 PM

After

Screenshot 2024-10-29 at 9 35 21 PM Screenshot 2024-10-29 at 9 35 07 PM

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with the project’s main branch before making this PR.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context

Used Flexbox properties to make the modal responsive, added media queries for mobile compatibility, and tested the modal across common screen sizes. This fix ensures a consistent and user-friendly layout on smaller devices.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @rajveeerr! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 5716900
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/672107577f06600008b12513
😎 Deploy Preview https://deploy-preview-791--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51 Anjaliavv51 added enhancement New feature or request good first issue Good for newcomers gssoc-ext Level 1 labels Oct 31, 2024
@Anjaliavv51 Anjaliavv51 merged commit 808c4e1 into Anjaliavv51:main Oct 31, 2024
7 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers gssoc-ext Level 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[bug]: Popup Modal on Landing Page is Not Responsive on Smaller Screens
2 participants