Skip to content

[NRT-596] Add pre-commit hook to disallow anki/aqt imports in ankihub_client#1249

Open
RisingOrange wants to merge 1 commit intomainfrom
disallow-anki-aqt-imports-in-client
Open

[NRT-596] Add pre-commit hook to disallow anki/aqt imports in ankihub_client#1249
RisingOrange wants to merge 1 commit intomainfrom
disallow-anki-aqt-imports-in-client

Conversation

@RisingOrange
Copy link
Collaborator

@RisingOrange RisingOrange commented Feb 16, 2026

Enforce the architectural boundary that keeps the ankihub_client layer free of anki/aqt dependencies by adding a pygrep pre-commit hook.

Related issues

https://ankihub.atlassian.net/browse/NRT-596

Proposed changes

  • Added a no_anki_aqt_imports_in_client pre-commit hook that flags any from anki, from aqt, import anki, or import aqt lines in ankihub/ankihub_client/.
  • This prevents accidental coupling of the pure HTTP client layer to Anki internals.

How to reproduce

  1. Try adding from anki.notes import Note to any file in ankihub/ankihub_client/
  2. Run pre-commit run no_anki_aqt_imports_in_client --all-files
  3. The hook should fail and flag the import

Further comments

The client directory is already clean — no existing violations.

Enforce the architectural boundary that keeps the client layer
free of Anki/aqt dependencies.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @RisingOrange, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new pre-commit hook designed to enforce a strict architectural boundary. The hook prevents the ankihub_client directory from importing anki or aqt modules, thereby ensuring this client layer remains independent of Anki's core internals. This change enhances code modularity and prevents unintended coupling, maintaining a clean separation of concerns within the project.

Highlights

  • New Pre-commit Hook: A new no_anki_aqt_imports_in_client pre-commit hook has been added to prevent direct imports of anki or aqt modules within the ankihub/ankihub_client/ directory.
  • Architectural Enforcement: This hook enforces a critical architectural boundary, ensuring the ankihub_client layer remains decoupled from Anki's internal dependencies, promoting modularity and maintainability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .pre-commit-config.yaml
    • Added a new pygrep hook configuration to disallow anki and aqt imports in the ankihub_client path.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@RisingOrange RisingOrange changed the title Add pre-commit hook to disallow anki/aqt imports in ankihub_client [NRT-596] Add pre-commit hook to disallow anki/aqt imports in ankihub_client Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments