Fix submodule auth in upload workflows#1250
Merged
RisingOrange merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
abdnh
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
upload-to-ankiwebandupload-to-s3child jobs were failing when called from thecreate-releaseworkflow. Both jobs runbash ./scripts/release.sh, which callsbuild.py, which callsgit submodule update --init --recursive. This failed for the privateankihub_websubmodule because the checkout step had no credentials configured.Related issues
Proposed changes
token: ${{ secrets.WORKFLOW_GIT_ACCESS_TOKEN }}andsubmodules: recursiveto theactions/checkoutstep in bothupload_to_ankiweb.ymlandupload_to_s3.yml, matching the pattern already used increate_release.ymlWORKFLOW_GIT_ACCESS_TOKENin theworkflow_call.secretsblock of both workflows so the dependency is explicitupload_to_s3.ymlfromactions/checkout@v2to@v4How to reproduce
Trigger the
Create Releaseworkflow — the childupload-to-ankiwebandupload-to-s3jobs would fail at the "Create ankiaddon file" step withfatal: could not read Username for 'https://github.com'followed byerror: File not found: media_import/requirements.txt.Screenshots and videos
N/A
Further comments
The
create_releasejob was already working because it hadtoken+submodules: recursivein its checkout step. The child workflows were missing this, sobuild.py'sgit submodule updatehad no credentials and failed on the private submodule.