Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The audio monitor does not play alert audio, and TTS is played instead #2

Open
RiverYT opened this issue Oct 30, 2024 · 1 comment
Open
Labels
audio processing Regarding audio processing bug Something isn't working

Comments

@RiverYT
Copy link

RiverYT commented Oct 30, 2024

Any Audio from a physical monitor will be played as the tts and not the nws alert, amber alert, etc

@BunnyTub BunnyTub changed the title Audio Monitor Will not play Alert audio (not tts) The audio monitor does not play alert audio, and TTS is played instead Nov 5, 2024
@BunnyTub BunnyTub added bug Something isn't working audio processing Regarding audio processing labels Nov 5, 2024
@ApatheticDELL
Copy link
Owner

The code for the audio monitor is kinda sloppy in QuantumENDEC.

This issue in particular could occur if...

In the SAME monitor stage:

  • the alert audio is too short
  • if something fails when removing the EOM headers and/or attention tone
  • if the alert audio is unavailable during the to-CAP conversion stage (it won't attach the audio resulting in TTS in the Generation stage)

In the Generation stage, TTS will be generated if:

  • There is no audio attachment to the CAP
  • If decoding/converting the audio goes wrong

Now, this could be the potentially problematic code in the RemoveEOMpATTN function...
{BDDB3BE8-1837-44B8-B04C-FB419B4CFD27}

After it removes the EOM headers and the (EBS) attention tone, it will try to overwrite the input alert audio by deleting the original file first, and then exporting the new alert audio. I think the export process might be failing after the original audio has been removed, so there ends up being no alert audio, and it will generate TTS instead.

Now this isn't that of a big deal, but if this issue happens and TTS ends up bing generated, important alert information could be missing. I might be able to fix this, but do note that if the same issue happens after the fix, there could be long attention tones and a few too many EOM headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio processing Regarding audio processing bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants