Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operation is not propagated when serializing to TransactionAPI #53

Open
banteg opened this issue Jun 9, 2024 · 2 comments
Open

operation is not propagated when serializing to TransactionAPI #53

banteg opened this issue Jun 9, 2024 · 2 comments

Comments

@banteg
Copy link
Contributor

banteg commented Jun 9, 2024

operation denotes a call type (0=call, 1=delegatecall). the transaction would fail if we encode the wrong operation types. multisend specifically requires to be only called as a delegatecall.

users can currently work around this by passing a kwarg like txn(sender=safe, operation=1), but this is not very convenient and it should be fixed either in the library of ape api to allow passing it over.

txn_kwargs["operation"] = 1

Copy link

linear bot commented Jun 9, 2024

@banteg
Copy link
Contributor Author

banteg commented Jul 4, 2024

this simple fix in accounts.py works in the meanwhile:

    def estimate_gas_cost(self, **kwargs) -> int:
        return 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant