From 1750220b7e501d7dc3954ca94fc656f64b31485b Mon Sep 17 00:00:00 2001 From: Ivan Hrychaniuk Date: Wed, 6 Dec 2023 18:11:01 +0200 Subject: [PATCH 1/9] Remove `head` that returns only up to 6 rows --- R/semantic_report_constructors.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/semantic_report_constructors.R b/R/semantic_report_constructors.R index 8a214d3..6b22a82 100644 --- a/R/semantic_report_constructors.R +++ b/R/semantic_report_constructors.R @@ -28,7 +28,7 @@ prepare_modal_content <- function(error) { htmltools::div(class = "ui header", "Violated data (sample)"), htmltools::HTML( knitr::kable( - utils::head(error$error_df[[1]][[.x]]), + error$error_df[[1]][[.x]], "html", align = NULL, table.attr = "class=\"ui cellable table\"" From 99b19112765e952590feb18ffb3a1968a1cb7b49 Mon Sep 17 00:00:00 2001 From: Ivan Hrychaniuk Date: Wed, 6 Dec 2023 18:14:39 +0200 Subject: [PATCH 2/9] update `News.md` --- NEWS.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/NEWS.md b/NEWS.md index 8af50da..95e21e1 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,6 +4,10 @@ - Fixed `validate()` function to correctly return `data-name` attribute when used in pipe chains with `%>%` or `|>` operator. - `save_results()` now uses function passed to `method` argument to write results +# data.validator 0.2.1 + +- Bug fix for error table in modal that returned up to 6 rows. Now it returns full data frame. + # data.validator 0.2.0 - `validate_cols()` and `validate_rows()` will use all columns in dataframe if no column is passed From 00817db54fb421a96ebaad6615b64d5e5d82924b Mon Sep 17 00:00:00 2001 From: Ivan Hrychaniuk Date: Fri, 8 Dec 2023 12:10:44 +0200 Subject: [PATCH 3/9] revert `head`, but add optional parameter for error data.frame --- NEWS.md | 5 +--- R/semantic_report_constructors.R | 46 ++++++++++++++++++++++---------- man/display_results.Rd | 4 ++- man/get_semantic_report_ui.Rd | 10 ++++++- man/make_accordion_element.Rd | 5 +++- man/make_table_row.Rd | 4 ++- man/prepare_modal_content.Rd | 4 ++- man/render_semantic_report_ui.Rd | 5 +++- man/result_table.Rd | 4 ++- 9 files changed, 62 insertions(+), 25 deletions(-) diff --git a/NEWS.md b/NEWS.md index 95e21e1..0ed96ad 100644 --- a/NEWS.md +++ b/NEWS.md @@ -3,10 +3,7 @@ - Swapping of `error` and `warning` arguments in `save_summary()` fixed - Fixed `validate()` function to correctly return `data-name` attribute when used in pipe chains with `%>%` or `|>` operator. - `save_results()` now uses function passed to `method` argument to write results - -# data.validator 0.2.1 - -- Bug fix for error table in modal that returned up to 6 rows. Now it returns full data frame. +- Bug fix for error table in modal that always returns up to 6 rows. Now it may return full data frame. # data.validator 0.2.0 diff --git a/R/semantic_report_constructors.R b/R/semantic_report_constructors.R index 6b22a82..4aa8050 100644 --- a/R/semantic_report_constructors.R +++ b/R/semantic_report_constructors.R @@ -16,9 +16,10 @@ segment <- function(title, ...) { #' Prepare modal content. #' @description Prepare modal content. #' @param error Assertr error. +#' @param df_error_head_n Number of rows to display in error table. #' @return Modal content. #' @keywords internal -prepare_modal_content <- function(error) { +prepare_modal_content <- function(error, df_error_head_n) { data_part <- NULL #nolint: object_usage_linter errors_number <- seq_along(error$error_df[[1]]) purrr::map(errors_number, ~ { @@ -28,7 +29,7 @@ prepare_modal_content <- function(error) { htmltools::div(class = "ui header", "Violated data (sample)"), htmltools::HTML( knitr::kable( - error$error_df[[1]][[.x]], + utils::head(error$error_df[[1]][[.x]], n = df_error_head_n), "html", align = NULL, table.attr = "class=\"ui cellable table\"" @@ -66,11 +67,12 @@ prepare_modal_content <- function(error) { #' @param results Results to display in a row. #' @param type Result type. #' @param mark Icon to display. +#' @param df_error_head_n Number of rows to display in error table. #' @return Table row. #' @importFrom dplyr %>% #' @importFrom rlang .data #' @keywords internal -make_table_row <- function(results, type, mark) { +make_table_row <- function(results, type, mark, df_error_head_n) { description <- results %>% dplyr::pull(.data$description) id <- results %>% dplyr::pull(.data$assertion.id) data_name <- results %>% dplyr::pull(.data$table_name) @@ -92,7 +94,7 @@ make_table_row <- function(results, type, mark) { htmltools::div( class = "description", htmltools::tagList( - prepare_modal_content(results) + prepare_modal_content(results, df_error_head_n) ) ) ) @@ -123,9 +125,10 @@ make_table_row <- function(results, type, mark) { #' @param results Result to display in table. #' @param type Result type. #' @param mark Icon to display. +#' @param df_error_head_n Number of rows to display in error table. #' @return Table row. #' @keywords internal -result_table <- function(results, type, mark) { +result_table <- function(results, type, mark, df_error_head_n) { if (nrow(results) == 0) { "No cases to display." } else { @@ -147,7 +150,15 @@ result_table <- function(results, type, mark) { ) ), htmltools::tags$tbody( - purrr::map(1:nrow(results), ~ make_table_row(results[.x, ], type, mark)) #nolint: seq_linter + purrr::map( + seq_len(nrow(results)), + ~ make_table_row( + results[.x, ], + type, + mark, + df_error_head_n = df_error_head_n + ) + ) ) ) } @@ -173,9 +184,10 @@ make_accordion_container <- function(...) { #' @param color Color of the label icon. #' @param type Result type. #' @param active Is active? +#' @param df_error_head_n Number of rows to display in error table. #' @return Accordion. #' @keywords internal -make_accordion_element <- function(results, color = "green", label, active = FALSE, type, mark) { +make_accordion_element <- function(results, color = "green", label, active = FALSE, type, mark, df_error_head_n) { state <- NULL if (active) { state <- "active" @@ -192,7 +204,7 @@ make_accordion_element <- function(results, color = "green", label, active = FAL label ) ), - htmltools::div(class = paste("content", state), result_table(results, type, mark)) + htmltools::div(class = paste("content", state), result_table(results, type, mark, df_error_head_n)) ) } @@ -202,9 +214,10 @@ make_accordion_element <- function(results, color = "green", label, active = FAL #' @param n_passes Number of successful assertions. #' @param n_fails Number of warning assertions. #' @param n_warns Number of violation assertions. +#' @param df_error_head_n Number of rows to display in error table. #' @return Validation report. #' @keywords internal -display_results <- function(data, n_passes, n_fails, n_warns) { +display_results <- function(data, n_passes, n_fails, n_warns, df_error_head_n) { data_name <- data$table_name[1] results_failed <- data %>% dplyr::filter(.data$type == error_id) @@ -235,7 +248,8 @@ display_results <- function(data, n_passes, n_fails, n_warns) { label = "Failed", mark = "red big remove", type = error_id, - active = is_negative_active + active = is_negative_active, + df_error_head_n = df_error_head_n ), if (!is.null(n_warns)) make_accordion_element( @@ -317,15 +331,16 @@ make_summary_table <- function(n_passes, n_fails, n_warns) { #' @param n_fails Number of failed validations. #' @param n_warns Number of warnings. #' @param validation_results Data frame with validation results. +#' @param df_error_head_n Number of rows to display in error table. #' @return HTML validation report. #' @keywords internal -get_semantic_report_ui <- function(n_passes, n_fails, n_warns, validation_results) { +get_semantic_report_ui <- function(n_passes, n_fails, n_warns, validation_results, df_error_head_n = 6L) { summary_table <- make_summary_table(n_passes, n_fails, n_warns) unique_objects <- validation_results %>% dplyr::pull(.data$table_name) %>% unique() html_report <- unique_objects %>% purrr::map(~ { validation_results %>% dplyr::filter(.data$table_name == .x) %>% - display_results(n_passes, n_fails, n_warns) + display_results(n_passes, n_fails, n_warns, df_error_head_n) }) %>% htmltools::div() @@ -351,11 +366,13 @@ post_render_js <- " #' @param success Should success results be presented? #' @param warning Should warning results be presented? #' @param error Should error results be presented? +#' @param df_error_head_n Number of rows to display in error table. Works in the same way as \code{head} function. #' @export render_semantic_report_ui <- function(validation_results, success = TRUE, warning = TRUE, - error = TRUE) { + error = TRUE, + df_error_head_n = 6L) { n_passes <- NULL n_fails <- NULL n_warns <- NULL @@ -372,7 +389,8 @@ render_semantic_report_ui <- function(validation_results, n_passes, n_fails, n_warns, - validation_results + validation_results, + df_error_head_n ) %>% shiny.semantic::uirender(width = "100%", height = "100%") %>% htmlwidgets::onRender(post_render_js) diff --git a/man/display_results.Rd b/man/display_results.Rd index 868c0db..4e2c216 100644 --- a/man/display_results.Rd +++ b/man/display_results.Rd @@ -4,7 +4,7 @@ \alias{display_results} \title{Displays results of validations.} \usage{ -display_results(data, n_passes, n_fails, n_warns) +display_results(data, n_passes, n_fails, n_warns, df_error_head_n) } \arguments{ \item{data}{Report data.} @@ -14,6 +14,8 @@ display_results(data, n_passes, n_fails, n_warns) \item{n_fails}{Number of warning assertions.} \item{n_warns}{Number of violation assertions.} + +\item{df_error_head_n}{Number of rows to display in error table.} } \value{ Validation report. diff --git a/man/get_semantic_report_ui.Rd b/man/get_semantic_report_ui.Rd index 52fd0f3..2c695e3 100644 --- a/man/get_semantic_report_ui.Rd +++ b/man/get_semantic_report_ui.Rd @@ -4,7 +4,13 @@ \alias{get_semantic_report_ui} \title{Generate HTML report.} \usage{ -get_semantic_report_ui(n_passes, n_fails, n_warns, validation_results) +get_semantic_report_ui( + n_passes, + n_fails, + n_warns, + validation_results, + df_error_head_n = 6L +) } \arguments{ \item{n_passes}{Number of passed validations} @@ -14,6 +20,8 @@ get_semantic_report_ui(n_passes, n_fails, n_warns, validation_results) \item{n_warns}{Number of warnings.} \item{validation_results}{Data frame with validation results.} + +\item{df_error_head_n}{Number of rows to display in error table.} } \value{ HTML validation report. diff --git a/man/make_accordion_element.Rd b/man/make_accordion_element.Rd index f62062c..af02459 100644 --- a/man/make_accordion_element.Rd +++ b/man/make_accordion_element.Rd @@ -10,7 +10,8 @@ make_accordion_element( label, active = FALSE, type, - mark + mark, + df_error_head_n ) } \arguments{ @@ -25,6 +26,8 @@ make_accordion_element( \item{type}{Result type.} \item{mark}{Icon to display.} + +\item{df_error_head_n}{Number of rows to display in error table.} } \value{ Accordion. diff --git a/man/make_table_row.Rd b/man/make_table_row.Rd index 8752cf7..8126ef8 100644 --- a/man/make_table_row.Rd +++ b/man/make_table_row.Rd @@ -4,7 +4,7 @@ \alias{make_table_row} \title{Create table row.} \usage{ -make_table_row(results, type, mark) +make_table_row(results, type, mark, df_error_head_n) } \arguments{ \item{results}{Results to display in a row.} @@ -12,6 +12,8 @@ make_table_row(results, type, mark) \item{type}{Result type.} \item{mark}{Icon to display.} + +\item{df_error_head_n}{Number of rows to display in error table.} } \value{ Table row. diff --git a/man/prepare_modal_content.Rd b/man/prepare_modal_content.Rd index b002cbc..c9b4ff8 100644 --- a/man/prepare_modal_content.Rd +++ b/man/prepare_modal_content.Rd @@ -4,10 +4,12 @@ \alias{prepare_modal_content} \title{Prepare modal content.} \usage{ -prepare_modal_content(error) +prepare_modal_content(error, df_error_head_n) } \arguments{ \item{error}{Assertr error.} + +\item{df_error_head_n}{Number of rows to display in error table.} } \value{ Modal content. diff --git a/man/render_semantic_report_ui.Rd b/man/render_semantic_report_ui.Rd index fc09cfa..d29249d 100644 --- a/man/render_semantic_report_ui.Rd +++ b/man/render_semantic_report_ui.Rd @@ -8,7 +8,8 @@ render_semantic_report_ui( validation_results, success = TRUE, warning = TRUE, - error = TRUE + error = TRUE, + df_error_head_n = 6L ) } \arguments{ @@ -19,6 +20,8 @@ render_semantic_report_ui( \item{warning}{Should warning results be presented?} \item{error}{Should error results be presented?} + +\item{df_error_head_n}{Number of rows to display in error table. Works in the same way as \code{head} function.} } \description{ Renders content of semantic report version. diff --git a/man/result_table.Rd b/man/result_table.Rd index 0342306..5c8c4d0 100644 --- a/man/result_table.Rd +++ b/man/result_table.Rd @@ -4,7 +4,7 @@ \alias{result_table} \title{Create table with results.} \usage{ -result_table(results, type, mark) +result_table(results, type, mark, df_error_head_n) } \arguments{ \item{results}{Result to display in table.} @@ -12,6 +12,8 @@ result_table(results, type, mark) \item{type}{Result type.} \item{mark}{Icon to display.} + +\item{df_error_head_n}{Number of rows to display in error table.} } \value{ Table row. From 6d6c38ab4cf1d4c8de51494397ada07f2c364b8e Mon Sep 17 00:00:00 2001 From: Ivan Hrychaniuk Date: Fri, 8 Dec 2023 14:04:18 +0200 Subject: [PATCH 4/9] update tests --- R/semantic_report_constructors.R | 2 +- man/get_semantic_report_ui.Rd | 2 +- tests/testthat/test-report_constructors.R | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/R/semantic_report_constructors.R b/R/semantic_report_constructors.R index 4aa8050..0b2d8c1 100644 --- a/R/semantic_report_constructors.R +++ b/R/semantic_report_constructors.R @@ -334,7 +334,7 @@ make_summary_table <- function(n_passes, n_fails, n_warns) { #' @param df_error_head_n Number of rows to display in error table. #' @return HTML validation report. #' @keywords internal -get_semantic_report_ui <- function(n_passes, n_fails, n_warns, validation_results, df_error_head_n = 6L) { +get_semantic_report_ui <- function(n_passes, n_fails, n_warns, validation_results, df_error_head_n) { summary_table <- make_summary_table(n_passes, n_fails, n_warns) unique_objects <- validation_results %>% dplyr::pull(.data$table_name) %>% unique() html_report <- unique_objects %>% purrr::map(~ { diff --git a/man/get_semantic_report_ui.Rd b/man/get_semantic_report_ui.Rd index 2c695e3..5379d68 100644 --- a/man/get_semantic_report_ui.Rd +++ b/man/get_semantic_report_ui.Rd @@ -9,7 +9,7 @@ get_semantic_report_ui( n_fails, n_warns, validation_results, - df_error_head_n = 6L + df_error_head_n ) } \arguments{ diff --git a/tests/testthat/test-report_constructors.R b/tests/testthat/test-report_constructors.R index 4b54c17..43ad3b7 100644 --- a/tests/testthat/test-report_constructors.R +++ b/tests/testthat/test-report_constructors.R @@ -81,7 +81,7 @@ test_that("make_accordion_container() generates ui with 'ui styled accordion' cl test_that("prepare_modal_content() includes results' error message", { results <- results_test() - ui <- prepare_modal_content(results) + ui <- prepare_modal_content(results, df_error_head_n = 6L) tagq <- tagQuery(ui) tags <- tagq$find("td")$selectedTags() @@ -93,7 +93,7 @@ test_that("make_table_row() creates a table row tag", { results_passed <- results_test() %>% dplyr::filter(.data$type == success_id) - ui <- make_table_row(results_passed, mark = mark_success, type = success_id) + ui <- make_table_row(results_passed, mark = mark_success, type = success_id, df_error_head_n = 6L) ui <- as.character(ui) expect_true(startsWith(ui, "")) @@ -104,7 +104,7 @@ test_that("make_table_row() generates modal content for results with failed vali results_failed <- results_test() %>% dplyr::filter(.data$type == error_id) - ui <- make_table_row(results_failed, mark = mark_failed, type = error_id) + ui <- make_table_row(results_failed, mark = mark_failed, type = error_id, df_error_head_n = 6L) tagq <- tagQuery(ui) tags <- tagq$ @@ -119,7 +119,7 @@ test_that("make_table_row() generates modal content for results with failed vali gsub("\\s", "", .) - modal <- prepare_modal_content(results_failed) %>% + modal <- prepare_modal_content(results_failed, df_error_head_n = 6L) %>% as.character() %>% gsub("\\s", "", .) From 0f6d94151d8f05282aee14efa0df79b20fa0e3af Mon Sep 17 00:00:00 2001 From: Ivan Hrychaniuk Date: Fri, 8 Dec 2023 17:31:30 +0200 Subject: [PATCH 5/9] linter fix --- R/semantic_report_constructors.R | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/R/semantic_report_constructors.R b/R/semantic_report_constructors.R index 0b2d8c1..ba497cf 100644 --- a/R/semantic_report_constructors.R +++ b/R/semantic_report_constructors.R @@ -187,7 +187,15 @@ make_accordion_container <- function(...) { #' @param df_error_head_n Number of rows to display in error table. #' @return Accordion. #' @keywords internal -make_accordion_element <- function(results, color = "green", label, active = FALSE, type, mark, df_error_head_n) { +make_accordion_element <- function( + results, + color = "green", + label, + active = FALSE, + type, + mark, + df_error_head_n + ) { state <- NULL if (active) { state <- "active" @@ -204,7 +212,10 @@ make_accordion_element <- function(results, color = "green", label, active = FAL label ) ), - htmltools::div(class = paste("content", state), result_table(results, type, mark, df_error_head_n)) + htmltools::div( + class = paste("content", state), + result_table(results, type, mark, df_error_head_n) + ) ) } @@ -334,7 +345,13 @@ make_summary_table <- function(n_passes, n_fails, n_warns) { #' @param df_error_head_n Number of rows to display in error table. #' @return HTML validation report. #' @keywords internal -get_semantic_report_ui <- function(n_passes, n_fails, n_warns, validation_results, df_error_head_n) { +get_semantic_report_ui <- function( + n_passes, + n_fails, + n_warns, + validation_results, + df_error_head_n + ) { summary_table <- make_summary_table(n_passes, n_fails, n_warns) unique_objects <- validation_results %>% dplyr::pull(.data$table_name) %>% unique() html_report <- unique_objects %>% purrr::map(~ { @@ -366,7 +383,8 @@ post_render_js <- " #' @param success Should success results be presented? #' @param warning Should warning results be presented? #' @param error Should error results be presented? -#' @param df_error_head_n Number of rows to display in error table. Works in the same way as \code{head} function. +#' @param df_error_head_n Number of rows to display in error table. +#' Works in the same way as \code{head} function. #' @export render_semantic_report_ui <- function(validation_results, success = TRUE, From 185e62fddbef7ab0fc2d9256a5a5d4e3a4667c12 Mon Sep 17 00:00:00 2001 From: Ivan Hrychaniuk Date: Fri, 8 Dec 2023 17:53:30 +0200 Subject: [PATCH 6/9] linter fix 2 --- R/semantic_report_constructors.R | 38 ++++++++++++++++---------------- man/render_semantic_report_ui.Rd | 3 ++- 2 files changed, 21 insertions(+), 20 deletions(-) diff --git a/R/semantic_report_constructors.R b/R/semantic_report_constructors.R index ba497cf..6c200c3 100644 --- a/R/semantic_report_constructors.R +++ b/R/semantic_report_constructors.R @@ -153,12 +153,12 @@ result_table <- function(results, type, mark, df_error_head_n) { purrr::map( seq_len(nrow(results)), ~ make_table_row( - results[.x, ], - type, - mark, - df_error_head_n = df_error_head_n - ) + results[.x, ], + type, + mark, + df_error_head_n = df_error_head_n ) + ) ) ) } @@ -188,14 +188,14 @@ make_accordion_container <- function(...) { #' @return Accordion. #' @keywords internal make_accordion_element <- function( - results, - color = "green", - label, - active = FALSE, - type, - mark, - df_error_head_n - ) { + results, + color = "green", + label, + active = FALSE, + type, + mark, + df_error_head_n +) { state <- NULL if (active) { state <- "active" @@ -346,12 +346,12 @@ make_summary_table <- function(n_passes, n_fails, n_warns) { #' @return HTML validation report. #' @keywords internal get_semantic_report_ui <- function( - n_passes, - n_fails, - n_warns, - validation_results, - df_error_head_n - ) { + n_passes, + n_fails, + n_warns, + validation_results, + df_error_head_n +) { summary_table <- make_summary_table(n_passes, n_fails, n_warns) unique_objects <- validation_results %>% dplyr::pull(.data$table_name) %>% unique() html_report <- unique_objects %>% purrr::map(~ { diff --git a/man/render_semantic_report_ui.Rd b/man/render_semantic_report_ui.Rd index d29249d..1e0bcf2 100644 --- a/man/render_semantic_report_ui.Rd +++ b/man/render_semantic_report_ui.Rd @@ -21,7 +21,8 @@ render_semantic_report_ui( \item{error}{Should error results be presented?} -\item{df_error_head_n}{Number of rows to display in error table. Works in the same way as \code{head} function.} +\item{df_error_head_n}{Number of rows to display in error table. +Works in the same way as \code{head} function.} } \description{ Renders content of semantic report version. From 417f4bf2b7204b0876b0dc0b9fc22a3010463c72 Mon Sep 17 00:00:00 2001 From: Ivan Hrychaniuk Date: Fri, 8 Dec 2023 18:19:08 +0200 Subject: [PATCH 7/9] bump version --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 97f92f8..6a8a537 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: data.validator Type: Package Title: Automatic Data Validation and Reporting -Version: 0.2.0.9002 +Version: 0.2.0.9003 Authors@R: c(person("Marcin", "Dubel", email = "opensource+marcin@appsilon.com", role = c("aut", "cre")), person("Paweł", "Przytuła", email = "pawel@appsilon.com", role = c("aut")), person("Jakub", "Nowicki", email = "kuba@appsilon.com", role = c("aut")), From 187d254032aa0a796823ec244a8a38522c3ea897 Mon Sep 17 00:00:00 2001 From: Ivan Hrychaniuk Date: Fri, 8 Dec 2023 18:24:29 +0200 Subject: [PATCH 8/9] `df_error_head_n` example in `save_report` desc added --- R/report.R | 1 + man/save_report.Rd | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/R/report.R b/R/report.R index 7f10138..04d95c6 100644 --- a/R/report.R +++ b/R/report.R @@ -174,6 +174,7 @@ save_results <- function(report, file_name = "results.csv", method = utils::writ #' \code{data.validator} rmarkdown template to see basic construction - the one is used as a #' default template. #' @param ... Additional parameters passed to \code{ui_constructor}. +#' For example: \code{df_error_head_n} #' @export save_report <- function(report, output_file = "validation_report.html", diff --git a/man/save_report.Rd b/man/save_report.Rd index f5d69a5..abc37ca 100644 --- a/man/save_report.Rd +++ b/man/save_report.Rd @@ -29,7 +29,8 @@ generates HTML code or HTML widget that should be used to generate report conten \code{data.validator} rmarkdown template to see basic construction - the one is used as a default template.} -\item{...}{Additional parameters passed to \code{ui_constructor}.} +\item{...}{Additional parameters passed to \code{ui_constructor}. +For example: \code{df_error_head_n}} } \description{ Saving results as a HTML report From 7bbd76dd2e0fedf3c7949f5ac7e20f1c99927f6e Mon Sep 17 00:00:00 2001 From: Jakub Nowicki Date: Mon, 11 Dec 2023 10:02:45 +0100 Subject: [PATCH 9/9] chore: Rephrase the changelog entry. --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 0ed96ad..325dd58 100644 --- a/NEWS.md +++ b/NEWS.md @@ -3,7 +3,7 @@ - Swapping of `error` and `warning` arguments in `save_summary()` fixed - Fixed `validate()` function to correctly return `data-name` attribute when used in pipe chains with `%>%` or `|>` operator. - `save_results()` now uses function passed to `method` argument to write results -- Bug fix for error table in modal that always returns up to 6 rows. Now it may return full data frame. +- Enable the option to change the size of the sample of errors displayed in `render_semantic_report_ui`. # data.validator 0.2.0