From c555cbc4b3eb9c059b25fce060e619eb5e3aab77 Mon Sep 17 00:00:00 2001
From: Aptivi <eoflaoevicecity@gmail.com>
Date: Sun, 19 Jan 2025 18:49:48 +0300
Subject: [PATCH] rem - brk|doc - Remove auto-download updates

---

We no longer need to automatically download kernel updates, since we now
ship an installer.

---

Type: rem
Breaking: True
Doc Required: True
Backport Required: False
Part: 1/1
---
 Directory.Build.props                         |  5 ++--
 Makefile                                      |  4 +--
 assets/ks                                     | 17 -----------
 assets/ks-n                                   | 29 -------------------
 .../templates/KSMod/ModName.cs                |  2 +-
 .../Instances/KernelMainConfig.cs             |  4 ---
 .../Settings/SettingsAppTools.cs              | 16 +---------
 public/Nitrocid/Kernel/KernelFirstRun.cs      | 14 ---------
 .../Nitrocid/Kernel/Updates/UpdateManager.cs  | 22 +++-----------
 .../Resources/Settings/SettingsEntries.json   |  6 ----
 10 files changed, 10 insertions(+), 109 deletions(-)
 delete mode 100644 assets/ks-n

diff --git a/Directory.Build.props b/Directory.Build.props
index 3f0f3a7997..bbbbb67c18 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -23,7 +23,7 @@
           changes!
         -->
         <NitrocidModAPIVersionMajor>3.1.27</NitrocidModAPIVersionMajor>
-        <NitrocidModAPIVersionChangeset>33</NitrocidModAPIVersionChangeset>
+        <NitrocidModAPIVersionChangeset>34</NitrocidModAPIVersionChangeset>
 
         <!-- The above two properties are to be installed to the file version -->
         <NitrocidModAPIVersion>$(NitrocidModAPIVersionMajor).$(NitrocidModAPIVersionChangeset)</NitrocidModAPIVersion>
@@ -35,10 +35,9 @@
     <!--
 
       Note for constants: All Nitrocid flags should be defined by defining NitrocidFlags, not DefineConstants. Here's how you
-      define such flags: -p:NitrocidFlags=PACKAGEMANAGERBUILD
+      define such flags: -p:NitrocidFlags=VSDEBUG
 
       Supported constants (NitrocidFlags):
-          - PACKAGEMANAGERBUILD: Indicates that this build is a package manager build suitable for Launchpad PPA
           - VSDEBUG: Enables immediate window debug in the "Output" pane
 
       Possible specifiers (NitrocidReleaseSpecifier):
diff --git a/Makefile b/Makefile
index 7e96cb16bf..9c643be5bd 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 MODAPI = 27
 OUTPUTS = public/Nitrocid/KSBuild public/*/obj public/*/*/obj private/*/bin private/*/obj debian/nitrocid-$(MODAPI) debian/nitrocid-$(MODAPI)-lite debian/tmp
 OUTPUT = public/Nitrocid/KSBuild/net8.0
-BINARIES = assets/ks-n assets/ks-jl
+BINARIES = assets/ks assets/ks-jl
 MANUALS = assets/ks.1 assets/ks-jl.1
 DESKTOPS = assets/ks.desktop
 BRANDINGS = public/Nitrocid/OfficialAppIcon-NitrocidKS-512.png
@@ -46,7 +46,7 @@ install:
 	find $(OUTPUT) -mindepth 1 -type f -exec sh -c 'install -m 644 -t "$(FDESTDIR)/lib/ks-$(MODAPI)/$$(dirname $$(realpath --relative-to $(OUTPUT) "$$0"))" "$$0"' {} \;
 	install -m 755 -t $(FDESTDIR)/share/applications/ $(DESKTOPS)
 	install -m 755 -t $(FDESTDIR)/lib/ks-$(MODAPI)/ $(BRANDINGS)
-	mv $(FDESTDIR)/bin/ks-n $(FDESTDIR)/bin/ks-$(MODAPI)
+	mv $(FDESTDIR)/bin/ks $(FDESTDIR)/bin/ks-$(MODAPI)
 	mv $(FDESTDIR)/bin/ks-jl $(FDESTDIR)/bin/ks-jl-$(MODAPI)
 	mv $(FDESTDIR)/share/man/man1/ks.1 $(FDESTDIR)/share/man/man1/ks-$(MODAPI).1
 	mv $(FDESTDIR)/share/man/man1/ks-jl.1 $(FDESTDIR)/share/man/man1/ks-jl-$(MODAPI).1
diff --git a/assets/ks b/assets/ks
index 9e869ed925..498df1f293 100644
--- a/assets/ks
+++ b/assets/ks
@@ -17,13 +17,8 @@
 #    You should have received a copy of the GNU General Public License
 #    along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
-unrarpath=`which unrar`
-unrarexistent=$?
-isppa=0
-
 # Run the entry point
 if [ -e "/usr/lib/ks/Nitrocid.dll" ]; then
-	isppa=1
 	dotnet "/usr/lib/ks/Nitrocid.dll" $@
 elif [ -e "./Nitrocid.dll" ]; then
 	dotnet "./Nitrocid.dll" $@
@@ -32,15 +27,3 @@ else
 	exit 1
 fi
 
-# Check to see if we're on the PPA
-if [ $isppa == 0 ]; then
-	# Check to see if we have unrar and update.rar
-	if [ ! $unrarexistent == 0 ]; then
-		echo unrar is not found.
-		exit 1
-	fi
-	if [ -e "./update.rar" ]; then
-		echo Update found. Installing...
-		"$unrarpath" x -ep1 -r "./update.rar"
-	fi
-fi
diff --git a/assets/ks-n b/assets/ks-n
deleted file mode 100644
index 498df1f293..0000000000
--- a/assets/ks-n
+++ /dev/null
@@ -1,29 +0,0 @@
-#!/bin/sh
-
-#    Nitrocid KS  Copyright (C) 2018-2025  Aptivi
-#
-#    This file is part of Nitrocid KS
-#
-#    Nitrocid KS is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation, either version 3 of the License, or
-#    (at your option) any later version.
-#
-#    Nitrocid KS is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License
-#    along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-# Run the entry point
-if [ -e "/usr/lib/ks/Nitrocid.dll" ]; then
-	dotnet "/usr/lib/ks/Nitrocid.dll" $@
-elif [ -e "./Nitrocid.dll" ]; then
-	dotnet "./Nitrocid.dll" $@
-else
-	echo "Unable to find the entry point."
-	exit 1
-fi
-
diff --git a/public/Nitrocid.Templates/templates/KSMod/ModName.cs b/public/Nitrocid.Templates/templates/KSMod/ModName.cs
index 38b9d4fa7f..9e59c96f90 100644
--- a/public/Nitrocid.Templates/templates/KSMod/ModName.cs
+++ b/public/Nitrocid.Templates/templates/KSMod/ModName.cs
@@ -11,7 +11,7 @@ public class ModName : IMod
 
         public string Version => "1.0.0";
 
-        public Version MinimumSupportedApiVersion => new(3, 1, 27, 33);
+        public Version MinimumSupportedApiVersion => new(3, 1, 27, 34);
 
         public ModLoadPriority LoadPriority => ModLoadPriority.Optional;
 
diff --git a/public/Nitrocid/Kernel/Configuration/Instances/KernelMainConfig.cs b/public/Nitrocid/Kernel/Configuration/Instances/KernelMainConfig.cs
index 699cafdd7a..25cc833f74 100644
--- a/public/Nitrocid/Kernel/Configuration/Instances/KernelMainConfig.cs
+++ b/public/Nitrocid/Kernel/Configuration/Instances/KernelMainConfig.cs
@@ -116,10 +116,6 @@ public string CurrentLanguage
         /// </summary>
         public bool ShowStackTraceOnKernelError { get; set; }
         /// <summary>
-        /// If there is any update, the kernel will automatically download it.
-        /// </summary>
-        public bool AutoDownloadUpdate { get; set; } = true;
-        /// <summary>
         /// Enables debugging for the kernel event system
         /// </summary>
         public bool EventDebug { get; set; }
diff --git a/public/Nitrocid/Kernel/Configuration/Settings/SettingsAppTools.cs b/public/Nitrocid/Kernel/Configuration/Settings/SettingsAppTools.cs
index 8b36cc867c..11270f645e 100644
--- a/public/Nitrocid/Kernel/Configuration/Settings/SettingsAppTools.cs
+++ b/public/Nitrocid/Kernel/Configuration/Settings/SettingsAppTools.cs
@@ -31,12 +31,6 @@
 using Terminaux.Inputs.Styles;
 using Nitrocid.Kernel.Exceptions;
 
-#if SPECIFIERREL
-#if !PACKAGEMANAGERBUILD
-using Nitrocid.Kernel.Updates;
-#endif
-#endif
-
 namespace Nitrocid.Kernel.Configuration.Settings
 {
     internal static class SettingsAppTools
@@ -146,27 +140,19 @@ internal static void ReloadConfig()
 
         internal static void CheckForSystemUpdates()
         {
-#if SPECIFIERREL && !PACKAGEMANAGERBUILD
+#if SPECIFIERREL
             // Check for updates now
             InfoBoxNonModalColor.WriteInfoBox(Translate.DoTranslation("Checking for system updates..."));
             var AvailableUpdate = UpdateManager.FetchBinaryArchive();
             if (AvailableUpdate is not null)
             {
                 if (!AvailableUpdate.Updated)
-                {
                     InfoBoxModalColor.WriteInfoBoxModal(Translate.DoTranslation("Found new version: ") + $"{AvailableUpdate.UpdateVersion}");
-                }
                 else
-                {
                     InfoBoxModalColor.WriteInfoBoxModal(Translate.DoTranslation("You're up to date!"));
-                }
             }
             else if (AvailableUpdate is null)
-            {
                 InfoBoxModalColor.WriteInfoBoxModal(Translate.DoTranslation("Failed to check for updates."));
-            }
-#elif PACKAGEMANAGERBUILD
-            InfoBoxModalColor.WriteInfoBoxModal(Translate.DoTranslation("You've installed Nitrocid KS using your package manager. Please use it to upgrade your kernel instead."));
 #else
             InfoBoxModalColor.WriteInfoBoxModal(Translate.DoTranslation("Checking for updates is disabled on development versions."));
 #endif
diff --git a/public/Nitrocid/Kernel/KernelFirstRun.cs b/public/Nitrocid/Kernel/KernelFirstRun.cs
index 4cb2b6666d..cf29a3fa18 100644
--- a/public/Nitrocid/Kernel/KernelFirstRun.cs
+++ b/public/Nitrocid/Kernel/KernelFirstRun.cs
@@ -236,27 +236,13 @@ internal static void PresentFirstRun()
                                         ]
                                     }
                                 ),
-                                new InputInfo(
-                                    Translate.DoTranslation("Automatic Update Download"), Translate.DoTranslation("Automatic Update Download"),
-                                    new SelectionInputMethod()
-                                    {
-                                        Question = Translate.DoTranslation("Do you want Nitrocid KS to automatically download updates?"),
-                                        Choices =
-                                        [
-                                            new InputChoiceInfo("y", Translate.DoTranslation("Yes, I do!")),
-                                            new InputChoiceInfo("n", Translate.DoTranslation("No, thanks.")),
-                                        ]
-                                    }
-                                )
                             ]
                         )
                     ]
                 );
                 PresentationTools.Present(firstRunPresUpdates, true, true);
                 bool needsAutoCheck = (int?)firstRunPresUpdates.Pages[0].Inputs[0].InputMethod.Input == 0;
-                bool needsAutoDownload = (int?)firstRunPresUpdates.Pages[0].Inputs[1].InputMethod.Input == 0;
                 Config.MainConfig.CheckUpdateStart = needsAutoCheck;
-                Config.MainConfig.AutoDownloadUpdate = needsAutoDownload;
 
                 Slideshow firstRunPresOutro = new(
                     // Presentation name
diff --git a/public/Nitrocid/Kernel/Updates/UpdateManager.cs b/public/Nitrocid/Kernel/Updates/UpdateManager.cs
index 7372d04370..4864726a6c 100644
--- a/public/Nitrocid/Kernel/Updates/UpdateManager.cs
+++ b/public/Nitrocid/Kernel/Updates/UpdateManager.cs
@@ -139,14 +139,14 @@ public static void CheckKernelUpdates()
             // translated in the compiler pre-processor directives, so we need to move all translations here to
             // avoid this happening again and for the locale tools to actually see them.
             string devVersionWarning = Translate.DoTranslation("Checking for updates is disabled because you're running a development version.");
-            string packageManagerError = Translate.DoTranslation("You've installed Nitrocid KS using your package manager. Please use it to upgrade your kernel instead.");
             string checkFailed = Translate.DoTranslation("Failed to check for updates.");
             string checking = Translate.DoTranslation("Checking for system updates...");
             string newVersion = Translate.DoTranslation("Found new version: ");
             string downloaded = Translate.DoTranslation("Downloaded the update successfully!");
             string downloadManually = Translate.DoTranslation("You can download it at: ");
             string upToDate = Translate.DoTranslation("You're up to date!");
-#if SPECIFIERREL && !PACKAGEMANAGERBUILD
+
+#if SPECIFIERREL
             // Check for updates now
             SplashReport.ReportProgress(checking, 10);
             var AvailableUpdate = FetchBinaryArchive();
@@ -156,28 +156,14 @@ public static void CheckKernelUpdates()
                 {
                     SplashReport.ReportProgress(newVersion, 10);
                     SplashReport.ReportProgress(AvailableUpdate.UpdateVersion.ToString(), 10);
-                    if (Config.MainConfig.AutoDownloadUpdate)
-                    {
-                        NetworkTransfer.DownloadFile(AvailableUpdate.UpdateURL.ToString(), Path.Combine(PathsManagement.ExecPath, "update.zip"));
-                        SplashReport.ReportProgress(downloaded, 10);
-                    }
-                    else
-                    {
-                        SplashReport.ReportProgress(downloadManually, 10);
-                        SplashReport.ReportProgress(AvailableUpdate.UpdateURL.ToString(), 10);
-                    }
+                    SplashReport.ReportProgress(downloadManually, 10);
+                    SplashReport.ReportProgress(AvailableUpdate.UpdateURL.ToString(), 10);
                 }
                 else
-                {
                     SplashReport.ReportProgress(upToDate, 10);
-                }
             }
             else if (AvailableUpdate is null)
-            {
                 SplashReport.ReportProgressError(checkFailed);
-            }
-#elif PACKAGEMANAGERBUILD
-            SplashReport.ReportProgressError(packageManagerError);
 #else
             SplashReport.ReportProgressWarning(devVersionWarning);
 #endif
diff --git a/public/Nitrocid/Resources/Settings/SettingsEntries.json b/public/Nitrocid/Resources/Settings/SettingsEntries.json
index 39bbe08ae1..17d1ae92a4 100644
--- a/public/Nitrocid/Resources/Settings/SettingsEntries.json
+++ b/public/Nitrocid/Resources/Settings/SettingsEntries.json
@@ -152,12 +152,6 @@
                         "Type": "SBoolean",
                         "Variable": "CheckUpdateStart",
                         "Description": "Each startup, it will check for updates."
-                    },
-                    {
-                        "Name": "Automatically download updates",
-                        "Type": "SBoolean",
-                        "Variable": "AutoDownloadUpdate",
-                        "Description": "If there is any update, the kernel will automatically download it."
                     }
                 ]
             },