Skip to content

Commit de94574

Browse files
committed
Removed direct Game reference from Players header to speed up build
1 parent f9b8e22 commit de94574

File tree

6 files changed

+19
-4
lines changed

6 files changed

+19
-4
lines changed

Server/Server/ConnectedUser.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include <iostream>
22
#include "ConnectedUser.h"
3+
#include "Game.h"
34
#include "Player.h"
45
#include "NetworkServices.h"
56
#include "ServerNetwork.h"

Server/Server/PacketHandlers/CardHandler.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include "PacketHandler.h"
22
#include "../ConnectedUser.h"
33
#include "../DataHolder.h"
4+
#include "../Game.h"
45
#include "../Player.h"
56
#include "../Cards/PlayableCard.h"
67
#include "../../Shared/SharedDefines.h"

Server/Server/PacketHandlers/ChatHandler.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include "PacketHandler.h"
22
#include "../ConnectedUser.h"
3+
#include "../Game.h"
34
#include "../Player.h"
45
#include "../ServerNetwork.h"
56
#include "../../Shared/SharedDefines.h"

Server/Server/PacketHandlers/MiscHandler.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include "PacketHandler.h"
22
#include "../ConnectedUser.h"
3+
#include "../Game.h"
34
#include "../Player.h"
45
#include "../../Shared/SharedDefines.h"
56
#include "../../Crypto/Aes.h"

Server/Server/Player.cpp

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
#include <algorithm>
22
#include <random>
3-
#include "Player.h"
43
#include "ConnectedUser.h"
54
#include "DataHolder.h"
5+
#include "Game.h"
6+
#include "Player.h"
67
#include "ServerNetwork.h"
78
#include "Cards/PlayableCard.h"
89
#include "PacketHandlers/PacketHandler.h"
@@ -257,6 +258,16 @@ inline std::string_view Player::GetName() const
257258
return m_user->GetName();
258259
}
259260

261+
inline Player* Player::GetOpponent() const
262+
{
263+
return m_game->GetOpponent(this);
264+
}
265+
266+
inline bool Player::IsActive() const
267+
{
268+
return m_game->GetActivePlayer() == this;
269+
}
270+
260271
void Player::SendGameInfo() const
261272
{
262273
Player const* opponent = GetOpponent();

Server/Server/Player.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
#include <string>
44
#include <vector>
55
#include <list>
6-
#include "Game.h"
76
#include "PlayerDefines.h"
87
#include "Cards/CardDefines.h"
98
#include "Spells/SpellDefines.h"
109

1110
class Card;
1211
class ConnectedUser;
12+
class Game;
1313
class Packet;
1414
class PlayableCard;
1515
class Spell;
@@ -67,7 +67,7 @@ class Player
6767
void Disconnect() const;
6868
void HandleDeckCards(bool addCard);
6969

70-
Player* GetOpponent() const { return m_game->GetOpponent(this); }
70+
Player* GetOpponent() const;
7171
PlayableCard* GetCurrentCard();
7272
CardsMap const& GetCards() const { return m_cards; }
7373
std::vector<PlayableCard*> const& GetCurrentCards() const { return m_currentCards; }
@@ -78,5 +78,5 @@ class Player
7878
std::string_view GetName() const;
7979
ConnectedUser* GetUser() const { return m_user; }
8080
bool IsPrepared() const { return m_isPrepared; }
81-
bool IsActive() const { return m_game->GetActivePlayer() == this; }
81+
bool IsActive() const;
8282
};

0 commit comments

Comments
 (0)