From 8440c5b3100bf3d6d28f5a7fcacd998fcf58f8be Mon Sep 17 00:00:00 2001 From: Zulkhair Abdullah Daim <53172227+zulkhair@users.noreply.github.com> Date: Sat, 22 Jun 2024 03:38:33 +0700 Subject: [PATCH] fix: add nakama-debug on docker-compose to fix debug mode (#51) Adding nakama-debug on docker-compose.yml to fix running cardinal on debug mode `--debug` flag. Previously `cardinal-debug` container need `nakama` but `nakama` depends-on `cardinal` not `cardinal-debug` so this results an error when running cardinal with debug mode. ** ~~Updated using two docker-compose file. CLI will run with args -f docker-compose.yml -f docker-compose.debug.yml up in --debug mode and it will override the first docker-compose file with the second one.~~ Updated using short syntax with envar passed from world-cli --- docker-compose.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index aa5be31..8c48e7d 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -21,7 +21,7 @@ services: - REDIS_MODE=normal - ROUTER_KEY=${ROUTER_KEY} restart: unless-stopped - + cardinal-debug: container_name: cardinal-debug build: @@ -85,10 +85,8 @@ services: image: ghcr.io/argus-labs/world-engine-nakama:1.2.5 container_name: nakama depends_on: - nakama-db: - condition: service_healthy - cardinal: - condition: service_started + - "nakama-db" + - "${CARDINAL_CONTAINER:-cardinal}" environment: - CARDINAL_ADDR=${CARDINAL_ADDR:-cardinal:4040} - CARDINAL_NAMESPACE=${CARDINAL_NAMESPACE}