maybe const ref

Author: SuperFola

lib/std

@@ -81,7 +81,7 @@ ut::suite<"Compiler"> compiler_suite = [] {
 
         iterTestFiles(
             "CompilerSuite/ir",
-            [](TestData&& data) {
+            [](const TestData& data) {
                 Ark::Welder welder(0, { lib_path }, features);
 
                 should("compile without error ir/" + data.stem) = [&] {
@@ -103,7 +103,7 @@ ut::suite<"Compiler"> compiler_suite = [] {
 
         iterTestFiles(
             "CompilerSuite/optimized_ir",
-            [](TestData&& data) {
+            [](const TestData& data) {
                 Ark::Welder welder(0, { lib_path }, features);
 
                 should("compile without error optimized_ir/" + data.stem) = [&] {

tests/unittests/Suites/CompilerSuite.cpp

@@ -14,7 +14,7 @@ ut::suite<"Diagnostics"> diagnostics_suite = [] {
 
     iterTestFiles(
         "DiagnosticsSuite/compileTime",
-        [](TestData&& data) {
+        [](const TestData& data) {
             Ark::State state({ lib_path });
 
             should("generate an error message at compile time for compileTime/" + data.stem) = [&] {
@@ -36,7 +36,7 @@ ut::suite<"Diagnostics"> diagnostics_suite = [] {
 
     iterTestFiles(
         "DiagnosticsSuite/runtime",
-        [](TestData&& data) {
+        [](const TestData& data) {
             Ark::State state({ lib_path });
 
             should("compile without error runtime/" + data.stem) = [&] {
@@ -62,7 +62,7 @@ ut::suite<"Diagnostics"> diagnostics_suite = [] {
 
     iterTestFiles(
         "DiagnosticsSuite/typeChecking",
-        [](TestData&& data) {
+        [](const TestData& data) {
             Ark::State state({ lib_path });
 
             should("compile without error typeChecking/" + data.stem) = [&] {

tests/unittests/Suites/DiagnosticsSuite.cpp

@@ -11,7 +11,7 @@ ut::suite<"Formatter"> formatter_suite = [] {
 
     iterTestFiles(
         "FormatterSuite",
-        [](TestData&& data) {
+        [](const TestData& data) {
             std::string formatted_code;
 
             should("output a correctly formatted code for " + data.stem) = [&] {

tests/unittests/Suites/FormatterSuite.cpp

@@ -13,7 +13,7 @@ ut::suite<"Optimizer"> optimizer_suite = [] {
     "[generate optimized ast]"_test = [] {
         iterTestFiles(
             "OptimizerSuite",
-            [](TestData&& data) {
+            [](const TestData& data) {
                 JsonCompiler compiler(false, { lib_path }, Ark::FeatureASTOptimizer);
 
                 std::string json;

tests/unittests/Suites/OptimizerSuite.cpp

@@ -46,7 +46,7 @@ ut::suite<"Parser"> parser_suite = [] {
     "[successful parsing]"_test = [] {
         iterTestFiles(
             "ParserSuite/success",
-            [](TestData&& data) {
+            [](const TestData& data) {
                 Ark::internal::Parser parser(/* debug= */ 0);
 
                 should("parse " + data.stem) = [&] {
@@ -68,7 +68,7 @@ ut::suite<"Parser"> parser_suite = [] {
     "[error reporting]"_test = [] {
         iterTestFiles(
             "ParserSuite/failure",
-            [](TestData&& data) {
+            [](const TestData& data) {
                 try
                 {
                     Ark::internal::Parser parser(/* debug= */ 0);

tests/unittests/Suites/ParserSuite.cpp

@@ -13,7 +13,7 @@ ut::suite<"Rosetta"> rosetta_suite = [] {
     "[run arkscript rosetta code solutions]"_test = [] {
         iterTestFiles(
             "RosettaSuite",
-            [](TestData&& data) {
+            [](const TestData&data) {
                 Ark::State state({ lib_path });
 
                 should("compile " + data.stem) = [&] {

tests/unittests/Suites/RosettaSuite.cpp

@@ -177,15 +177,15 @@ ut::suite<"TypeChecker"> type_checker_suite = [] {
 
     iterTestFiles(
         "TypeCheckerSuite",
-        [&](TestData&& data) {
+        [&](const TestData& data) {
             std::vector<Input> inputs;
             std::vector<Ark::types::Contract> contracts;
 
             if (data.is_folder)
             {
                 iterTestFiles(
                     data.path,
-                    [&inputs](TestData&& inner) {
+                    [&inputs](const TestData& inner) {
                         const Input input = parse_input(inner.path);
                         expect(fatal(input.initialized)) << "invalid test input: " << inner.stem;
                         inputs.push_back(input);

tests/unittests/Suites/TypeCheckerSuite.cpp

@@ -13,7 +13,7 @@ ut::suite<"AST"> ast_suite = [] {
     "[generate valid ast]"_test = [] {
         iterTestFiles(
             "ASTSuite",
-            [](TestData&& data) {
+            [](const TestData& data) {
                 JsonCompiler compiler(false, { lib_path });
 
                 std::string json;

tests/unittests/Suites/ValidAstSuite.cpp

@@ -28,7 +28,7 @@ void updateExpectedFile(const TestData& data, const std::string& actual)
     }
 }
 
-void iterTestFiles(const std::string& folder, std::function<void(TestData&&)>&& test, IterTestFilesParam&& params)
+void iterTestFiles(const std::string& folder, std::function<void(const TestData&)>&& test, IterTestFilesParam&& params)
 {
     boost::ut::test(folder) = [&] {
         const auto path = params.folder_is_resource ? getResourcePath(folder) : folder;
@@ -58,8 +58,8 @@ void iterTestFiles(const std::string& folder, std::function<void(TestData&&)>&&
                 .is_folder = is_directory(entry.path())
             };
 
-            std::cout << "test on '" << entry.path().generic_string() << std::endl;
-            test(std::move(data));
+            std::cout << "test on '" << entry.path().generic_string() << "'" << std::endl;
+            test(data);
         }
     };
 }