fix(name resolver): couldn't import two different files with the same symbol names inside, even though both were hidden and prefixed by their file

Author: SuperFola

src/arkreactor/Compiler/NameResolution/NameResolutionPass.cpp

@@ -7,8 +7,7 @@
 namespace Ark::internal
 {
     NameResolutionPass::NameResolutionPass(const unsigned debug) :
-        Pass("NameResolution", debug),
-        m_ast()
+        Pass("NameResolution", debug)
     {
         for (const auto& builtin : Builtins::builtins)
             m_language_symbols.emplace(builtin.first);

src/arkreactor/Compiler/NameResolution/ScopeResolver.cpp

@@ -70,8 +70,11 @@ namespace Ark::internal
         {
             if (auto maybe_fqn = scope->get(name, true); maybe_fqn.has_value())
             {
-                // priorize non-hidden symbols
-                if ((maybe_name.has_value() && maybe_name.value().ends_with("#hidden")) || !maybe_name.has_value())
+                // prioritize non-hidden symbols
+                if ((maybe_name.has_value() &&
+                     maybe_name.value().ends_with("#hidden") &&
+                     !maybe_fqn.value().name.ends_with("#hidden")) ||
+                    !maybe_name.has_value())
                     maybe_name = maybe_fqn.value().name;
             }
         }

tests/unittests/Suites/NameResolutionSuite.cpp

@@ -163,4 +163,22 @@ ut::suite<"NameResolution"> name_resolution_suite = [] {
             expect(a_map.valueType() == Ark::ValueType::True) << "(= (map) \"c:map\")\n";
         };
     };
+
+    "[importing two symbols from different modules with the same hidden symbols should resolve correctly]"_test = [] {
+        Ark::State state({ lib_path });
+
+        should("compile the resource without any error") = [&] {
+            expect(mut(state).doFile(getResourcePath("NameResolutionSuite/hidden_shadowing/a.ark")));
+        };
+
+        Ark::VM vm(state);
+        should("return exit code 0") = [&] {
+            expect(mut(vm).run() == 0_i);
+        };
+
+        should("resolve symbols from all namespaces without generating bad fully qualified names") = [&] {
+            const auto a_ok = mut(vm).operator[]("ok");
+            expect(a_ok.valueType() == Ark::ValueType::True) << "(and (= foo \"b:foo\") (= bar \"c:bar\"))\n";
+        };
+    };
 };

tests/unittests/resources/NameResolutionSuite/hidden_shadowing/a.ark

@@ -0,0 +1,4 @@
+(import b :foo)
+(import c :bar)
+
+(let ok (and (= foo "b:foo") (= bar "c:bar")))

tests/unittests/resources/NameResolutionSuite/hidden_shadowing/b.ark

@@ -0,0 +1,4 @@
+(let find "b.ark")
+(let petrol (fun () find))
+
+(let foo "b:foo")

tests/unittests/resources/NameResolutionSuite/hidden_shadowing/c.ark

@@ -0,0 +1,4 @@
+(let find "c.ark")
+(let test (fun () find))
+
+(let bar "c:bar")