Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend_read should not shrink genes. #10

Open
ericfournier2 opened this issue Mar 23, 2019 · 2 comments
Open

extend_read should not shrink genes. #10

ericfournier2 opened this issue Mar 23, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ericfournier2
Copy link

If the extend_read value is smaller than certain reads, those should not be affected. Right now, those are shrunk.

An appropriate test is commented out at the end of the test.metagene_extend_reads in inst/unitTests/test_metagene.R . Make sure to uncomment it once this bug is fixed.

@ericfournier2 ericfournier2 self-assigned this Mar 23, 2019
@ericfournier2 ericfournier2 added the bug Something isn't working label Mar 23, 2019
@ericfournier2
Copy link
Author

Unit test now stand-alone in test.metagene_extend_reads_no_shrink

@ericfournier2
Copy link
Author

ericfournier2 commented May 13, 2019

We've received a request from a metagene(1) user inquiring about how to trim reads. extend_reads' current implementation happened to fit his needs.

In our specific use case, we are interested in only the 5’ position of the read, and we are dealing with reads that have variable length. As such, your tool is working well for us, but we would like to only display either:

  1. Only the 5’ mapping position of each read

or

  1. Only a specific number of bases for each read

In option 1, I think this would require adding a new parameter option within your code. This is something that is important for many assays which are fine-mapping genomic events. We would be very grateful for this additional utility.

For option 2, we can use a tool like BamUtil’s trimBam to soft-clip the already mapped reads to a shorter length. For this option, we would like to know if your BAM read counter is still going to calculate coverage over a genomic position if the read has soft-clipped bases at that position.

After advising them of the existence of this new parameter in metagene2:

We’ll fix read lengths to something short (5bp) for more fine-mapped visualization purposes. We are essentially using this tool to display meta-plots of transposon insertion events into the genome.

So maybe what we need is a "trim_reads" and an "extend_reads" option. Maybe a "set_read_size" one? Shrinking reads are still a bug given the parameter's name, but the functionality should be kept.

So, basically, this bug covers a needed functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant