Skip to content

Fix borderRadius display error when there is only 2 options #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srhb18 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix borderRadius display error when there is only 2 options #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533967a
Fix borderRadius display error when there is only 2 options
srhb18 Jul 25, 2017
d8e09ac
Update segmented-controls.js
srhb18 Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/segmented-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class SegmentedControls extends React.Component {
borderBottomRightRadius: adjustedBorderRadius
}
}
if (index === this.props.options.length - 2) {
Copy link

@eHammarstrom eHammarstrom Aug 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply changing if to else if solves the problem. The additional conditional does not seem necessary.

Copy link

@costagolub costagolub Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eHammarstrom when this fix going to be merged?
Thanks!

if (index === this.props.options.length - 2 && this.props.options.length !== 2) {
borderRadiusStyle = config.direction === 'row' ?
{
borderRightWidth: config.separatorWidth,
Expand Down