-
Notifications
You must be signed in to change notification settings - Fork 0
208 lines (173 loc) · 8.8 KB
/
validate_new_changes.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
name: "New changes validation"
on:
pull_request: # yamllint disable-line rule:empty-values
permissions:
contents: "read"
packages: "read"
env:
REGISTRY: "ghcr.io"
IMAGE_NAME: "articola-tools/yaml-linter"
jobs:
find-changed-files:
runs-on: "ubuntu-latest"
outputs:
is_yaml_changed: "${{ steps.filter.outputs.yaml }}"
is_dockerfile_changed: "${{ steps.filter.outputs.dockerfile }}"
is_yaml_linter_image_changed: "${{ steps.filter.outputs.yaml-linter-image }}"
is_markdown_changed: "${{ steps.filter.outputs.markdown }}"
changed_or_added_files: "${{ steps.filter.outputs.changed-or-added-files }}"
changed_or_added_files_list: "${{ steps.filter.outputs.changed-or-added-files_files }}"
permissions:
pull-requests: "read"
steps:
- name: "Checkout ${{ github.event.repository.name }}"
uses: "actions/checkout@v4"
with:
fetch-depth: 1
- name: "Find changed files"
uses: "dorny/paths-filter@v3"
id: "filter"
with:
list-files: "shell"
filters: |
yaml:
- "**/*.yaml"
- "**/*.yml"
dockerfile:
- "**/Dockerfile"
yaml-linter-image:
- "**/Dockerfile"
- "**/.dockerignore"
- "**/.yamllint"
markdown:
- "**/*.md"
changed-or-added-files:
- added|modified: '**'
validate-yaml-linter-image:
runs-on: "ubuntu-latest"
needs: "find-changed-files"
if: "${{ needs.find-changed-files.outputs.is_yaml_linter_image_changed == 'true' }}"
# NOTE: building and running Docker image of YAML linter take around 1 minute.
# If this job takes more than 5 minutes, it means that something is wrong.
timeout-minutes: 5
steps:
- name: "Checkout ${{ github.event.repository.name }}"
uses: "actions/checkout@v4"
- name: "Set up Docker Buildx"
uses: "docker/setup-buildx-action@v3"
- name: "Login to Docker registry"
uses: "docker/login-action@v3"
with:
registry: "${{ env.REGISTRY }}"
username: "${{ github.actor }}"
password: "${{ secrets.GITHUB_TOKEN }}"
- name: "Build YAML linter Docker image"
uses: "docker/build-push-action@v6"
with:
# NOTE: setup of `context` is needed to force builder to use the `.dockerignore` file.
context: "."
push: false
load: true
# NOTE: using another name to don't allow docker to download image from the internet in the next step.
tags: "local/yaml-linter-pr:latest"
cache-from: "type=registry,ref=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest"
cache-to: "type=inline"
- name: "Test correctly formatted YAML"
run: "docker run --rm -v ${{ github.workspace }}/tests/correct_yaml:/linter_workdir/repo
local/yaml-linter-pr:latest"
- name: "Test incorrectly formatted YAML"
run: "docker run --rm -v ${{ github.workspace }}/tests/incorrect_yaml:/linter_workdir/repo
local/yaml-linter-pr:latest && { echo 'Incorrectly formatted YAML test must fail!' >&2; exit 1; }
|| exit 0"
# HACK: remove `tests` directory before linting repo directory because there is no way to easily ignore folder
# from yamllinter CLI.
- name: "Remove `tests` directory"
run: "rm -rf ${{ github.workspace }}/tests"
- name: "Lint repo directory"
run: "docker run --rm -v ${{ github.workspace }}:/linter_workdir/repo local/yaml-linter-pr:latest"
- name: "Run Dockerfile security scanner"
run: "docker run --rm --group-add $(getent group docker | cut -d: -f3)
-v /var/run/docker.sock:/var/run/docker.sock
ghcr.io/articola-tools/dockerfile-security-scanner local/yaml-linter-pr:latest"
validate-dockerfile-changes:
runs-on: "ubuntu-latest"
needs: "find-changed-files"
if: "${{ needs.find-changed-files.outputs.is_dockerfile_changed == 'true' }}"
# NOTE: validating Dockerfile changes takes around 1 minute.
# If this job takes more than 5 minutes, it means that something is wrong.
timeout-minutes: 5
steps:
- name: "Checkout ${{ github.event.repository.name }}"
uses: "actions/checkout@v4"
- name: "Login to Docker registry"
uses: "docker/login-action@v3"
with:
registry: "${{ env.REGISTRY }}"
username: "${{ github.actor }}"
password: "${{ secrets.GITHUB_TOKEN }}"
- name: "Run Dockerfile linter"
run: "docker run --rm -v ${{ github.workspace }}:/linter_workdir/repo
${{ env.REGISTRY }}/articola-tools/dockerfile-linter:latest"
validate-yaml-changes:
runs-on: "ubuntu-latest"
needs: "find-changed-files"
# NOTE: do not run this job when `is_yaml_linter_image_changed` is true, because this job validates YAML changes
# with the latest released yaml-linter image, and new changes in yaml-linter image can introduce false positives for
# this job (since changes in yaml-linter can change YAML rules).
if: "${{ needs.find-changed-files.outputs.is_yaml_changed == 'true'
&& needs.find-changed-files.outputs.is_yaml_linter_image_changed == 'false' }}"
# NOTE: validating YAML changes takes around 1 minute.
# If this job takes more than 5 minutes, it means that something is wrong.
timeout-minutes: 5
steps:
- name: "Checkout ${{ github.event.repository.name }}"
uses: "actions/checkout@v4"
- name: "Login to Docker registry"
uses: "docker/login-action@v3"
with:
registry: "${{ env.REGISTRY }}"
username: "${{ github.actor }}"
password: "${{ secrets.GITHUB_TOKEN }}"
# HACK: remove `tests` directory before linting repo directory because there is no way to easily ignore folder
# from yamllinter CLI.
- name: "Remove `tests` directory"
run: "rm -rf ${{ github.workspace }}/tests"
- name: "Run YAML linter"
run: "docker run --rm -v ${{ github.workspace }}:/linter_workdir/repo
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest"
validate-markdown-changes:
runs-on: "ubuntu-latest"
needs: "find-changed-files"
if: "${{ needs.find-changed-files.outputs.is_markdown_changed == 'true' }}"
# NOTE: validating Markdown changes takes around 1 minute.
# If this job takes more than 5 minutes, it means that something is wrong.
timeout-minutes: 5
steps:
- name: "Checkout ${{ github.event.repository.name }}"
uses: "actions/checkout@v4"
- name: "Login to Docker registry"
uses: "docker/login-action@v3"
with:
registry: "${{ env.REGISTRY }}"
username: "${{ github.actor }}"
password: "${{ secrets.GITHUB_TOKEN }}"
- name: "Run Dockerfile linter"
run: "docker run --rm -v ${{ github.workspace }}:/linter_workdir/repo
${{ env.REGISTRY }}/articola-tools/markdown-linter:latest"
validate-file-paths:
runs-on: "ubuntu-latest"
needs: "find-changed-files"
if: "${{ needs.find-changed-files.outputs.changed_or_added_files == 'true' }}"
# NOTE: validating file paths takes around 1 minute.
# If this job takes more than 5 minutes, it means that something is wrong.
timeout-minutes: 5
steps:
- name: "Validate file paths"
run: |
for path in ${{ needs.find-changed-files.outputs.changed_or_added_files_list }}; do
# NOTE: ignore `.idea` folder because it's generated. Ignore files with special names.
if [[ "$path" != .idea* && "$path" != *Dockerfile && "$path" != *README.md && "$path" != *LICENSE ]]; then
docker run --rm ${{ env.REGISTRY }}/articola-tools/file-path-validator \
--naming-convention snake_case --path-to-validate "$path";
fi
done