Skip to content

Commit 3e1cccd

Browse files
committed
fix(main): handle the case of missing resposnes key
1 parent c01e63f commit 3e1cccd

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

app/Command/Report/SafeController.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public function checkResponsePropertyRemovals($last_open_api, $current_open_api)
163163
// for matching operations...
164164
foreach (PapiMethods::matchingOperationKeys($last_open_api, $current_open_api) as $operation_key) {
165165
$last_operation = PapiMethods::getOperation($last_open_api, $operation_key);
166-
$last_responses = $last_operation->responses;
166+
$last_responses = isset($last_operation->responses) ?? [];
167167

168168
// for each response...
169169
if (count($last_responses) > 0) {
@@ -257,10 +257,10 @@ public function checkResponseRemovals($last_open_api, $current_open_api)
257257

258258
// for matching operations...
259259
foreach (PapiMethods::matchingOperationKeys($last_open_api, $current_open_api) as $operation_key) {
260-
$last_operation_responses = PapiMethods::getOperation($last_open_api, $operation_key)->responses;
260+
$last_operation_responses = isset(PapiMethods::getOperation($last_open_api, $operation_key)->responses) ?? [];
261261
$last_operation_codes = array_keys(PapiMethods::objectToArray($last_operation_responses));
262262

263-
$current_operation_responses = PapiMethods::getOperation($current_open_api, $operation_key)->responses;
263+
$current_operation_responses = isset(PapiMethods::getOperation($current_open_api, $operation_key)->responses) ?? [];
264264
$current_operation_codes = array_keys(PapiMethods::objectToArray($current_operation_responses));
265265

266266
$diff = array_diff($last_operation_codes, $current_operation_codes);
@@ -322,9 +322,10 @@ public function checkResponsePropertyTypeChanged($last_open_api, $current_open_a
322322
// for matching operations...
323323
foreach (PapiMethods::matchingOperationKeys($last_open_api, $current_open_api) as $operation_key) {
324324
$last_operation = PapiMethods::getOperation($last_open_api, $operation_key);
325+
$last_operation_responses = isset($last_operation->responses) ?? [];
325326

326327
// for each response...
327-
foreach ($last_operation->responses as $status_code => $last_operation_response) {
328+
foreach ($last_operation_responses as $status_code => $last_operation_response) {
328329
$current_operation_response = PapiMethods::getOperationResponse($current_open_api, $operation_key, $status_code);
329330

330331
// does the current spec have a response for this status code?
@@ -423,7 +424,7 @@ public function checkEnumsChanged($last_open_api, $current_open_api)
423424
// for matching operations...
424425
foreach (PapiMethods::matchingOperationKeys($last_open_api, $current_open_api) as $operation_key) {
425426
$last_operation = PapiMethods::getOperation($last_open_api, $operation_key);
426-
$last_operation_responses = $last_operation->responses;
427+
$last_operation_responses = isset($last_operation->responses) ?? [];
427428
$last_operation_parameters = $last_operation->parameters;
428429

429430
$current_operation = PapiMethods::getOperation($current_open_api, $operation_key);
@@ -524,7 +525,7 @@ public function checkResponsePropertyNowNullable($last_open_api, $current_open_a
524525
// for matching operations...
525526
foreach (PapiMethods::matchingOperationKeys($last_open_api, $current_open_api) as $operation_key) {
526527
$last_operation = PapiMethods::getOperation($last_open_api, $operation_key);
527-
$last_operation_responses = $last_operation->responses;
528+
$last_operation_responses = isset($last_operation->responses) ?? [];
528529

529530
// for each response...
530531
foreach ($last_operation_responses as $status_code => $last_operation_response) {

0 commit comments

Comments
 (0)