Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add account number to rate-limit response #1558

Closed
benjy3gg opened this issue Jul 24, 2024 · 1 comment
Closed

Feature Request: Add account number to rate-limit response #1558

benjy3gg opened this issue Jul 24, 2024 · 1 comment

Comments

@benjy3gg
Copy link

Could you please add the account number to the rate-limit response?
i am using signal-cli-rest-api in rpc mode and i get the following response when i try to send a message and a rate-limit is encountered:

{"jsonrpc":"2.0","error":{"code":-5,"message":"Failed to send message due to rate limiting","data":{"response":{"timestamp":1721686852997,"results":[{"recipientAddress":{"uuid":"xxxx-xxxx","number":"+0123456789"},"type":"RATE_LIMIT_FAILURE","token":"xxxx-xxxx-xxxxxyy","retryAfterSeconds":86400}]}}},"id":"xxxxxx-xxyxyyyy"}

i am using it in multi-number mode, so it would be nice to have the account-number in the response so that i can directly unblock it.

@AsamK
Copy link
Owner

AsamK commented Jul 25, 2024

hm, the rate-limit response already includes the "id" field, which corresponds to the id of the send message request.
So using that you should already have the information which account triggered the rate limiting.

@AsamK AsamK closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants