Skip to content

Commit ecaf8c1

Browse files
author
karel de Heer
committed
Early exit of NextVersion() when AutoIncrement.None
1 parent 665e121 commit ecaf8c1

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

src/Verlite.Core/VersionCalculator.cs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,16 @@ public static SemVer Bump(SemVer version, VersionCalculationOptions options, int
2424
if (height < 1)
2525
throw new ArgumentOutOfRangeException(nameof(height), height, "Must be greater than zero.");
2626

27-
SemVer ret = version;
28-
if (options.AutoIncrement != VersionPart.None)
27+
if (options.AutoIncrement == VersionPart.None)
2928
{
30-
ret.Prerelease ??= options.DefaultPrereleasePhase;
31-
ret.BuildMetadata = options.BuildMetadata;
32-
ret.Prerelease += $".{options.PrereleaseBaseHeight + (height - 1)}";
29+
return version;
3330
}
3431

32+
SemVer ret = version;
33+
ret.Prerelease ??= options.DefaultPrereleasePhase;
34+
ret.BuildMetadata = options.BuildMetadata;
35+
ret.Prerelease += $".{options.PrereleaseBaseHeight + (height - 1)}";
36+
3537
return ret;
3638
}
3739
/// <summary>
@@ -45,12 +47,13 @@ public static SemVer NextVersion(SemVer lastTag, VersionCalculationOptions optio
4547
{
4648
if (options.MinimumVersion > lastTag.CoreVersion)
4749
return options.MinimumVersion;
50+
if (options.AutoIncrement == VersionPart.None)
51+
return lastTag;
4852

4953
if (lastTag.Prerelease is null)
5054
{
5155
return options.AutoIncrement switch
5256
{
53-
VersionPart.None => lastTag,
5457
VersionPart.Patch => new SemVer(lastTag.Major, lastTag.Minor, lastTag.Patch + 1),
5558
VersionPart.Minor => new SemVer(lastTag.Major, lastTag.Minor + 1, 0),
5659
VersionPart.Major => new SemVer(lastTag.Major + 1, 0, 0),

0 commit comments

Comments
 (0)